apply new cs-fixer and phpstan rules

Author: Mathieu Lemoine

AbstractAsyncEventDispatcher.php

@@ -19,10 +19,6 @@ abstract class AbstractAsyncEventDispatcher extends EventDispatcher implements E
      */
     protected $asyncListener;
 
-    /**
-     * @param EventDispatcherInterface $trueEventDispatcher
-     * @param AsyncListener            $asyncListener
-     */
     public function __construct(EventDispatcherInterface $trueEventDispatcher, AsyncListener $asyncListener)
     {
         $this->trueEventDispatcher = $trueEventDispatcher;

AbstractAsyncListener.php

@@ -4,7 +4,6 @@
 
 use Interop\Queue\Context;
 use Interop\Queue\Queue;
-use Symfony\Component\EventDispatcher\Event;
 
 abstract class AbstractAsyncListener
 {
@@ -29,8 +28,6 @@ abstract class AbstractAsyncListener
     protected $syncMode;
 
     /**
-     * @param Context      $context
-     * @param Registry     $registry
      * @param Queue|string $eventQueue
      */
     public function __construct(Context $context, Registry $registry, $eventQueue)

AbstractPhpSerializerEventTransformer.php

@@ -4,9 +4,6 @@
 
 use Interop\Queue\Context;
 use Interop\Queue\Message;
-use Symfony\Component\EventDispatcher\Event;
-use Symfony\Component\EventDispatcher\LegacyEventDispatcherProxy;
-use Symfony\Contracts\EventDispatcher\Event as ContractEvent;
 
 abstract class AbstractPhpSerializerEventTransformer
 {
@@ -15,17 +12,11 @@ abstract class AbstractPhpSerializerEventTransformer
      */
     protected $context;
 
-    /**
-     * @param Context $context
-     */
     public function __construct(Context $context)
     {
         $this->context = $context;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function toEvent($eventName, Message $message)
     {
         return unserialize($message->getBody());

AsyncEventDispatcher.php

@@ -7,7 +7,7 @@
 
 if (class_exists(Event::class) && !class_exists(LegacyEventDispatcherProxy::class)) {
     /**
-     * Symfony < 4.3
+     * Symfony < 4.3.
      */
     class AsyncEventDispatcher extends AbstractAsyncEventDispatcher
     {
@@ -28,7 +28,7 @@ protected function parentDispatch($event, $eventName)
     }
 } elseif (class_exists(Event::class)) {
     /**
-     * Symfony >= 4.3 and < 5.0
+     * Symfony >= 4.3 and < 5.0.
      */
     class AsyncEventDispatcher extends AbstractAsyncEventDispatcher
     {
@@ -49,7 +49,7 @@ protected function parentDispatch($event, $eventName)
     }
 } else {
     /**
-     * Symfony >= 5.0
+     * Symfony >= 5.0.
      */
     class AsyncEventDispatcher extends AbstractAsyncEventDispatcher
     {

AsyncListener.php

@@ -8,7 +8,7 @@
 
 if (class_exists(Event::class) && !class_exists(LegacyEventDispatcherProxy::class)) {
     /**
-     * Symfony < 4.3
+     * Symfony < 4.3.
      */
     class AsyncListener extends AbstractAsyncListener
     {
@@ -18,7 +18,6 @@ public function __invoke(Event $event, $eventName)
         }
 
         /**
-         * @param Event  $event
          * @param string $eventName
          */
         public function onEvent(Event $event, $eventName)
@@ -36,7 +35,7 @@ public function onEvent(Event $event, $eventName)
     }
 } elseif (class_exists(Event::class)) {
     /**
-     * Symfony >= 4.3 and < 5.0
+     * Symfony >= 4.3 and < 5.0.
      */
     class AsyncListener extends AbstractAsyncListener
     {
@@ -68,7 +67,7 @@ public function onEvent($event, $eventName)
     }
 } else {
     /**
-     * Symfony >= 5.0
+     * Symfony >= 5.0.
      */
     class AsyncListener extends AbstractAsyncListener
     {
@@ -78,7 +77,6 @@ public function __invoke(ContractEvent $event, $eventName)
         }
 
         /**
-         * @param Event  $event
          * @param string $eventName
          */
         public function onEvent(ContractEvent $event, $eventName)

EventTransformer.php

@@ -9,34 +9,33 @@
 
 if (class_exists(Event::class) && !class_exists(LegacyEventDispatcherProxy::class)) {
     /**
-     * Symfony < 4.3
+     * Symfony < 4.3.
      */
     interface EventTransformer
     {
         /**
-         * @param string     $eventName
-         * @param Event|null $event
+         * @param string $eventName
          *
          * @return Message
          */
         public function toMessage($eventName, Event $event = null);
 
         /**
          * If you able to transform message back to event return it.
-         * If you failed to transform for some reason you can return a string status (@param string $eventName
+         * If you failed to transform for some reason you can return a string status.
          *
-         * @param Message $message
+         * @param mixed $eventName
          *
          * @return Event|string|object
+         *
          * @see Process constants) or an object that implements __toString method.
          *      The object must have a __toString method is supposed to be used as Processor::process return value.
-         *
          */
         public function toEvent($eventName, Message $message);
     }
 } elseif (class_exists(Event::class)) {
     /**
-     * Symfony >= 4.3 and < 5.0
+     * Symfony >= 4.3 and < 5.0.
      */
     interface EventTransformer
     {
@@ -50,41 +49,41 @@ public function toMessage($eventName, $event = null);
 
         /**
          * If you able to transform message back to event return it.
-         * If you failed to transform for some reason you can return a string status (@param string $eventName
+         * If you failed to transform for some reason you can return a string status.
          *
-         * @param Message $message
+         * @param mixed $eventName
          *
          * @return ContractEvent|Event|string|object
+         *
          * @see Process constants) or an object that implements __toString method.
          *      The object must have a __toString method is supposed to be used as Processor::process return value.
-         *
          */
         public function toEvent($eventName, Message $message);
     }
 } else {
     /**
-     * Symfony >= 5.0
+     * Symfony >= 5.0.
      */
     interface EventTransformer
     {
         /**
-         * @param string             $eventName
-         * @param ContractEvent|null $event
+         * @param string $eventName
          *
          * @return Message
          */
         public function toMessage($eventName, ContractEvent $event = null);
 
         /**
          * If you able to transform message back to event return it.
-         * If you failed to transform for some reason you can return a string status (@param string $eventName
+         * If you failed to transform for some reason you can return a string status.
          *
-         * @param Message $message
+         * @param mixed $eventNAme
+         * @param mixed $eventName
          *
          * @return ContractEvent|string|object
+         *
          * @see Process constants) or an object that implements __toString method.
          *      The object must have a __toString method is supposed to be used as Processor::process return value.
-         *
          */
         public function toEvent($eventName, Message $message);
     }

PhpSerializerEventTransformer.php

@@ -8,41 +8,32 @@
 
 if (class_exists(Event::class) && !class_exists(LegacyEventDispatcherProxy::class)) {
     /**
-     * Symfony < 4.3
+     * Symfony < 4.3.
      */
     class PhpSerializerEventTransformer extends AbstractPhpSerializerEventTransformer implements EventTransformer
     {
-        /**
-         * {@inheritdoc}
-         */
         public function toMessage($eventName, Event $event = null)
         {
             return $this->context->createMessage(serialize($event));
         }
     }
 } elseif (class_exists(Event::class)) {
     /**
-     * Symfony >= 4.3 and < 5.0
+     * Symfony >= 4.3 and < 5.0.
      */
     class PhpSerializerEventTransformer extends AbstractPhpSerializerEventTransformer implements EventTransformer
     {
-        /**
-         * {@inheritdoc}
-         */
         public function toMessage($eventName, $event = null)
         {
             return $this->context->createMessage(serialize($event));
         }
     }
 } else {
     /**
-     * Symfony >= 5.0
+     * Symfony >= 5.0.
      */
     class PhpSerializerEventTransformer extends AbstractPhpSerializerEventTransformer implements EventTransformer
     {
-        /**
-         * {@inheritdoc}
-         */
         public function toMessage($eventName, ContractEvent $event = null)
         {
             return $this->context->createMessage(serialize($event));

Tests/Functional/UseCasesTest.php

@@ -104,7 +104,7 @@ public function testShouldDispatchBothAsyncEventAndSyncOne()
             echo "Async event\n";
         });
 
-        $this->dispatch($this->dispatcher, new GenericEvent(),'test_async');
+        $this->dispatch($this->dispatcher, new GenericEvent(), 'test_async');
         $this->processMessages();
 
         $this->expectOutputString("Sync event\nSend message for event: test_async\nAsync event\n");
@@ -115,7 +115,7 @@ public function testShouldDispatchBothAsyncEventAndSyncOneFromWhenDispatchedFrom
         $this->dispatcher->addListener('foo', function ($event, $name, EventDispatcherInterface $dispatcher) {
             echo "Foo event\n";
 
-            $this->dispatch($dispatcher, new GenericEvent(),'test_async');
+            $this->dispatch($dispatcher, new GenericEvent(), 'test_async');
         });
 
         $this->dispatcher->addListener('test_async', function () {
@@ -128,7 +128,7 @@ public function testShouldDispatchBothAsyncEventAndSyncOneFromWhenDispatchedFrom
             echo "Async event\n";
         });
 
-        $this->dispatch($this->dispatcher, new GenericEvent(),'foo');
+        $this->dispatch($this->dispatcher, new GenericEvent(), 'foo');
 
         $this->processMessages();
 
@@ -143,14 +143,14 @@ public function testShouldDispatchOtherAsyncEventFromAsyncEvent()
         $this->asyncDispatcher->addListener('test_async', function ($event, $eventName, EventDispatcherInterface $dispatcher) {
             echo "Async event\n";
 
-            $this->dispatch($dispatcher, new GenericEvent(),'test_async_from_async');
+            $this->dispatch($dispatcher, new GenericEvent(), 'test_async_from_async');
         });
 
         $this->dispatcher->addListener('test_async_from_async', function ($event, $eventName, EventDispatcherInterface $dispatcher) {
             echo "Async event from event\n";
         });
 
-        $this->dispatch($this->dispatcher, new GenericEvent(),'test_async');
+        $this->dispatch($this->dispatcher, new GenericEvent(), 'test_async');
 
         $this->processMessages();
         $this->processMessages();
@@ -169,10 +169,10 @@ public function testShouldDispatchSyncListenerIfDispatchedFromAsycListner()
         $this->asyncDispatcher->addListener('test_async', function ($event, $eventName, EventDispatcherInterface $dispatcher) {
             echo "Async event\n";
 
-            $this->dispatch($dispatcher, new GenericEvent(),'sync');
+            $this->dispatch($dispatcher, new GenericEvent(), 'sync');
         });
 
-        $this->dispatch($this->dispatcher, new GenericEvent(),'test_async');
+        $this->dispatch($this->dispatcher, new GenericEvent(), 'test_async');
 
         $this->processMessages();
 

Tests/ProxyEventDispatcherTest.php

@@ -10,7 +10,6 @@
 use Symfony\Component\EventDispatcher\Event;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\EventDispatcher\GenericEvent;
-use Symfony\Component\HttpKernel\Kernel;
 
 class ProxyEventDispatcherTest extends TestCase
 {