Fixing things found by phpstan and phpcs

Author: Florian Krämer

composer.json

@@ -61,7 +61,7 @@
             "\\InstituteWeb\\ComposerScripts\\ImprovedScriptExecution::apply",
             "./bin/phpcbf ./src ./tests --standard=./phpcs.xml"
         ],
-        "stan": [
+        "analyze": [
             "\\InstituteWeb\\ComposerScripts\\ImprovedScriptExecution::apply",
             "./bin/phpstan analyse ./src -l 5"
         ],

src/ImageProcessor.php

@@ -63,6 +63,11 @@ class ImageProcessor implements ProcessorInterface
      */
     protected PathBuilderInterface $pathBuilder;
 
+    /**
+     * @var \Phauthentic\Infrastructure\Storage\UrlBuilder\UrlBuilderInterface
+     */
+    protected UrlBuilderInterface $urlBuilder;
+
     /**
      * @var \Intervention\Image\ImageManager
      */
@@ -258,7 +263,7 @@ public function process(FileInterface $file): FileInterface
             $data['path'] = $path;
             $file = $file->withVariant($variant, $data);
 
-            if ($this->urlBuilder) {
+            if ($this->urlBuilder !== null) {
                 $data['url'] = $this->urlBuilder->urlForVariant($file, $variant);
             }
 

tests/bootstrap.php

@@ -1,4 +1,4 @@
 <?php
-$ds = DIRECTORY_SEPARATOR;
 
+$ds = DIRECTORY_SEPARATOR;
 include __DIR__ . $ds . '..' . $ds . 'vendor' . $ds . 'autoload.php';