ci: decomission of CodeNarc

The following issue won't be fixed:
Closes #508
Closes #539
Closes #994
Closes #1187

Part of #1669

Author: php-coder

.github/workflows/static-analysis.yml

@@ -146,38 +146,6 @@ jobs:
       - name: Run maven-enforcer-plugin
         run: ./src/main/scripts/execute-command.sh enforcer
 
-  run-codenarc:
-    name: Run CodeNarc
-    # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
-    runs-on: ubuntu-20.04
-    steps:
-      - name: Clone source code
-        uses: actions/checkout@v4.1.1 # https://github.com/actions/checkout
-        with:
-          # Whether to configure the token or SSH key with the local git config. Default: true
-          persist-credentials: false
-      - name: Install JDK
-        uses: actions/setup-java@v4.0.0 # https://github.com/actions/setup-java
-        with:
-          distribution: 'adopt' # https://github.com/actions/setup-java#supported-distributions
-          java-version: '8'     # https://github.com/actions/setup-java#supported-version-syntax
-      - name: Restore existing cache
-        uses: actions/cache@v4.0.0 # https://github.com/actions/cache
-        with:
-          # https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#input-parameters-for-the-cache-action
-          key: maven-repository-${{ hashFiles('pom.xml') }}
-          path: ~/.m2/repository
-          restore-keys: maven-repository-
-      - name: Compile sources
-        run: >-
-          mvn \
-            --batch-mode \
-            -Denforcer.skip=true \
-            -DskipMinify \
-            compile
-      - name: Run CodeNarc
-        run: ./src/main/scripts/execute-command.sh codenarc
-
   run-spotbugs:
     name: Run SpotBugs
     # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on

pom.xml

@@ -571,8 +571,6 @@
 		<cglib.version>2.2.2</cglib.version>
 		<checkstyle.plugin.version>2.17</checkstyle.plugin.version>
 		<clean.plugin.version>3.0.0</clean.plugin.version>
-		<codenarc.plugin.version>0.22-1</codenarc.plugin.version>
-		<codenarc.version>0.27.0</codenarc.version>
 
 		<!-- Redefine default value from spring-boot-dependencies -->
 		<commons-lang3.version>3.14.0</commons-lang3.version>
@@ -1026,28 +1024,6 @@
 				</executions>
 			</plugin>
 
-			<!--
-				Usage:
-				./mvnw codenarc:codenarc (checks the sources and generates report in target/site/codenarc.html)
-			-->
-			<plugin>
-				<groupId>org.codehaus.mojo</groupId>
-				<artifactId>codenarc-maven-plugin</artifactId>
-				<version>${codenarc.plugin.version}</version>
-				<configuration>
-					<codeNarcVersion>${codenarc.version}</codeNarcVersion>
-					<groovyVersion>${groovy-old.version}</groovyVersion>
-					<sourceDirectory>src/test/groovy</sourceDirectory>
-					<!--
-						rulesets/enhanced.xml was excluded because of a lot of errors about failed
-						compilation: https://github.com/CodeNarc/CodeNarc/issues/123
-					-->
-					<rulesetfiles>
-						rulesets/basic.xml,rulesets/braces.xml,rulesets/concurrency.xml,rulesets/convention.xml,rulesets/design.xml,rulesets/dry.xml,rulesets/exceptions.xml,rulesets/formatting.xml,rulesets/generic.xml,rulesets/groovyism.xml,rulesets/imports.xml,rulesets/jdbc.xml,rulesets/logging.xml,rulesets/naming.xml,rulesets/security.xml,rulesets/serialization.xml,rulesets/unnecessary.xml,rulesets/unused.xml
-					</rulesetfiles>
-				</configuration>
-			</plugin>
-			
 			<plugin>
 				<groupId>org.jacoco</groupId>
 				<artifactId>jacoco-maven-plugin</artifactId>

src/main/scripts/execute-command.sh

@@ -33,14 +33,6 @@ case ${1:-} in
 			checkstyle:check \
 			-Dcheckstyle.violationSeverity=warning
 		;;
-	'codenarc')
-		exec "$MVN" \
-			--batch-mode \
-			codenarc:codenarc \
-			-Dcodenarc.maxPriority1Violations=0 \
-			-Dcodenarc.maxPriority2Violations=0 \
-			-Dcodenarc.maxPriority3Violations=0
-		;;
 	'enforcer')
 		exec "$MVN" \
 			--batch-mode \
@@ -99,7 +91,6 @@ case ${1:-} in
 		echo >&2 '- ansible-lint'
 		echo >&2 '- check-license'
 		echo >&2 '- checkstyle'
-		echo >&2 '- codenarc'
 		echo >&2 '- enforcer'
 		echo >&2 '- integration-tests'
 		echo >&2 '- jest'

src/test/groovy/ru/mystamps/web/common/LocaleUtilsTest.groovy

@@ -20,15 +20,13 @@ package ru.mystamps.web.common
 import spock.lang.Specification
 import spock.lang.Unroll
 
-@SuppressWarnings(['ClassJavadoc', 'MethodName', 'NoDef', 'NoTabCharacter', 'TrailingWhitespace'])
 class LocaleUtilsTest extends Specification {
 
 	//
 	// Tests for getLanguageOrNull()
 	//
 
 	@Unroll
-	@SuppressWarnings('UnnecessaryBooleanExpression') // false positive
 	def "getLanguageOrNull() should extract language '#language' from locale '#locale'"(Locale locale, String language) {
 		when:
 			String result = LocaleUtils.getLanguageOrNull(locale)
@@ -46,7 +44,6 @@ class LocaleUtilsTest extends Specification {
 	//
 
 	@Unroll
-	@SuppressWarnings(['LineLength', /* false positive: */ 'UnnecessaryBooleanExpression'])
 	def "getLanguageOrDefault() should return '#expected' for #locale/#value"(Locale locale, String value, String expected) {
 		when:
 			String result = LocaleUtils.getLanguageOrDefault(locale, value)

src/test/groovy/ru/mystamps/web/common/PagerTest.groovy

@@ -20,7 +20,6 @@ package ru.mystamps.web.common
 import spock.lang.Specification
 import spock.lang.Unroll
 
-@SuppressWarnings(['ClassJavadoc', 'MethodName', 'NoDef', 'NoTabCharacter', 'TrailingWhitespace'])
 class PagerTest extends Specification {
 
 	//
@@ -195,7 +194,6 @@ class PagerTest extends Specification {
 	//
 
 	@Unroll
-	@SuppressWarnings('UnnecessaryBooleanExpression') // false positive
 	def "getPrev() should return #prev for when page = #currentPage"(int currentPage, Integer prev) {
 		when:
 			Pager pager = new Pager(3, 1, currentPage)
@@ -213,7 +211,6 @@ class PagerTest extends Specification {
 	//
 
 	@Unroll
-	@SuppressWarnings('UnnecessaryBooleanExpression') // false positive
 	def "getNext() should return #next for when page = #currentPage"(int currentPage, Integer next) {
 		when:
 			Pager pager = new Pager(3, 1, currentPage)

src/test/groovy/ru/mystamps/web/common/SlugUtilsTest.groovy

@@ -20,7 +20,6 @@ package ru.mystamps.web.common
 import spock.lang.Specification
 import spock.lang.Unroll
 
-@SuppressWarnings(['ClassJavadoc', 'MethodName', 'NoDef', 'NoTabCharacter', 'TrailingWhitespace'])
 class SlugUtilsTest extends Specification {
 
 	//
@@ -36,7 +35,6 @@ class SlugUtilsTest extends Specification {
 	}
 
 	@Unroll
-	@SuppressWarnings('UnnecessaryBooleanExpression') // false positive
 	def "slugify() should transform text '#input' to '#output'"(String input, String output) {
 		when:
 			String result = SlugUtils.slugify(input)

src/test/groovy/ru/mystamps/web/feature/account/UserServiceImplTest.groovy

@@ -25,7 +25,6 @@ import ru.mystamps.web.tests.DateUtils
 import ru.mystamps.web.tests.Random
 import spock.lang.Specification
 
-@SuppressWarnings(['ClassJavadoc', 'MethodName', 'NoDef', 'NoTabCharacter', 'TrailingWhitespace'])
 class UserServiceImplTest extends Specification {
 
 	private final UserDao userDao = Mock()
@@ -78,7 +77,6 @@ class UserServiceImplTest extends Specification {
 			1 * userDao.add(_ as AddUserDbDto) >> Random.userId()
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "registerUser() should delete registration request"() {
 		given:
 			String expectedActivationKey = activationForm.activationKey
@@ -114,7 +112,6 @@ class UserServiceImplTest extends Specification {
 			0 * usersActivationService.remove(_ as String)
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "registerUser() should pass name to dao"() {
 		given:
 			String expectedUserName = activationForm.name
@@ -127,7 +124,6 @@ class UserServiceImplTest extends Specification {
 			}) >> Random.userId()
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "registerUser() should pass login instead of name when name is null"() {
 		given:
 			String expectedUserLogin = activationForm.login
@@ -141,7 +137,6 @@ class UserServiceImplTest extends Specification {
 			}) >> Random.userId()
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "registerUser() should pass login instead of name when name is empty"() {
 		given:
 			String expectedUserLogin = activationForm.login
@@ -156,7 +151,6 @@ class UserServiceImplTest extends Specification {
 			}) >> Random.userId()
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "registerUser() should fill role field"() {
 		when:
 			service.registerUser(activationForm)
@@ -167,7 +161,6 @@ class UserServiceImplTest extends Specification {
 			}) >> Random.userId()
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "registerUser() should use email from registration request"() {
 		given:
 			UsersActivationDto activation = new UsersActivationDto('test@example.org', new Date())
@@ -182,7 +175,6 @@ class UserServiceImplTest extends Specification {
 			}) >> Random.userId()
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "registerUser() should use registration date from registration request"() {
 		given:
 			UsersActivationDto activation = new UsersActivationDto(TestObjects.TEST_EMAIL, new Date(86, 8, 12))
@@ -207,7 +199,6 @@ class UserServiceImplTest extends Specification {
 			ex.message == 'Password must be non null'
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "registerUser() should gets hash from encoder"() {
 		given:
 			String expectedHash = TestObjects.createAddUserDbDto().hash
@@ -245,7 +236,6 @@ class UserServiceImplTest extends Specification {
 			ex.message == 'Login must be non null'
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "registerUser() should pass login to dao"() {
 		given:
 			String expectedUserLogin = activationForm.login
@@ -258,7 +248,6 @@ class UserServiceImplTest extends Specification {
 			}) >> Random.userId()
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "registerUser() should assign activated at to current date"() {
 		when:
 			service.registerUser(activationForm)
@@ -269,7 +258,6 @@ class UserServiceImplTest extends Specification {
 			}) >> Random.userId()
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "registerUser() should create collection for user"() {
 		given:
 			Integer expectedId = 909
@@ -357,7 +345,6 @@ class UserServiceImplTest extends Specification {
 			ex.message == 'Date must be non null'
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "countRegisteredSince() should invoke dao, pass argument and return result from dao"() {
 		given:
 			Date expectedDate = new Date()

src/test/groovy/ru/mystamps/web/feature/account/UsersActivationServiceImplTest.groovy

@@ -24,7 +24,6 @@ import ru.mystamps.web.tests.DateUtils
 import spock.lang.Specification
 import spock.lang.Unroll
 
-@SuppressWarnings(['ClassJavadoc', 'MethodName', 'NoDef', 'NoTabCharacter', 'TrailingWhitespace'])
 class UsersActivationServiceImplTest extends Specification {
 
 	private final UsersActivationDao usersActivationDao = Mock()
@@ -61,7 +60,6 @@ class UsersActivationServiceImplTest extends Specification {
 			1 * usersActivationDao.add(_ as AddUsersActivationDbDto)
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "add() should generate activation key"() {
 		when:
 			service.add(registrationForm, ANY_LOCALE)
@@ -73,7 +71,6 @@ class UsersActivationServiceImplTest extends Specification {
 			})
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "add() should generate unique activation key"() {
 		given:
 			List<String> passedArguments = []
@@ -107,7 +104,6 @@ class UsersActivationServiceImplTest extends Specification {
 			ex.message == 'Email must be non null'
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "add() should pass email to dao"() {
 		given:
 			String expectedEmail = 'somename@example.org'
@@ -122,11 +118,6 @@ class UsersActivationServiceImplTest extends Specification {
 	}
 
 	@Unroll
-	@SuppressWarnings([
-		'ClosureAsLastMethodParameter',
-		'UnnecessaryReturnKeyword',
-		/* false positive: */ 'UnnecessaryBooleanExpression',
-	])
 	def "add() should pass language '#expectedLang' to dao"(Locale lang, String expectedLang) {
 		when:
 			service.add(registrationForm, lang)
@@ -141,7 +132,6 @@ class UsersActivationServiceImplTest extends Specification {
 			Locale.FRENCH || 'fr'
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "add() should assign created at to current date"() {
 		when:
 			service.add(registrationForm, ANY_LOCALE)
@@ -152,7 +142,6 @@ class UsersActivationServiceImplTest extends Specification {
 			})
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "add() should pass user's activation request to mail service"() {
 		when:
 			service.add(registrationForm, Locale.FRANCE)
@@ -206,7 +195,6 @@ class UsersActivationServiceImplTest extends Specification {
 			ex.message == 'Date must be non null'
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "countCreatedSince() should invoke dao, pass argument and return result from dao"() {
 		given:
 			Date expectedDate = new Date()
@@ -258,7 +246,6 @@ class UsersActivationServiceImplTest extends Specification {
 			ex.message == 'Days must be greater than zero'
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def "findOlderThan() should invoke dao, pass changed date and return the result"() {
 		given:
 			int days = 4

src/test/groovy/ru/mystamps/web/feature/category/CategoryServiceImplTest.groovy

@@ -33,14 +33,6 @@ import static io.qala.datagen.RandomShortApi.positiveInteger
 import static io.qala.datagen.RandomValue.between
 import static io.qala.datagen.StringModifier.Impls.oneOf
 
-@SuppressWarnings([
-	'ClassJavadoc',
-	'MethodName',
-	'MisorderedStaticImports',
-	'NoDef',
-	'NoTabCharacter',
-	'TrailingWhitespace',
-])
 class CategoryServiceImplTest extends Specification {
 
 	private final CategoryDao categoryDao = Mock()
@@ -109,7 +101,6 @@ class CategoryServiceImplTest extends Specification {
 			ex.message == "Slug for string '-' must be non empty"
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def 'add() should pass slug to dao'() {
 		given:
 			String name = '-foo123 test_'
@@ -126,7 +117,6 @@ class CategoryServiceImplTest extends Specification {
 			}) >> 40
 	}
 
-	@SuppressWarnings(['ClosureAsLastMethodParameter', 'UnnecessaryReturnKeyword'])
 	def 'add() should pass values to dao'() {
 		given:
 			Integer expectedUserId = 10