ci: decomission of PMD

The following issue won't be fixed:
Closes #195
Closes #261
Closes #1018
Closes #1250
Closes #1646

Part of #1669

Author: php-coder

.github/workflows/static-analysis.yml

@@ -16,31 +16,6 @@ defaults:
 
 jobs:
 
-  run-pmd:
-    name: Run PMD
-    # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
-    runs-on: ubuntu-20.04
-    steps:
-      - name: Clone source code
-        uses: actions/checkout@v4.1.1 # https://github.com/actions/checkout
-        with:
-          # Whether to configure the token or SSH key with the local git config. Default: true
-          persist-credentials: false
-      - name: Install JDK
-        uses: actions/setup-java@v4.0.0 # https://github.com/actions/setup-java
-        with:
-          distribution: 'adopt' # https://github.com/actions/setup-java#supported-distributions
-          java-version: '8'     # https://github.com/actions/setup-java#supported-version-syntax
-      - name: Restore existing cache
-        uses: actions/cache@v4.0.0 # https://github.com/actions/cache
-        with:
-          # https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#input-parameters-for-the-cache-action
-          key: maven-repository-${{ hashFiles('pom.xml') }}
-          path: ~/.m2/repository
-          restore-keys: maven-repository-
-      - name: Run PMD
-        run: ./src/main/scripts/execute-command.sh pmd
-
   check-license:
     name: Check license in file headers
     # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on

pom.xml

@@ -644,7 +644,6 @@
 
 		<native2ascii.plugin.version>2.0.1</native2ascii.plugin.version>
 		<nodejs.version>v10.16.0</nodejs.version>
-		<pmd.plugin.version>3.12.0</pmd.plugin.version>
 
 		<!-- Redefine default value from spring-boot-dependencies -->
 		<postgresql.version>9.4.1212.jre7</postgresql.version>
@@ -912,20 +911,6 @@
 				</configuration>
 			</plugin>
 
-			<plugin>
-				<groupId>org.apache.maven.plugins</groupId>
-				<artifactId>maven-pmd-plugin</artifactId>
-				<version>${pmd.plugin.version}</version>
-				<configuration>
-					<linkXRef>false</linkXRef>
-					<verbose>true</verbose>
-					<targetJdk>${java.version}</targetJdk>
-					<rulesets>
-						<ruleset>${basedir}/src/main/config/pmd.xml</ruleset>
-					</rulesets>
-				</configuration>
-			</plugin>
-			
 			<plugin>
 				<groupId>org.apache.maven.plugins</groupId>
 				<artifactId>maven-resources-plugin</artifactId>

src/main/config/pmd.xml

@@ -28,7 +28,6 @@ private JdbcUtils() {
 	}
 
 	// @see https://stackoverflow.com/q/2920364/checking-for-a-null-int-value-from-a-java-resultset
-	@SuppressWarnings("PMD.PrematureDeclaration")
 	public static Integer getInteger(ResultSet resultSet, String fieldName) throws SQLException {
 		int value = resultSet.getInt(fieldName);
 		if (resultSet.wasNull()) {
@@ -38,7 +37,6 @@ public static Integer getInteger(ResultSet resultSet, String fieldName) throws S
 		return Integer.valueOf(value);
 	}
 
-	@SuppressWarnings("PMD.PrematureDeclaration")
 	public static Boolean getBoolean(ResultSet resultSet, String fieldName) throws SQLException {
 		boolean value = resultSet.getBoolean(fieldName);
 		if (resultSet.wasNull()) {
@@ -51,7 +49,6 @@ public static Boolean getBoolean(ResultSet resultSet, String fieldName) throws S
 	/**
 	 * @author Sergey Chechenev
 	 */
-	@SuppressWarnings("PMD.PrematureDeclaration")
 	public static Currency getCurrency(ResultSet resultSet, String fieldName) throws SQLException {
 		String value = resultSet.getString(fieldName);
 		if (resultSet.wasNull()) {

src/main/java/ru/mystamps/web/common/JdbcUtils.java

@@ -25,8 +25,6 @@
 import java.util.Collections;
 import java.util.List;
 
-// yes, I know that it's too complex :-(
-@SuppressWarnings("PMD.ModifiedCyclomaticComplexity")
 @ToString
 public class Pager {
 	// be very careful when you're changing this value
@@ -41,15 +39,12 @@ public class Pager {
 	private static final int FIRST_PAGE = 1;
 
 	// this field is shown in toString() and useful when debugging unit tests
-	@SuppressWarnings("PMD.SingularField")
 	private final int totalRecords;
 
 	// this field is shown in toString() and useful when debugging unit tests
-	@SuppressWarnings("PMD.SingularField")
 	private final int totalPages;
 
 	// this field is shown in toString() and useful when debugging unit tests
-	@SuppressWarnings({ "PMD.SingularField", "PMD.UnusedPrivateField" })
 	private final int recordsPerPage;
 
 	// this field is using in the view (hence its getter)
@@ -106,8 +101,6 @@ private static Integer findNext(int currentPage, int totalPages) {
 		return Integer.valueOf(currentPage + 1);
 	}
 
-	// I hope that we'll fix these one day
-	@SuppressWarnings("PMD.NPathComplexity")
 	private static List<Integer> createItems(
 		int totalRecords,
 		int recordsPerPage,

src/main/java/ru/mystamps/web/common/Pager.java

@@ -17,7 +17,6 @@
  */
 package ru.mystamps.web.feature.account;
 
-@SuppressWarnings("PMD.CommentDefaultAccessModifier")
 final class AccountDb {
 
 	static final class UsersActivation {

src/main/java/ru/mystamps/web/feature/account/AccountDb.java

@@ -26,7 +26,6 @@
  *
  * @author Slava Semushin
  */
-@SuppressWarnings("PMD.CommentDefaultAccessModifier")
 public final class AccountUrl {
 
 	public static final String REGISTRATION_PAGE     = "/account/register";

src/main/java/ru/mystamps/web/feature/account/AccountUrl.java

@@ -20,13 +20,11 @@
 import ru.mystamps.web.feature.account.AccountDb.User;
 import ru.mystamps.web.feature.account.AccountDb.UsersActivation;
 
-@SuppressWarnings("PMD.CommentDefaultAccessModifier")
 public final class AccountValidation {
 
 	public static final int LOGIN_MIN_LENGTH = 2;
 	public static final int LOGIN_MAX_LENGTH = User.LOGIN_LENGTH;
 	static final String LOGIN_REGEXP = "[-_\\.a-zA-Z0-9]+";
-	@SuppressWarnings("PMD.LongVariable")
 	static final String LOGIN_NO_REPEATING_CHARS_REGEXP = "(?!.+[-_.]{2,}).+";
 
 	static final int NAME_MAX_LENGTH = User.NAME_LENGTH;

src/main/java/ru/mystamps/web/feature/account/AccountValidation.java

@@ -27,7 +27,6 @@
 import java.util.List;
 import java.util.Map;
 
-@SuppressWarnings("PMD.AvoidDuplicateLiterals")
 public class JdbcUsersActivationDao implements UsersActivationDao {
 
 	private final NamedParameterJdbcTemplate jdbcTemplate;

src/main/java/ru/mystamps/web/feature/account/JdbcUsersActivationDao.java

@@ -34,7 +34,6 @@
 /**
  * Implementation that delegates calls to a category service.
  */
-@SuppressWarnings("PMD.TooManyMethods")
 public class ApiCategoryService implements CategoryService {
 
 	private static final Logger LOG = LoggerFactory.getLogger(ApiCategoryService.class);