refactor: fix compiler warnings and enable failOnWarning again.

- use annotations from javax.validation.constraints instead of org.hibernate.validator.constraints package
- replace WebMvcConfigurerAdapter by WebMvcConfigurer

Fix #1197

Author: php-coder

pom.xml

@@ -789,8 +789,7 @@
 					<showDeprecation>true</showDeprecation>
 					<showWarnings>true</showWarnings>
 					<debug>false</debug>
-					<!-- @todo #869 Fix compilation warnings and enable failOnWarning again -->
-					<!--<failOnWarning>true</failOnWarning>-->
+					<failOnWarning>true</failOnWarning>
 					<!-- Required for ErrorProne -->
 					<!-- @todo #971 Document ErrorProne tool -->
 					<compilerArgs>

src/main/java/ru/mystamps/web/config/MvcConfig.java

@@ -35,7 +35,7 @@
 import org.springframework.web.servlet.config.annotation.PathMatchConfigurer;
 import org.springframework.web.servlet.config.annotation.ResourceHandlerRegistry;
 import org.springframework.web.servlet.config.annotation.ViewControllerRegistry;
-import org.springframework.web.servlet.config.annotation.WebMvcConfigurerAdapter;
+import org.springframework.web.servlet.config.annotation.WebMvcConfigurer;
 import org.springframework.web.servlet.i18n.LocaleChangeInterceptor;
 import org.springframework.web.servlet.i18n.SessionLocaleResolver;
 import org.springframework.web.servlet.resource.VersionResourceResolver;
@@ -85,7 +85,7 @@
 	EventsConfig.class,
 })
 @RequiredArgsConstructor
-public class MvcConfig extends WebMvcConfigurerAdapter {
+public class MvcConfig implements WebMvcConfigurer {
 
 	private final ServicesConfig servicesConfig;
 	private final CategoryService categoryService;

src/main/java/ru/mystamps/web/feature/account/ActivateAccountForm.java

@@ -19,11 +19,11 @@
 
 import lombok.Getter;
 import lombok.Setter;
-import org.hibernate.validator.constraints.NotEmpty;
 import ru.mystamps.web.support.beanvalidation.FieldsMatch;
 import ru.mystamps.web.support.beanvalidation.FieldsMismatch;
 
 import javax.validation.GroupSequence;
+import javax.validation.constraints.NotEmpty;
 import javax.validation.constraints.Pattern;
 import javax.validation.constraints.Size;
 

src/main/java/ru/mystamps/web/feature/account/RegisterAccountForm.java

@@ -19,11 +19,11 @@
 
 import lombok.Getter;
 import lombok.Setter;
-import org.hibernate.validator.constraints.NotEmpty;
 import ru.mystamps.web.support.beanvalidation.Email;
 import ru.mystamps.web.support.beanvalidation.Group;
 
 import javax.validation.GroupSequence;
+import javax.validation.constraints.NotEmpty;
 import javax.validation.constraints.Size;
 
 import static ru.mystamps.web.feature.account.AccountValidation.EMAIL_MAX_LENGTH;

src/main/java/ru/mystamps/web/feature/category/AddCategoryForm.java

@@ -19,12 +19,12 @@
 
 import lombok.Getter;
 import lombok.Setter;
-import org.hibernate.validator.constraints.NotEmpty;
 import ru.mystamps.web.feature.category.UniqueCategoryName.Lang;
 import ru.mystamps.web.support.beanvalidation.DenyValues;
 import ru.mystamps.web.support.beanvalidation.Group;
 
 import javax.validation.GroupSequence;
+import javax.validation.constraints.NotEmpty;
 import javax.validation.constraints.Pattern;
 import javax.validation.constraints.Size;
 

src/main/java/ru/mystamps/web/feature/country/AddCountryForm.java

@@ -19,12 +19,12 @@
 
 import lombok.Getter;
 import lombok.Setter;
-import org.hibernate.validator.constraints.NotEmpty;
 import ru.mystamps.web.feature.country.UniqueCountryName.Lang;
 import ru.mystamps.web.support.beanvalidation.DenyValues;
 import ru.mystamps.web.support.beanvalidation.Group;
 
 import javax.validation.GroupSequence;
+import javax.validation.constraints.NotEmpty;
 import javax.validation.constraints.Pattern;
 import javax.validation.constraints.Size;
 

src/main/java/ru/mystamps/web/feature/participant/AddParticipantForm.java

@@ -19,9 +19,9 @@
 
 import lombok.Getter;
 import lombok.Setter;
-import org.hibernate.validator.constraints.NotEmpty;
 import org.hibernate.validator.constraints.URL;
 
+import javax.validation.constraints.NotEmpty;
 import javax.validation.constraints.NotNull;
 import javax.validation.constraints.Size;
 

src/main/java/ru/mystamps/web/feature/series/importing/RequestSeriesImportForm.java

@@ -19,11 +19,11 @@
 
 import lombok.Getter;
 import lombok.Setter;
-import org.hibernate.validator.constraints.NotEmpty;
 import org.hibernate.validator.constraints.URL;
 import ru.mystamps.web.support.beanvalidation.Group;
 
 import javax.validation.GroupSequence;
+import javax.validation.constraints.NotEmpty;
 import javax.validation.constraints.Size;
 
 @Getter

src/main/java/ru/mystamps/web/feature/series/importing/sale/RequestSeriesSaleImportForm.java

@@ -19,14 +19,14 @@
 
 import lombok.Getter;
 import lombok.Setter;
-import org.hibernate.validator.constraints.NotEmpty;
 import org.hibernate.validator.constraints.URL;
 import ru.mystamps.web.feature.series.importing.HasSiteParser;
 import ru.mystamps.web.feature.series.importing.RequestImportDto;
 import ru.mystamps.web.feature.series.sale.SeriesSalesValidation;
 import ru.mystamps.web.support.beanvalidation.Group;
 
 import javax.validation.GroupSequence;
+import javax.validation.constraints.NotEmpty;
 import javax.validation.constraints.Size;
 
 @Getter

src/main/java/ru/mystamps/web/support/beanvalidation/Email.java

@@ -40,7 +40,7 @@
  * @see <a href="https://hibernate.atlassian.net/browse/HVAL-43">Issue in Hibernate's JIRA</a>
  * @author Slava Semushin
  */
-@org.hibernate.validator.constraints.Email
+@javax.validation.constraints.Email
 @Pattern(regexp = ".+@.+\\..+")
 @ReportAsSingleViolation
 @Target({ METHOD, FIELD, ANNOTATION_TYPE })