Skip to content

Commit 6632676

Browse files
committed
refactor: rename methods to avoid escaping of a single quote.
This change is needed in order to simplify automated porting of tests. Part of 1246
1 parent ad1bbf9 commit 6632676

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

src/test/groovy/ru/mystamps/web/feature/collection/LegacyCollectionServiceImplTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class LegacyCollectionServiceImplTest extends Specification {
7070
}
7171

7272
@SuppressWarnings('FactoryMethodName')
73-
def 'createCollection() should throw exception when owner login can\'t be converted to slug'() {
73+
def "createCollection() should throw exception when owner login can't be converted to slug"() {
7474
when:
7575
service.createCollection(Random.userId(), '')
7676
then:

src/test/groovy/ru/mystamps/web/feature/image/LegacyFilesystemImagePersistenceStrategyTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class LegacyFilesystemImagePersistenceStrategyTest extends Specification {
9494
// Tests for get()
9595
//
9696

97-
def 'get() should return null when file doesn\'t exist'() {
97+
def "get() should return null when file doesn't exist"() {
9898
given:
9999
strategy.exists(_ as Path) >> false
100100
and:

src/test/groovy/ru/mystamps/web/feature/series/LegacySeriesServiceImplTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -955,7 +955,7 @@ class LegacySeriesServiceImplTest extends Specification {
955955
1 * solovyovCatalogService.findSeriesIdsByNumber(expectedNumber) >> []
956956
}
957957

958-
def 'findBySolovyovNumber() shouldn\'t try to find series info if there are no series'() {
958+
def "findBySolovyovNumber() shouldn't try to find series info if there are no series"() {
959959
given:
960960
solovyovCatalogService.findSeriesIdsByNumber(_ as String) >> []
961961
when:
@@ -994,7 +994,7 @@ class LegacySeriesServiceImplTest extends Specification {
994994
1 * zagorskiCatalogService.findSeriesIdsByNumber(expectedNumber) >> []
995995
}
996996

997-
def 'findByZagorskiNumber() shouldn\'t try to find series info if there are no series'() {
997+
def "findByZagorskiNumber() shouldn't try to find series info if there are no series"() {
998998
given:
999999
zagorskiCatalogService.findSeriesIdsByNumber(_ as String) >> []
10001000
when:

src/test/groovy/ru/mystamps/web/feature/series/importing/LegacySeriesInfoExtractorServiceImplTest.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ class LegacySeriesInfoExtractorServiceImplTest extends Specification {
327327
year == expectedYear
328328
}
329329

330-
def 'extractReleaseYear() shouldn\'t extract dates before 1840'() {
330+
def "extractReleaseYear() shouldn't extract dates before 1840"() {
331331
given:
332332
Integer unsupportedYear = between(0, SeriesValidation.MIN_RELEASE_YEAR - 1).integer()
333333
String fragment = String.valueOf(unsupportedYear)
@@ -337,7 +337,7 @@ class LegacySeriesInfoExtractorServiceImplTest extends Specification {
337337
year == null
338338
}
339339

340-
def 'extractReleaseYear() shouldn\'t extract dates after 2099'() {
340+
def "extractReleaseYear() shouldn't extract dates after 2099"() {
341341
given:
342342
Integer unsupportedYear = between(MAX_SUPPORTED_RELEASE_YEAR + 1, Integer.MAX_VALUE).integer()
343343
String fragment = String.valueOf(unsupportedYear)
@@ -348,7 +348,7 @@ class LegacySeriesInfoExtractorServiceImplTest extends Specification {
348348
}
349349

350350
@Unroll
351-
def 'extractReleaseYear() shouldn\'t extract date from "#fragment"'(String fragment) {
351+
def "extractReleaseYear() shouldn't extract date from '#fragment'"(String fragment) {
352352
when:
353353
Integer year = service.extractReleaseYear(fragment)
354354
then:

0 commit comments

Comments
 (0)