Bindings Feature

  - Modified compiler pass to include bindings
  - Register Parts Pass return empty array if type is not set
  - changed dynamic binding service name

Author: fatmuemoo

DependencyInjection/Compiler/RegisterPartsPass.php

@@ -18,6 +18,7 @@ public function process(ContainerBuilder $container)
 
         $tags = array(
             'old_sound_rabbit_mq.base_amqp',
+            'old_sound_rabbit_mq.binding',
             'old_sound_rabbit_mq.producer',
             'old_sound_rabbit_mq.consumer',
             'old_sound_rabbit_mq.multi_consumer',

DependencyInjection/OldSoundRabbitMqExtension.php

@@ -118,7 +118,7 @@ protected function loadBindings()
                 // in the context of a binding, I don't thing logged channels are needed?
                 $this->injectLoggedChannel($definition, $key, $binding['connection']);
             }
-            $this->container->setDefinition(sprintf('old_sound_rabbit_mq.%s_binding', $key), $definition);
+            $this->container->setDefinition(sprintf('old_sound_rabbit_mq.binding.%s', $key), $definition);
         }
     }
 

RabbitMq/AmqpPartsHolder.php

@@ -18,6 +18,7 @@ public function addPart($type, BaseAmqp $part)
 
 	public function getParts($type)
 	{
-		return $this->parts[(string) $type];
+        $type = (string) $type;
+		return isset($this->parts[$type]) ? $this->parts[$type] : array();
 	}
 }

Tests/DependencyInjection/OldSoundRabbitMqExtensionTest.php

@@ -129,7 +129,7 @@ public function testFooBinding()
         );
         ksort($binding);
         $key = md5(json_encode($binding));
-        $name = sprintf('old_sound_rabbit_mq.%s_binding', $key);
+        $name = sprintf('old_sound_rabbit_mq.binding.%s', $key);
         $this->assertTrue($container->has($name));
         $definition = $container->getDefinition($name);
         $this->assertEquals((string) $definition->getArgument(0), 'old_sound_rabbit_mq.connection.default');
@@ -151,7 +151,7 @@ public function testMooBinding()
         );
         ksort($binding);
         $key = md5(json_encode($binding));
-        $name = sprintf('old_sound_rabbit_mq.%s_binding', $key);
+        $name = sprintf('old_sound_rabbit_mq.binding.%s', $key);
         $this->assertTrue($container->has($name));
         $definition = $container->getDefinition($name);
         $this->assertEquals((string) $definition->getArgument(0), 'old_sound_rabbit_mq.connection.default2');