fix phpstan warnings

Author: ramunasd

Command/AnonConsumerCommand.php

@@ -10,7 +10,7 @@ protected function configure()
 
         $this->setName('rabbitmq:anon-consumer');
         $this->setDescription('Executes an anonymous consumer');
-        $this->getDefinition()->getOption('messages')->setDefault(1);
+        $this->getDefinition()->getOption('messages')->setDefault('1');
         $this->getDefinition()->getOption('route')->setDefault('#');
 
     }

Command/BaseConsumerCommand.php

@@ -13,6 +13,7 @@ abstract class BaseConsumerCommand extends BaseRabbitMqCommand
 {
     protected $consumer;
 
+    /** @var int */
     protected $amount;
 
     abstract protected function getConsumerService();
@@ -41,14 +42,22 @@ protected function configure()
 
         $this
             ->addArgument('name', InputArgument::REQUIRED, 'Consumer Name')
-            ->addOption('messages', 'm', InputOption::VALUE_OPTIONAL, 'Messages to consume', 0)
+            ->addOption('messages', 'm', InputOption::VALUE_OPTIONAL, 'Messages to consume', '0')
             ->addOption('route', 'r', InputOption::VALUE_OPTIONAL, 'Routing Key', '')
             ->addOption('memory-limit', 'l', InputOption::VALUE_OPTIONAL, 'Allowed memory for this process (MB)', null)
             ->addOption('debug', 'd', InputOption::VALUE_NONE, 'Enable Debugging')
             ->addOption('without-signals', 'w', InputOption::VALUE_NONE, 'Disable catching of system signals')
         ;
     }
 
+    protected function initialize(InputInterface $input, OutputInterface $output)
+    {
+        $this->amount = (int)$input->getOption('messages');
+        if (0 > $this->amount) {
+            throw new \InvalidArgumentException("The -m option should be null or greater than 0");
+        }
+    }
+
     /**
      * Executes the current command.
      *
@@ -80,23 +89,21 @@ protected function execute(InputInterface $input, OutputInterface $output)
             define('AMQP_DEBUG', (bool) $input->getOption('debug'));
         }
 
-        $this->amount = $input->getOption('messages');
-
-        if (0 > (int) $this->amount) {
-            throw new \InvalidArgumentException("The -m option should be null or greater than 0");
-        }
         $this->initConsumer($input);
 
         return $this->consumer->consume($this->amount);
     }
 
-    protected function initConsumer($input)
+    protected function initConsumer(InputInterface $input)
     {
         $this->consumer = $this->getContainer()
                 ->get(sprintf($this->getConsumerService(), $input->getArgument('name')));
 
-        if (!is_null($input->getOption('memory-limit')) && ctype_digit((string) $input->getOption('memory-limit')) && $input->getOption('memory-limit') > 0) {
-            $this->consumer->setMemoryLimit($input->getOption('memory-limit'));
+        if ($input->hasOption('memory-limit')) {
+            $memoryLimit = (int)$input->getOption('memory-limit');
+            if ($memoryLimit > 0) {
+                $this->consumer->setMemoryLimit($memoryLimit);
+            }
         }
         $this->consumer->setRoutingKey($input->getOption('route'));
     }

Command/BaseRabbitMqCommand.php

@@ -28,4 +28,6 @@ public function getContainer()
     {
         return $this->container;
     }
+
+
 }

Command/BatchConsumerCommand.php

@@ -36,7 +36,7 @@ protected function configure()
         $this
             ->setName('rabbitmq:batch:consumer')
             ->addArgument('name', InputArgument::REQUIRED, 'Consumer Name')
-            ->addOption('batches', 'b', InputOption::VALUE_OPTIONAL, 'Number of batches to consume', 0)
+            ->addOption('batches', 'b', InputOption::VALUE_OPTIONAL, 'Number of batches to consume', '0')
             ->addOption('route', 'r', InputOption::VALUE_OPTIONAL, 'Routing Key', '')
             ->addOption('memory-limit', 'l', InputOption::VALUE_OPTIONAL, 'Allowed memory for this process', null)
             ->addOption('debug', 'd', InputOption::VALUE_NONE, 'Enable Debugging')
@@ -75,8 +75,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             define('AMQP_DEBUG', (bool) $input->getOption('debug'));
         }
 
-        $batchAmountTarget = (int) $input->getOption('batches');
-
+        $batchAmountTarget = (int)$input->getOption('batches');
         if (0 > $batchAmountTarget) {
             throw new \InvalidArgumentException("The -b option should be greater than 0");
         }

Command/RpcServerCommand.php

@@ -17,7 +17,7 @@ protected function configure()
             ->setName('rabbitmq:rpc-server')
             ->setDescription('Start an RPC server')
             ->addArgument('name', InputArgument::REQUIRED, 'Server Name')
-            ->addOption('messages', 'm', InputOption::VALUE_OPTIONAL, 'Messages to consume', 0)
+            ->addOption('messages', 'm', InputOption::VALUE_OPTIONAL, 'Messages to consume', '0')
             ->addOption('debug', 'd', InputOption::VALUE_OPTIONAL, 'Debug mode', false)
         ;
     }
@@ -35,9 +35,9 @@ protected function configure()
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         define('AMQP_DEBUG', (bool) $input->getOption('debug'));
-        $amount = $input->getOption('messages');
+        $amount = (int)$input->getOption('messages');
 
-        if (0 > (int) $amount) {
+        if (0 > $amount) {
             throw new \InvalidArgumentException("The -m option should be null or greater than 0");
         }