Ugly fix (set missing_ok = true)

Previously, the return code was not checked when deleting files. Now, in order for the tests to work out, you need to ignore the missing files.

This fix for tests:
tests.retention.RetentionTest.test_window_merge_interleaved_incremental_chains_1
tests.retention.RetentionTest.test_window_chains
tests.merge.MergeTest.test_smart_merge
tests.merge.MergeTest.test_merge_tablespaces
tests.merge.MergeTest.test_merge_pg_filenode_map
tests.merge.MergeTest.test_failed_merge_after_delete_3
tests.merge.MergeTest.test_failed_merge_after_delete
tests.merge.MergeTest.test_crash_after_opening_backup_control_2

Author: kulaginm

src/dir.c

@@ -1676,7 +1676,7 @@ cleanup_tablespace(const char *path)
 
 		join_path_components(fullpath, path, file->rel_path);
 
-		if (fio_remove(FIO_DB_HOST, fullpath, false) == 0)
+		if (fio_remove(FIO_DB_HOST, fullpath, true) == 0)
 			elog(VERBOSE, "Deleted file \"%s\"", fullpath);
 		else
 			elog(ERROR, "Cannot delete file or directory \"%s\": %s", fullpath, strerror(errno));

src/merge.c

@@ -798,7 +798,7 @@ merge_chain(InstanceState *instanceState,
 			/* We need full path, file object has relative path */
 			join_path_components(full_file_path, full_database_dir, full_file->rel_path);
 
-			if (fio_remove(FIO_BACKUP_HOST, full_file_path, false) == 0)
+			if (fio_remove(FIO_BACKUP_HOST, full_file_path, true) == 0)
 				elog(VERBOSE, "Deleted \"%s\"", full_file_path);
 			else
 				elog(ERROR, "Cannot delete file or directory \"%s\": %s", full_file_path, strerror(errno));
@@ -1134,7 +1134,7 @@ remove_dir_with_files(const char *path)
 
 		join_path_components(full_path, path, file->rel_path);
 
-		if (fio_remove(FIO_LOCAL_HOST, full_path, false) == 0)
+		if (fio_remove(FIO_LOCAL_HOST, full_path, true) == 0)
 			elog(VERBOSE, "Deleted \"%s\"", full_path);
 		else
 			elog(ERROR, "Cannot delete file or directory \"%s\": %s", full_path, strerror(errno));