#undef WIN32 (#3)

(remove Windows support)

Author: kulaginm

doc/pgprobackup.xml

@@ -406,11 +406,6 @@ doc/src/sgml/pgprobackup.sgml
           <application>pg_backup</application> only supports PostgreSQL 9.5 and higher.
         </para>
       </listitem>
-      <listitem>
-        <para>
-          The remote mode is not supported on Windows systems.
-        </para>
-      </listitem>
       <listitem>
         <para>
           On Unix systems, for <productname>PostgreSQL</productname> 10 or lower,
@@ -1408,7 +1403,7 @@ pg_backup backup -B <replaceable>backup_dir</replaceable> --instance <replaceabl
         use the optional <option>--external-dirs</option> parameter
         that specifies the path to this directory. If you would like
         to add more than one external directory, you can provide several paths
-        separated by colons on Linux systems or semicolons on Windows systems.
+        separated by colons on Linux systems.
       </para>
       <para>
         For example, to include <filename>/etc/dir1</filename> and
@@ -1419,14 +1414,6 @@ pg_backup backup -B <replaceable>backup_dir</replaceable> --instance <replaceabl
       </para>
       <programlisting>
 pg_backup backup -B <replaceable>backup_dir</replaceable> --instance <replaceable>instance_name</replaceable> -b FULL --external-dirs=/etc/dir1:/etc/dir2
-</programlisting>
-      <para>
-        Similarly, to include <filename>C:\dir1</filename> and
-        <filename>C:\dir2</filename> directories into the full backup
-        on Windows, run:
-      </para>
-      <programlisting>
-pg_backup backup -B <replaceable>backup_dir</replaceable> --instance <replaceable>instance_name</replaceable> -b FULL --external-dirs=C:\dir1;C:\dir2
 </programlisting>
       <para>
         <application>pg_backup</application> recursively copies the contents
@@ -2076,12 +2063,6 @@ restore_command = '"<replaceable>install_dir</replaceable>/pg_backup" archive-ge
     <programlisting>
 pg_backup restore -B <replaceable>backup_dir</replaceable> --instance <replaceable>instance_name</replaceable> --remote-user=postgres --remote-host=192.168.0.2 --remote-port=2302 --restore-command='"<replaceable>install_dir</replaceable>/pg_backup" archive-get -B "<replaceable>backup_dir</replaceable>" --instance <replaceable>instance_name</replaceable> --wal-file-path=%p --wal-file-name=%f --remote-host=192.168.0.3 --remote-port=2303 --remote-user=backup'
 </programlisting>
-    <note>
-      <para>
-        The remote mode is currently unavailable for
-        Windows systems.
-      </para>
-    </note>
   </refsect2>
   <refsect2 id="pbk-running-pg-probackup-on-parallel-threads">
     <title>Running <application>pg_backup</application> on Parallel Threads</title>
@@ -2193,7 +2174,7 @@ pg_backup show-config -B <replaceable>backup_dir</replaceable> --instance <repla
     <para>
       If nothing is given, the default values are taken. By default
       <application>pg_backup</application> tries to use local connection via Unix domain
-      socket (<literal>localhost</literal> on Windows) and tries to get the database name
+      socket and tries to get the database name
       and the user name from the <envar>PGUSER</envar> environment variable or the
       current OS user name.
     </para>
@@ -3871,7 +3852,7 @@ pg_backup backup -B <replaceable>backup_dir</replaceable> -b <replaceable>backup
         is useful to back up scripts, SQL dump files, and configuration
         files located outside of the data directory. If you would like
         to back up several external directories, separate their paths
-        by a colon on Unix and a semicolon on Windows.
+        by a colon on Unix.
       </para>
       </listitem>
       </varlistentry>

gen_probackup_project.pl

@@ -2351,7 +2351,7 @@ process_block_change(ForkNumber forknum, RelFileNode rnode, BlockNumber blkno)
 	{
 		/* We need critical section only we use more than one threads */
 		if (num_threads > 1)
-			pthread_lock(&backup_pagemap_mutex);
+			pthread_mutex_lock(&backup_pagemap_mutex);
 
 		datapagemap_add(&(*file_item)->pagemap, blkno_inseg);
 

src/backup.c

@@ -2449,7 +2449,7 @@ write_page_headers(BackupPageHeader2 *headers, pgFile *file, HeaderMap *hdr_map,
 						read_len, ZLIB_COMPRESS, 1, &errormsg);
 
 	/* writing to header map must be serialized */
-	pthread_lock(&(hdr_map->mutex)); /* what if we crash while trying to obtain mutex? */
+	pthread_mutex_lock(&(hdr_map->mutex)); /* what if we crash while trying to obtain mutex? */
 
 	if (!hdr_map->fp)
 	{

src/data.c

@@ -1551,13 +1551,7 @@ make_external_directory_list(const char *colon_separated_dirs, bool remap)
 	parray	   *list = parray_new();
 	char	   *tmp = pg_strdup(colon_separated_dirs);
 
-#ifndef WIN32
-#define EXTERNAL_DIRECTORY_DELIMITER ":"
-#else
-#define EXTERNAL_DIRECTORY_DELIMITER ";"
-#endif
-
-	p = strtok(tmp, EXTERNAL_DIRECTORY_DELIMITER);
+	p = strtok(tmp, ":");
 	while(p!=NULL)
 	{
 		char	   *external_path = pg_strdup(p);
@@ -1582,7 +1576,7 @@ make_external_directory_list(const char *colon_separated_dirs, bool remap)
 			elog(ERROR, "External directory \"%s\" is not an absolute path",
 				 external_path);
 
-		p = strtok(NULL, EXTERNAL_DIRECTORY_DELIMITER);
+		p = strtok(NULL, ":");
 	}
 	pfree(tmp);
 	parray_qsort(list, pgCompareString);

src/dir.c

@@ -67,7 +67,7 @@ help_command(ProbackupSubcmd const subcmd)
 		&help_set_backup,
 		&help_show_config,
 		&help_checkdb,
-		&help_internal, // SSH_CMD
+		&help_nocmd, // SSH_CMD
 		&help_internal, // AGENT_CMD
 		&help_help,
 		&help_version,