fix: missing inputs and other nx issues (#258)

jumski · jumski · commit 6fce1db3ff1b · 2025-10-14T08:45:01.000Z
### TL;DR

Improved NX build caching configuration across all packages to optimize build times and CI performance.

### What changed?

- Added proper `inputs` configurations to all project targets to enable better caching
- Fixed the `serve` command in the CLI package to use the built output instead of source files
- Removed the `test:e2e:install:duplicates` dependency from the CLI test target
- Updated the client test command to exclude integration tests
- Fixed the Supabase reset command in edge-worker to depend on verified migrations
- Updated paths for Atlas configuration files in the core package
- Removed an invalid link card in the Supabase RPC documentation
- Added `cache` and `local` flags to appropriate targets to improve build performance

### How to test?

1. Run `nx build client` followed by `nx build client` again to verify the second build is cached
2. Run `nx test client` to ensure tests run correctly with the updated configuration
3. Verify the CLI serve command works properly with `nx serve cli`
4. Check that the website builds and deploys correctly with the new caching configuration

### Why make this change?

This change optimizes the build system by properly configuring NX's caching mechanism. By specifying the correct inputs for each target, we ensure that builds are only re-run when relevant files change. This significantly improves development and CI performance by avoiding unnecessary rebuilds and test runs, especially for packages that haven't changed.
diff --git a/.claude/settings.json b/.claude/settings.json
@@ -24,11 +24,12 @@
       "Bash(ls:*)",
       "Bash(mkdir:*)",
       "Bash(npx tsc:*)",
-      "Bash(pnpm tsc:*)",
       "Bash(pnpm eslint:*)",
       "Bash(pnpm nx build:*)",
+      "Bash(pnpm nx graph:*)",
       "Bash(pnpm nx lint:*)",
       "Bash(pnpm nx run:*)",
+      "Bash(pnpm nx show project:*)",
       "Bash(pnpm nx supabase:*)",
       "Bash(pnpm nx supabase:reset:*)",
       "Bash(pnpm nx supabase:start:*)",
@@ -39,6 +40,7 @@
       "Bash(pnpm nx typecheck:*)",
       "Bash(pnpm nx verify-migrations:*)",
       "Bash(pnpm nx verify-schemas-synced:*)",
+      "Bash(pnpm tsc:*)",
       "Bash(pnpm vitest run:*)",
       "Bash(pnpm vitest:*)",
       "Bash(psql:*)",
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -44,11 +44,14 @@ jobs:
       - name: Set Nx SHAs for affected commands
         uses: nrwl/nx-set-shas@v4
 
+      - name: Verify NX_BASE and NX_HEAD are set
+        run: echo "BASE=$NX_BASE HEAD=$NX_HEAD"
+
       - name: Quality gate (lint + typecheck + test)
-        run: pnpm nx affected -t lint typecheck test --parallel --configuration=production
+        run: pnpm nx affected -t lint typecheck test --parallel --configuration=production --base="$NX_BASE" --head="$NX_HEAD"
 
       - name: Build all affected projects (except playground)
-        run: pnpm nx affected -t build --configuration=production --parallel --exclude=playground
+        run: pnpm nx affected -t build --configuration=production --parallel --exclude=playground --base="$NX_BASE" --head="$NX_HEAD"
 
 
 # ────────────────────────────────── 2. DEPLOY PLAYGROUND ───────────────────────────
@@ -112,11 +115,14 @@ jobs:
 
       - name: Set Nx SHAs for affected commands
         uses: nrwl/nx-set-shas@v4
-      
+
+      - name: Verify NX_BASE and NX_HEAD are set
+        run: echo "BASE=$NX_BASE HEAD=$NX_HEAD"
+
       - name: Check if website is affected
         id: check-affected
         run: |
-          if pnpm nx show projects --affected -t build | grep -q "^website$"; then
+          if pnpm nx show projects --affected -t build --base="$NX_BASE" --head="$NX_HEAD" | grep -q "^website$"; then
             echo "affected=true" >> $GITHUB_OUTPUT
             echo "Website is affected by changes"
           else
diff --git a/nx.json b/nx.json
@@ -1,5 +1,6 @@
 {
   "$schema": "./node_modules/nx/schemas/nx-schema.json",
+  "defaultBase": "origin/main",
   "namedInputs": {
     "default": ["{projectRoot}/**/*", "sharedGlobals"],
     "production": [
diff --git a/pkgs/cli/project.json b/pkgs/cli/project.json
@@ -9,6 +9,7 @@
     "build": {
       "executor": "@nx/js:tsc",
       "outputs": ["{options.outputPath}"],
+      "inputs": ["production", "^production"],
       "options": {
         "main": "{projectRoot}/src/index.ts",
         "tsConfig": "{projectRoot}/tsconfig.lib.json",
@@ -25,18 +26,20 @@
     },
     "serve": {
       "executor": "nx:run-commands",
+      "cache": false,
+      "local": true,
       "dependsOn": ["build"],
       "options": {
-        "command": "tsx src/index.ts",
+        "command": "node dist/index.js",
         "cwd": "{projectRoot}"
       }
     },
     "test": {
       "executor": "nx:noop",
+      "inputs": ["default", "^production"],
       "dependsOn": [
         "test:vitest",
         "test:e2e:install",
-        "test:e2e:install:duplicates",
         "test:e2e:compile",
         "test:e2e:async-hang-issue-123"
       ],
@@ -46,6 +49,7 @@
     },
     "test:vitest": {
       "executor": "nx:run-commands",
+      "inputs": ["default", "^production"],
       "options": {
         "command": "vitest run",
         "cwd": "{projectRoot}"
@@ -55,6 +59,7 @@
       "executor": "nx:run-commands",
       "local": true,
       "dependsOn": ["build"],
+      "inputs": ["default", "^production"],
       "options": {
         "commands": [
           "./scripts/test-install",
@@ -68,6 +73,7 @@
       "executor": "nx:run-commands",
       "local": true,
       "dependsOn": ["test:e2e:install", "build"],
+      "inputs": ["default", "^production"],
       "options": {
         "commands": [
           "rm -rf supabase/",
@@ -83,6 +89,7 @@
       "executor": "nx:run-commands",
       "local": true,
       "dependsOn": ["build"],
+      "inputs": ["default", "^production"],
       "options": {
         "command": "./scripts/test-async-hang-issue-123",
         "cwd": "{projectRoot}"
diff --git a/pkgs/client/project.json b/pkgs/client/project.json
@@ -7,11 +7,16 @@
   "targets": {
     "build": {
       "executor": "nx:noop",
+      "inputs": ["production", "^production"],
       "outputs": ["{projectRoot}/dist"],
-      "dependsOn": ["build:lib", "build:browser", "verify-exports"]
+      "dependsOn": ["^build", "build:lib", "build:browser", "verify-exports"]
     },
     "verify-exports": {
       "executor": "nx:run-commands",
+      "inputs": [
+        "{projectRoot}/scripts/verify-exports.js",
+        "{projectRoot}/package.json"
+      ],
       "options": {
         "cwd": "{projectRoot}",
         "command": "pnpm run verify-exports"
@@ -22,6 +27,7 @@
       "executor": "@nx/vite:build",
       "outputs": ["{options.outputPath}"],
       "dependsOn": ["^build"],
+      "inputs": ["production", "^production"],
       "options": {
         "outputPath": "pkgs/client/dist",
         "configFile": "pkgs/client/vite.config.ts"
@@ -31,6 +37,7 @@
       "executor": "@nx/vite:build",
       "outputs": ["{options.outputPath}"],
       "dependsOn": ["^build"],
+      "inputs": ["production", "^production"],
       "options": {
         "outputPath": "pkgs/client/dist",
         "configFile": "pkgs/client/vite.browser.config.ts"
@@ -39,6 +46,7 @@
     "typecheck": {
       "executor": "@nx/js:tsc",
       "dependsOn": ["^build"],
+      "inputs": ["default", "^production"],
       "options": {
         "noEmit": true,
         "tsConfig": "pkgs/client/tsconfig.lib.json",
@@ -48,7 +56,7 @@
     },
     "lint": {
       "executor": "@nx/eslint:lint",
-      "inputs": ["default"]
+      "inputs": ["default", "^production"]
     },
     "supabase:ensure-started": {
       "executor": "nx:run-commands",
@@ -96,6 +104,14 @@
       "executor": "nx:run-commands",
       "local": true,
       "dependsOn": ["^verify-migrations"],
+      "inputs": [
+        "{workspaceRoot}/pkgs/core/supabase/migrations/**/*.sql",
+        "{workspaceRoot}/pkgs/core/supabase/seed.sql"
+      ],
+      "outputs": [
+        "{projectRoot}/supabase/migrations",
+        "{projectRoot}/supabase/seed.sql"
+      ],
       "options": {
         "cwd": "{projectRoot}",
         "commands": [
@@ -157,7 +173,7 @@
       "inputs": ["default", "^production"],
       "options": {
         "cwd": "{projectRoot}",
-        "commands": ["vitest run __tests__/"],
+        "commands": ["vitest run __tests__/ --exclude __tests__/integration/"],
         "parallel": false
       }
     },
@@ -174,6 +190,7 @@
     },
     "test": {
       "executor": "nx:noop",
+      "inputs": ["default", "^production"],
       "dependsOn": ["test:vitest", "test:types"]
     },
     "benchmark": {
@@ -189,14 +206,19 @@
     },
     "test:types:vitest": {
       "executor": "nx:run-commands",
+      "cache": true,
       "dependsOn": ["build"],
+      "inputs": ["default", "^production"],
       "options": {
         "cwd": "{projectRoot}",
         "command": "pnpm vitest --typecheck.only --run"
       }
     },
     "test:types:strict": {
       "executor": "nx:run-commands",
+      "cache": true,
+      "dependsOn": ["build"],
+      "inputs": ["default", "^production"],
       "options": {
         "cwd": "{projectRoot}",
         "command": "bash ../../scripts/typecheck-ts2578.sh"
diff --git a/pkgs/core/project.json b/pkgs/core/project.json
@@ -8,8 +8,7 @@
     "schemas": ["{projectRoot}/schemas/**/*.sql"],
     "migrations": ["{projectRoot}/supabase/migrations/**/*.sql"],
     "atlasSetup": [
-      "{projectRoot}/atlas.hcl",
-      "{projectRoot}/Dockerfile.atlas",
+      "{projectRoot}/atlas/atlas.hcl",
       "{projectRoot}/supabase/migrations/atlas.sum",
       "{projectRoot}/scripts/atlas-verify-schemas-synced"
     ],
@@ -75,7 +74,7 @@
     },
     "build": {
       "executor": "@nx/js:tsc",
-      "inputs": ["default", "databaseTypes"],
+      "inputs": ["production", "databaseTypes", "^production"],
       "options": {
         "outputPath": "pkgs/core/dist",
         "main": "pkgs/core/src/index.ts",
@@ -93,6 +92,9 @@
     },
     "jsr:publish": {
       "executor": "nx:run-commands",
+      "cache": false,
+      "local": true,
+      "dependsOn": ["build"],
       "outputs": ["{workspaceRoot}/pkgs/core/"],
       "options": {
         "cwd": "pkgs/core",
@@ -103,18 +105,18 @@
     "lint:sqruff": {
       "executor": "nx:run-commands",
       "local": true,
+      "inputs": ["schemas", "sqruffConfig"],
       "options": {
         "cwd": "{projectRoot}",
         "commands": [
           "sqruff --config=../../.sqruff lint --parsing-errors schemas/"
         ],
-        "inputs": ["schemas", "sqruffConfig"],
         "parallel": false
       }
     },
     "lint:eslint": {
       "executor": "@nx/eslint:lint",
-      "inputs": ["default"]
+      "inputs": ["default", "^production"]
     },
     "lint": {
       "executor": "nx:noop",
@@ -124,12 +126,12 @@
     "fix-sql": {
       "executor": "nx:run-commands",
       "local": true,
+      "inputs": ["schemas", "sqruffConfig"],
       "options": {
         "cwd": "{projectRoot}",
         "commands": [
           "sqruff --config=../../.sqruff fix --force --parsing-errors schemas/"
         ],
-        "inputs": ["schemas", "sqruffConfig"],
         "parallel": false
       }
     },
@@ -198,6 +200,7 @@
     },
     "test": {
       "executor": "nx:noop",
+      "inputs": ["default", "^production", "schemas", "migrations", "pgtapTests", "databaseTypes"],
       "dependsOn": ["test:pgtap", "test:vitest", "test:types"]
     },
     "test:pgtap": {
@@ -214,8 +217,8 @@
     },
     "test:vitest": {
       "executor": "@nx/vite:test",
-      "dependsOn": ["^build", "build", "verify-gen-types"],
-      "inputs": ["default", "databaseTypes"],
+      "dependsOn": ["build", "verify-gen-types"],
+      "inputs": ["default", "databaseTypes", "^production"],
       "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
       "options": {
         "passWithNoTests": true,
@@ -272,14 +275,19 @@
     },
     "test:types:vitest": {
       "executor": "nx:run-commands",
+      "cache": true,
       "dependsOn": ["build"],
+      "inputs": ["default", "^production"],
       "options": {
         "cwd": "{projectRoot}",
         "command": "pnpm vitest --typecheck.only --run"
       }
     },
     "test:types:strict": {
       "executor": "nx:run-commands",
+      "cache": true,
+      "dependsOn": ["^build"],
+      "inputs": ["default", "^production"],
       "options": {
         "cwd": "{projectRoot}",
         "command": "bash ../../scripts/typecheck-ts2578.sh"
diff --git a/pkgs/core/src/types.ts b/pkgs/core/src/types.ts
@@ -4,16 +4,11 @@ import type {
   Simplify,
   AnyFlow,
   ExtractFlowInput,
+  Json,
 } from '@pgflow/dsl';
 import type { Database } from './database-types.js';
 
-export type Json =
-  | string
-  | number
-  | boolean
-  | null
-  | { [key: string]: Json | undefined }
-  | Json[];
+export type { Json };
 
 /**
  * Record representing a task from pgflow.start_tasks
diff --git a/pkgs/dsl/project.json b/pkgs/dsl/project.json
@@ -8,6 +8,7 @@
   "targets": {
     "build": {
       "executor": "@nx/js:tsc",
+      "inputs": ["production", "^production"],
       "options": {
         "outputPath": "pkgs/dsl/dist",
         "main": "pkgs/dsl/src/index.ts",
@@ -28,6 +29,7 @@
     "test:vitest": {
       "executor": "@nx/vite:test",
       "dependsOn": ["build"],
+      "inputs": ["default", "^production"],
       "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
       "options": {
         "passWithNoTests": true,
@@ -36,13 +38,19 @@
     },
     "test:types:vitest": {
       "executor": "nx:run-commands",
+      "cache": true,
+      "dependsOn": ["build"],
+      "inputs": ["default", "^production"],
       "options": {
         "cwd": "{projectRoot}",
         "command": "pnpm vitest --typecheck.only --run"
       }
     },
     "test:types:strict": {
       "executor": "nx:run-commands",
+      "cache": true,
+      "dependsOn": ["^build"],
+      "inputs": ["default", "^production"],
       "options": {
         "cwd": "{projectRoot}",
         "command": "bash ../../scripts/typecheck-ts2578.sh"
@@ -61,6 +69,7 @@
     },
     "test": {
       "executor": "nx:noop",
+      "inputs": ["default", "^production"],
       "dependsOn": ["test:vitest", "test:types"]
     }
   }
diff --git a/pkgs/dsl/src/dsl.ts b/pkgs/dsl/src/dsl.ts
diff --git a/pkgs/edge-worker/project.json b/pkgs/edge-worker/project.json
diff --git a/pkgs/example-flows/project.json b/pkgs/example-flows/project.json
diff --git a/pkgs/website/project.json b/pkgs/website/project.json

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"$schema": "./node_modules/nx/schemas/nx-schema.json",`
	`3`	`+ "defaultBase": "origin/main",`
`3`	`4`	`"namedInputs": {`
`4`	`5`	`"default": ["{projectRoot}/*/", "sharedGlobals"],`
`5`	`6`	`"production": [`