Add support of DEPENDS/NO DEPENDS ON EXTENSION for INDEX. #6388

Author: RohitBhati8269

docs/en_US/images/index_definition.png

@@ -48,6 +48,9 @@ Use the fields in the *Definition* tab to define the index:
     * Select *brin* to create a BRIN index.  A BRIN index may improve
       performance when managing minimum and maximum values and ranges.
 
+* Use the drop-down listbox next to *Depends on extensions* to select the extension 
+  that this index depends on (for example, edbspl). If set, dropping the extension 
+  will automatically drop the index as well.
 * Use the *Fill Factor* field to specify a fill factor for the index. The fill
   factor specifies how full the selected method will try to fill each index
   page.

docs/en_US/index_dialog.rst

@@ -10,7 +10,7 @@ the REFRESH MATERIALIZED VIEW command to update the content of a materialized
 view.
 
 The *Materialized View* dialog organizes the development of a materialized_view
-through the following dialog tabs: *General*, *Definition*, *Storage*,
+through the following dialog tabs: *General*, *Definition*, *Code*,
 *Parameter*, and *Security*. The *SQL* tab displays the SQL code generated by
 dialog selections.
 
@@ -31,10 +31,10 @@ Use the fields in the *General* tab to identify the materialized view:
 Click the *Definition* tab to continue.
 
 .. image:: images/materialized_view_definition.png
-    :alt: Materialized view dialog storage tab
+    :alt: Materialized view dialog definition tab
     :align: center
 
-Use the fields in the *Storage* tab to maintain the materialized view:
+Use the fields in the *Definition* tab to maintain the materialized view:
 
 * Move the *With Data* switch to the *Yes* position to specify the materialized
   view should be populated at creation time. If not, the materialized view
@@ -54,7 +54,7 @@ Use the fields in the *Storage* tab to maintain the materialized view:
 Click the *Code* tab to continue.
 
 .. image:: images/materialized_view_code.png
-    :alt: Materialized view dialog definition tab
+    :alt: Materialized view dialog code tab
     :align: center
 
 Use the text editor field in the *Code* tab to provide the query that will

docs/en_US/materialized_view_dialog.rst

@@ -125,6 +125,8 @@ define('pgadmin.node.index', [
       },
       getSchema: (treeNodeInfo, itemNodeData) => {
         let nodeObj = pgAdmin.Browser.Nodes['index'];
+        let nodeExtObj = pgBrowser.Nodes['extension'];
+
         return new IndexSchema(
           {
             tablespaceList: ()=>getNodeListByName('tablespace', treeNodeInfo, itemNodeData, {}, (m)=>{
@@ -133,7 +135,17 @@ define('pgadmin.node.index', [
             amnameList : ()=>getNodeAjaxOptions('get_access_methods', nodeObj, treeNodeInfo, itemNodeData, {jumpAfterNode: 'schema'}),
             columnList: ()=>getNodeListByName('column', treeNodeInfo, itemNodeData, {}),
             collationList: ()=>getNodeAjaxOptions('get_collations', nodeObj, treeNodeInfo, itemNodeData, {jumpAfterNode: 'schema'}),
-            opClassList: ()=>getNodeAjaxOptions('get_op_class', nodeObj, treeNodeInfo, itemNodeData, {jumpAfterNode: 'schema'})
+            opClassList: ()=>getNodeAjaxOptions('get_op_class', nodeObj, treeNodeInfo, itemNodeData, {jumpAfterNode: 'schema'}),
+            extensionsList:()=>getNodeAjaxOptions('nodes', nodeExtObj, treeNodeInfo, itemNodeData, { cacheLevel: 'server'},
+              (data)=>{
+                let res = [];
+                if (data && _.isArray(data)) {
+                  _.each(data, function(d) {
+                    res.push({label: d.label, value: d.label, data: d});
+                  });
+                }
+                return res;
+              }),
           },
           {
             node_info: treeNodeInfo

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/static/js/index.js

@@ -505,7 +505,23 @@ export default class IndexSchema extends BaseUISchema {
             return Promise.resolve(()=>{/*This is intentional (SonarQube)*/});
           }
         },
-      },{
+      },
+      {
+        id: 'dependsonextensions',
+        label: gettext('Depends on extensions'),
+        group: gettext('Definition'),
+        type: 'select',
+        options: this.fieldOptions.extensionsList,
+        controlProps: {
+          multiple: true,
+          allowClear: true,
+          allowSelectAll: true,
+          placeholder: gettext('Select the Depends on extensions...'),
+        },
+        min_version: 130000,
+        mode: ['create', 'edit', 'properties']
+      },
+      {
         type: 'nested-fieldset', label: gettext('With'), group: gettext('Definition'),
         schema: this.withSchema,
       },{

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/static/js/index.ui.js

@@ -0,0 +1,2 @@
+ALTER INDEX public."Idx_$%{}[]()&*^!@""'`\/#"
+    NO DEPENDS ON EXTENSION postgres_fdw;

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/13_plus/alter_index_no_depends.msql

@@ -0,0 +1,17 @@
+-- Index: Idx_$%{}[]()&*^!@"'`\/#
+
+-- DROP INDEX IF EXISTS public."Idx_$%{}[]()&*^!@""'`\/#";
+
+CREATE UNIQUE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
+    ON public.test_table_for_indexes USING btree
+    (id ASC NULLS LAST, name COLLATE pg_catalog."POSIX" text_pattern_ops ASC NULLS LAST)
+    INCLUDE(name, id)
+    WITH (fillfactor=10, deduplicate_items=False)
+    TABLESPACE pg_default
+    WHERE id < 100;
+
+ALTER INDEX public."Idx_$%{}[]()&*^!@""'`\/#"
+    DEPENDS ON EXTENSION plpgsql;
+
+COMMENT ON INDEX public."Idx_$%{}[]()&*^!@""'`\/#"
+    IS 'Test Comment';

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/13_plus/alter_index_no_depends.sql

@@ -11,6 +11,5 @@ CREATE UNIQUE INDEX IF NOT EXISTS "Idx1_$%{}[]()&*^!@""'`\/#"
 
 ALTER TABLE IF EXISTS public.test_table_for_indexes
     CLUSTER ON "Idx1_$%{}[]()&*^!@""'`\/#";
-
 COMMENT ON INDEX public."Idx1_$%{}[]()&*^!@""'`\/#"
     IS 'Test Comment';

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/13_plus/alter_name_fillfactor_comment.sql

@@ -0,0 +1,16 @@
+CREATE UNIQUE INDEX "Idx_$%{}[]()&*^!@""'`\/#"
+    ON public.test_table_for_indexes USING btree
+    (id ASC NULLS LAST, name COLLATE pg_catalog."POSIX" text_pattern_ops ASC NULLS LAST)
+    INCLUDE(name, id)
+    WITH (fillfactor=10, deduplicate_items=False)
+    TABLESPACE pg_default
+    WHERE id < 100;
+
+ALTER INDEX public."Idx_$%{}[]()&*^!@""'`\/#"
+    DEPENDS ON EXTENSION plpgsql;
+
+ALTER INDEX public."Idx_$%{}[]()&*^!@""'`\/#"
+    DEPENDS ON EXTENSION postgres_fdw;
+
+COMMENT ON INDEX public."Idx_$%{}[]()&*^!@""'`\/#"
+    IS 'Test Comment';

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/tests/13_plus/create_index_with_ext.msql

@@ -0,0 +1,20 @@
+-- Index: Idx_$%{}[]()&*^!@"'`\/#
+
+-- DROP INDEX IF EXISTS public."Idx_$%{}[]()&*^!@""'`\/#";
+
+CREATE UNIQUE INDEX IF NOT EXISTS "Idx_$%{}[]()&*^!@""'`\/#"
+    ON public.test_table_for_indexes USING btree
+    (id ASC NULLS LAST, name COLLATE pg_catalog."POSIX" text_pattern_ops ASC NULLS LAST)
+    INCLUDE(name, id)
+    WITH (fillfactor=10, deduplicate_items=False)
+    TABLESPACE pg_default
+    WHERE id < 100;
+
+ALTER INDEX public."Idx_$%{}[]()&*^!@""'`\/#"
+    DEPENDS ON EXTENSION plpgsql;
+
+ALTER INDEX public."Idx_$%{}[]()&*^!@""'`\/#"
+    DEPENDS ON EXTENSION postgres_fdw;
+
+COMMENT ON INDEX public."Idx_$%{}[]()&*^!@""'`\/#"
+    IS 'Test Comment';