Fixed indentation issue in the extraEnvVars field, preserved the serverDefinitions template, corrected a typo in README.md, and increased resource allocations in the Helm chart.

Author: KorenP1

pkg/helm/README.md

@@ -34,8 +34,8 @@ The chart should dump its version and appVersion in the Chart.yaml file every re
 | `preferences.enabled` | Whether to mount preferences.json | `false` |
 | `preferences.data` | Preferences to load | `{}` |
 | `resources.*` | Allocated requests and limits resources | `{"requests": {...}, "limits": {...}}` |
-| `persistence.enabled` | PVC resource creation | `false` |
+| `persistence.enabled` | PVC resource creation | `true` |
 | `service.type` | Service type | `"ClusterIP"` |
 | `service.loadBalancerIP` | Load balancer IP (Only if service.type is LoadBalancer) | `""` |
 | `ingress.enabled` | Ingress resource creation | `false` |
-| `ingress.hostname` | Ingress resource hostname | `"pgadmin4.local"` |
+| `ingress.hostname` | Ingress resource hostname | `"pgadmin4.local"` |

pkg/helm/templates/_helpers.tpl

@@ -25,4 +25,25 @@
   {{- $securityContext = omit $securityContext "appArmorProfile" -}}
 {{- end -}}
 {{- $securityContext | toYaml -}}
-{{- end -}}
+{{- end -}}
+
+{{- define "tpl.preserve.variable" -}}
+{{- $obj := . }}
+{{- if kindIs "map" $obj }}
+  {{- range $k, $v := $obj }}
+    {{- if kindIs "string" $v }}
+      {{- if regexMatch "^[0-9]+$" $v }}
+        {{- $_ := set $obj $k (atoi $v) }}
+      {{- else if regexMatch "(?i)^(true|false)$" $v }}
+        {{- $_ := set $obj $k (eq (lower $v) "true") }}
+      {{- end }}
+    {{- else }}
+      {{- include "tpl.preserve.variable" $v }}
+    {{- end }}
+  {{- end }}
+{{- else if kindIs "slice" $obj }}
+  {{- range $i, $v := $obj }}
+    {{- include "tpl.preserve.variable" $v }}
+  {{- end }}
+{{- end }}
+{{- end }}

pkg/helm/templates/configmap-serverDefinitions.yaml

@@ -10,5 +10,7 @@ metadata:
   annotations: {{ . | toYaml | nindent 4 }}
   {{- end }}
 data:
-  servers.json: | {{ tpl (dict "Servers" .Values.serverDefinitions.data | toYaml) . | fromYaml | toPrettyJson | nindent 4 }}
+{{- $variableToPreserveTPL := tpl (dict "Servers" .Values.serverDefinitions.data | toYaml) . | fromYaml }}
+{{- include "tpl.preserve.variable" $variableToPreserveTPL }}
+  servers.json: | {{ $variableToPreserveTPL | toYaml | nindent 4 }}
 {{- end }}

pkg/helm/templates/deployment.yaml

@@ -117,7 +117,7 @@ spec:
             - name: PGADMIN_DISABLE_POSTFIX
               value: {{ .Values.disablePostfix | quote }}
           {{- with .Values.extraEnvVars }}
-          {{- tpl (. | toYaml) $ | nindent 14 }}
+          {{- tpl (. | toYaml) $ | nindent 12 }}
           {{- end }}
           volumeMounts:
             - mountPath: /var/lib/pgadmin
@@ -234,4 +234,4 @@ spec:
               type: RuntimeDefault
             {{- end }}
             windowsOptions:
-              hostProcess: false
+              hostProcess: false

pkg/helm/values.yaml

@@ -71,11 +71,11 @@ preferences:
 
 resources:
   requests:
-    cpu: 250m
-    memory: 512Mi
+    cpu: 500m
+    memory: 1Gi
   limits:
-    cpu: 250m
-    memory: 512Mi
+    cpu: 500m
+    memory: 1Gi
 
 persistence:
   enabled: true
@@ -152,4 +152,5 @@ containerSecurityContext:
   appArmorProfile:
     type: RuntimeDefault
   windowsOptions:
-    hostProcess: false
+
+    hostProcess: false