Revert "Replace CheckPrototypeDefinition with CheckSourceCompiles"

This reverts commit c3b32df.

The CheckPrototypeDefinition module is unique among C build systems and
should be fixed in the future. Use CheckPrototypeDefinition anyway.

Author: petk

cmake/cmake/checks/CheckGethostbynameR.cmake

@@ -21,7 +21,7 @@ See also:
 https://www.gnu.org/software/autoconf-archive/ax_func_which_gethostbyname_r.html
 #]=============================================================================]
 
-include(CheckSourceCompiles)
+include(CheckPrototypeDefinition)
 include(CMakePushCheckState)
 include(PHP/SearchLibraries)
 
@@ -61,53 +61,44 @@ function(_php_check_gethostbyname_r)
     set(CMAKE_REQUIRED_QUIET TRUE)
 
     # Check for 6 arguments signature.
-    check_source_compiles(C [[
-      #include <netdb.h>
-      int gethostbyname_r(
-        const char *name,
-        struct hostent *ret,
-        char *buf,
-        size_t buflen,
-        struct hostent **result,
-        int *h_errnop
-      );
-      int main(void) { return 0; }
-    ]] PHP_HAVE_FUNC_GETHOSTBYNAME_R_6)
-
+    check_prototype_definition(
+      gethostbyname_r
+      "int gethostbyname_r(const char *name, struct hostent *ret, char *buf, \
+        size_t buflen, struct hostent **result, int *h_errnop)"
+      "0"
+      netdb.h
+      PHP_HAVE_FUNC_GETHOSTBYNAME_R_6
+    )
     if(PHP_HAVE_FUNC_GETHOSTBYNAME_R_6)
       cmake_pop_check_state()
       message(CHECK_PASS "six")
       return()
     endif()
 
     # Check for 5 arguments signature.
-    check_source_compiles(C [[
-      #include <netdb.h>
-      struct hostent *gethostbyname_r(
-        const char *name,
-        struct hostent *result,
-        char *buffer,
-        int buflen,
-        int *h_errnop
-      );
-      int main(void) { return 0; }
-    ]] PHP_HAVE_FUNC_GETHOSTBYNAME_R_5)
+    check_prototype_definition(
+      gethostbyname_r
+      "struct hostent *gethostbyname_r(const char *name, struct hostent *result, \
+        char *buffer, int buflen, int *h_errnop)"
+      "0"
+      netdb.h
+      PHP_HAVE_FUNC_GETHOSTBYNAME_R_5
+    )
     if(PHP_HAVE_FUNC_GETHOSTBYNAME_R_5)
       cmake_pop_check_state()
       message(CHECK_PASS "five")
       return()
     endif()
 
     # Check for 3 arguments signature.
-    check_source_compiles(C [[
-      #include <netdb.h>
-      int gethostbyname_r(
-        const char *name,
-        struct hostent *htent,
-        struct hostent_data *data
-      );
-      int main(void) { return 0; }
-    ]] PHP_HAVE_FUNC_GETHOSTBYNAME_R_3)
+    check_prototype_definition(
+      gethostbyname_r
+      "int gethostbyname_r(const char *name, struct hostent *htent, \
+        struct hostent_data *data)"
+      "0"
+      netdb.h
+      PHP_HAVE_FUNC_GETHOSTBYNAME_R_3
+    )
     if(PHP_HAVE_FUNC_GETHOSTBYNAME_R_3)
       cmake_pop_check_state()
       message(CHECK_PASS "three")

cmake/ext/iconv/CMakeLists.txt

@@ -28,7 +28,7 @@ project(
   LANGUAGES C
 )
 
-include(CheckSourceCompiles)
+include(CheckPrototypeDefinition)
 include(CheckSourceRuns)
 include(CheckSymbolExists)
 include(CMakeDependentOption)
@@ -288,17 +288,14 @@ if(TARGET Iconv::Iconv)
   cmake_push_check_state(RESET)
     set(CMAKE_REQUIRED_LIBRARIES Iconv::Iconv)
 
-    check_source_compiles(C [[
-      #include <iconv.h>
-      size_t iconv(
-        iconv_t cd,
-        const char **src,
-        size_t *srcleft,
-        char **dst,
-        size_t *dstleft
-      );
-      int main(void) { return 0; }
-    ]] PHP_EXT_ICONV_CONST)
+    check_prototype_definition(
+      iconv
+      "size_t iconv(iconv_t cd, const char **src, size_t *srcleft, char **dst, \
+        size_t *dstleft)"
+      "0"
+      "iconv.h"
+      PHP_EXT_ICONV_CONST
+    )
   cmake_pop_check_state()
 
   if(PHP_EXT_ICONV_CONST)

cmake/ext/posix/cmake/CheckTtynameR.cmake

@@ -10,7 +10,7 @@ On modern systems a simpler check is sufficient in the future:
   check_symbol_exists(ttyname_r unistd.h <result-var>)
 #]=============================================================================]
 
-include(CheckSourceCompiles)
+include(CheckPrototypeDefinition)
 include(CheckSourceRuns)
 include(CMakePushCheckState)
 include(PHP/SystemExtensions)
@@ -41,11 +41,13 @@ function(_php_ext_posix_check_ttyname_r result)
     # - _DARWIN_C_SOURCE on older Mac OS X 10.4
     set(CMAKE_REQUIRED_LIBRARIES PHP::SystemExtensions)
 
-    check_source_compiles(C [[
-      #include <unistd.h>
-      int ttyname_r(int fd, char *buf, size_t buflen);
-      int main(void) { return 0; }
-    ]] PHP_EXT_POSIX_HAVE_TTYNAME_R_SYMBOL)
+    check_prototype_definition(
+      ttyname_r
+      "int ttyname_r(int fd, char *buf, size_t buflen)"
+      "0"
+      "unistd.h"
+      PHP_EXT_POSIX_HAVE_TTYNAME_R_SYMBOL
+    )
 
     if(NOT PHP_EXT_POSIX_HAVE_TTYNAME_R_SYMBOL)
       message(CHECK_FAIL "no (non-standard declaration)")