Skip to content

Commit 5982251

Browse files
committed
Export symbols for executable and shared SAPIs
These configurations are needed on Windows (at least according to recent testing). The configuration variables are available as of CMake 3.27.
1 parent b639a7a commit 5982251

File tree

7 files changed

+4
-6
lines changed

7 files changed

+4
-6
lines changed

cmake/sapi/CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ define_property(
2222

2323
list(APPEND CMAKE_MESSAGE_CONTEXT "sapi")
2424

25+
# Enable symbols exporting for executable and shared SAPIs.
26+
set(CMAKE_EXECUTABLE_ENABLE_EXPORTS TRUE)
27+
set(CMAKE_SHARED_LIBRARY_ENABLE_EXPORTS TRUE)
28+
2529
# Traverse CMakeLists.txt files of PHP SAPIs.
2630
file(GLOB sapis ${CMAKE_CURRENT_SOURCE_DIR}/*/CMakeLists.txt)
2731
list(TRANSFORM sapis REPLACE "${CMAKE_CURRENT_SOURCE_DIR}/|/CMakeLists.txt" "")

cmake/sapi/cgi/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ set_target_properties(
5353
php_sapi_cgi
5454
PROPERTIES
5555
OUTPUT_NAME ${PHP_PROGRAM_PREFIX}php-cgi${PHP_PROGRAM_SUFFIX}
56-
ENABLE_EXPORTS TRUE # TODO: Check if there's a better solution.
5756
PHP_CLI TRUE
5857
PHP_SAPI_FASTCGI TRUE
5958
)

cmake/sapi/cli/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ set_target_properties(
132132
php_sapi_cli
133133
PROPERTIES
134134
OUTPUT_NAME ${PHP_PROGRAM_PREFIX}php${PHP_PROGRAM_SUFFIX}
135-
ENABLE_EXPORTS TRUE # TODO: Check if there's a better solution.
136135
PHP_CLI TRUE
137136
)
138137

cmake/sapi/embed/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ foreach(target IN ITEMS php_sapi_embed php_sapi_embed_shared)
7676
set_target_properties(
7777
${target}
7878
PROPERTIES
79-
ENABLE_EXPORTS TRUE # TODO: Check if there's a better solution.
8079
PHP_CLI TRUE
8180
)
8281
endforeach()

cmake/sapi/fpm/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,6 @@ set_target_properties(
239239
php_sapi_fpm
240240
PROPERTIES
241241
OUTPUT_NAME ${PHP_PROGRAM_PREFIX}php-fpm${PHP_PROGRAM_SUFFIX}
242-
ENABLE_EXPORTS TRUE # TODO: Check if there's a better solution.
243242
PHP_SAPI_FASTCGI TRUE
244243
)
245244

cmake/sapi/litespeed/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ set_target_properties(
5353
php_sapi_litespeed
5454
PROPERTIES
5555
OUTPUT_NAME ${PHP_PROGRAM_PREFIX}lsphp${PHP_PROGRAM_SUFFIX}
56-
ENABLE_EXPORTS TRUE # TODO: Check if there's a better solution.
5756
)
5857

5958
install(

cmake/sapi/phpdbg/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ foreach(target IN ITEMS php_sapi_phpdbg php_sapi_phpdbg_shared)
163163
${target}
164164
PROPERTIES
165165
OUTPUT_NAME ${PHP_PROGRAM_PREFIX}phpdbg${PHP_PROGRAM_SUFFIX}
166-
ENABLE_EXPORTS TRUE # TODO: Check if there's a better solution.
167166
PHP_CLI TRUE
168167
)
169168
endforeach()

0 commit comments

Comments
 (0)