Skip to content

Commit 4db5087

Browse files
committed
Fix nits
1 parent 0ed3a56 commit 4db5087

File tree

6 files changed

+41
-32
lines changed

6 files changed

+41
-32
lines changed

cmake/cmake/modules/FindDTrace.cmake

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,8 @@ function(dtrace_target)
207207
OUTPUT CMakeFiles/GenerateDTraceHeader.cmake
208208
CONTENT [[
209209
execute_process(
210-
COMMAND "@DTrace_EXECUTABLE@"
210+
COMMAND
211+
"@DTrace_EXECUTABLE@"
211212
-s "@parsed_INPUT@" # Input file.
212213
-h # Generate a SystemTap header file.
213214
-C # Run the C preprocessor (cpp) on the input file.

cmake/cmake/modules/FindGcov.cmake

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,8 @@ macro(gcov_generate_report)
127127
CONTENT "
128128
message(STATUS \"Generating lcov data for php_lcov.info\")
129129
execute_process(
130-
COMMAND ${Gcov_LCOV_EXECUTABLE}
130+
COMMAND
131+
${Gcov_LCOV_EXECUTABLE}
131132
--capture
132133
--no-external
133134
--directory ${PROJECT_BINARY_DIR}
@@ -136,7 +137,8 @@ macro(gcov_generate_report)
136137
137138
message(STATUS \"Stripping bundled libraries from php_lcov.info\")
138139
execute_process(
139-
COMMAND ${Gcov_LCOV_EXECUTABLE}
140+
COMMAND
141+
${Gcov_LCOV_EXECUTABLE}
140142
--output-file ${PROJECT_BINARY_DIR}/php_lcov.info
141143
--remove ${PROJECT_BINARY_DIR}/php_lcov.info */<stdout>
142144
${PROJECT_BINARY_DIR}/ext/bcmath/libbcmath/*
@@ -152,7 +154,8 @@ macro(gcov_generate_report)
152154
153155
message(STATUS \"Generating lcov HTML\")
154156
execute_process(
155-
COMMAND ${Gcov_GENHTML_EXECUTABLE}
157+
COMMAND
158+
${Gcov_GENHTML_EXECUTABLE}
156159
--legend
157160
--output-directory ${PROJECT_BINARY_DIR}/lcov_html
158161
--title \"PHP Code Coverage\"
@@ -169,7 +172,8 @@ macro(gcov_generate_report)
169172
endif()
170173
file(MAKE_DIRECTORY ${PROJECT_BINARY_DIR}/gcovr_html)
171174
execute_process(
172-
COMMAND ${Gcov_GCOVR_EXECUTABLE}
175+
COMMAND
176+
${Gcov_GCOVR_EXECUTABLE}
173177
-sr ${PROJECT_BINARY_DIR}
174178
-o ${PROJECT_BINARY_DIR}/gcovr_html/index.html
175179
--html
@@ -192,7 +196,8 @@ macro(gcov_generate_report)
192196
file(REMOVE ${PROJECT_BINARY_DIR}/gcovr.xml)
193197
endif()
194198
execute_process(
195-
COMMAND ${Gcov_GCOVR_EXECUTABLE}
199+
COMMAND
200+
${Gcov_GCOVR_EXECUTABLE}
196201
-sr ${PROJECT_BINARY_DIR}
197202
-o ${PROJECT_BINARY_DIR}/gcovr.xml
198203
--xml

cmake/cmake/modules/FindMC.cmake

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,8 @@ function(mc_target)
227227

228228
add_custom_command(
229229
OUTPUT "${output}"
230-
COMMAND ${MC_EXECUTABLE}
230+
COMMAND
231+
${MC_EXECUTABLE}
231232
# Header export directory:
232233
-h "${parsed_HEADER_DIR}"
233234
# Export directory for rc files:

cmake/cmake/modules/PHP/AddCustomCommand.cmake

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,11 @@ function(php_add_custom_command)
106106
return()
107107
endif()
108108

109-
set(target_name ${ARGV0})
110-
111109
add_custom_target(
112-
${target_name} ALL
113-
COMMAND ${CMAKE_COMMAND}
110+
${ARGV0}
111+
ALL
112+
COMMAND
113+
${CMAKE_COMMAND}
114114
-D "PHP_EXECUTABLE=${PHP_EXECUTABLE}"
115115
-D "OUTPUT=${parsed_OUTPUT}"
116116
-D "PHP_COMMAND=${parsed_PHP_COMMAND}"

cmake/pear/cmake/InstallPear.cmake

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ if(NOT EXISTS ${php_pear_current_binary_dir}/install-pear-nozlib.phar)
7171
if(php_pear_php_executable AND NOT download_status)
7272
# Download using fetch.php.
7373
execute_process(
74-
COMMAND ${php_pear_php_executable}
74+
COMMAND
75+
${php_pear_php_executable}
7576
-n
7677
${php_pear_current_source_dir}/fetch.php
7778
${php_pear_installer_url}
@@ -156,24 +157,25 @@ endif()
156157

157158
# Run the PEAR installer.
158159
execute_process(
159-
COMMAND ${php_pear_php_executable}
160-
-n
161-
-dshort_open_tag=0
162-
-dopen_basedir=
163-
-derror_reporting=1803
164-
-dmemory_limit=-1
165-
${php_pear_options}
166-
${php_pear_current_binary_dir}/install-pear-nozlib.phar
167-
--dir "${php_pear_install_dir}"
168-
--bin "${php_pear_install_bin_dir}"
169-
--metadata "${php_pear_install_dir}"
170-
--data "${php_pear_install_dir}"
171-
--temp "${php_pear_stage_temp_dir}"
172-
--cache "${php_pear_temp_dir}/cache"
173-
--download "${php_pear_temp_dir}/download"
174-
--php ${php_pear_installed_php_bin}
175-
-dp a${php_pear_php_program_prefix}
176-
-ds a${php_pear_php_program_suffix}
160+
COMMAND
161+
${php_pear_php_executable}
162+
-n
163+
-dshort_open_tag=0
164+
-dopen_basedir=
165+
-derror_reporting=1803
166+
-dmemory_limit=-1
167+
${php_pear_options}
168+
${php_pear_current_binary_dir}/install-pear-nozlib.phar
169+
--dir "${php_pear_install_dir}"
170+
--bin "${php_pear_install_bin_dir}"
171+
--metadata "${php_pear_install_dir}"
172+
--data "${php_pear_install_dir}"
173+
--temp "${php_pear_stage_temp_dir}"
174+
--cache "${php_pear_temp_dir}/cache"
175+
--download "${php_pear_temp_dir}/download"
176+
--php ${php_pear_installed_php_bin}
177+
-dp a${php_pear_php_program_prefix}
178+
-ds a${php_pear_php_program_suffix}
177179
OUTPUT_VARIABLE output
178180
ERROR_VARIABLE output
179181
RESULT_VARIABLE result

cmake/sapi/apache2handler/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ with the `APACHE_ROOT` and `Apache_APXS_EXECUTABLE` variables.
2222
For example:
2323
2424
```cmake
25-
cmake -B php-build -DAPACHE2HANDLER=ON -DAPACHE_ROOT=/opt/apache2
25+
cmake -B php-build -DPHP_SAPI_APACHE2HANDLER=ON -DAPACHE_ROOT=/opt/apache2
2626
# or
27-
cmake -B php-build -DAPACHE2HANDLER=ON -DApache_EXECUTABLE=/opt/apache2/bin/apxs
27+
cmake -B php-build -DPHP_SAPI_APACHE2HANDLER=ON -DApache_EXECUTABLE=/opt/apache2/bin/apxs
2828
```
2929
#]=============================================================================]
3030

0 commit comments

Comments
 (0)