updated code to not use ref readonly

Author: Petr Sramek

src/PolylineAlgorithm/Internal/PolylineWriter.cs

@@ -21,7 +21,7 @@ internal ref struct PolylineWriter {
     /// Initializes a new instance of the <see cref="PolylineWriter"/> struct with the specified buffer.
     /// </summary>
     /// <param name="buffer">The buffer to write to.</param>
-    public PolylineWriter(ref readonly Memory<char> buffer) {
+    public PolylineWriter(Memory<char> buffer) {
         _buffer = buffer;
     }
 
@@ -42,7 +42,7 @@ public PolylineWriter(ref readonly Memory<char> buffer) {
     /// <exception cref="InvalidCoordinateException">Thrown when the coordinate is invalid.</exception>
     /// <exception cref="InvalidWriterStateException">Thrown when the writer is in an invalid state.</exception>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void Write(ref readonly Coordinate coordinate) {
+    public void Write(Coordinate coordinate) {
         InvalidCoordinateException.ThrowIfNotValid(coordinate);
         InvalidWriterStateException.ThrowIfCannotWrite(CanWrite, Position, _buffer.Length);
 

src/PolylineAlgorithm/PolylineEncoder.cs

@@ -36,11 +36,11 @@ public Polyline Encode(IEnumerable<Coordinate> coordinates) {
 
         int capacity = count * 12;
         Memory<char> buffer = new char[capacity];
-        PolylineWriter writer = new(in buffer);
+        PolylineWriter writer = new(buffer);
 
         foreach (var coordinate in coordinates) {
             InvalidCoordinateException.ThrowIfNotValid(coordinate);
-            writer.Write(in coordinate);
+            writer.Write(coordinate);
         }
 
         return writer.ToPolyline();

tests/PolylineAlgorithm.Tests/Internal/PolylineWriterTest.cs

@@ -66,7 +66,7 @@ public void Constructor_Valid_Parameter_Ok(int length) {
         int position = 0;
 
         // Act
-        PolylineWriter writer = new(in buffer);
+        PolylineWriter writer = new(buffer);
 
         // Assert
         Assert.AreEqual(canWrite, writer.CanWrite);
@@ -82,13 +82,13 @@ public void Write_Valid_Parameter_Ok() {
         IEnumerable<Coordinate> coordinates = Values.Coordinates.Valid;
         Polyline expected = Polyline.FromString(Values.Polyline.Valid);
         Memory<char> buffer = new char[coordinates.Count() * 12];
-        PolylineWriter writer = new(in buffer);
+        PolylineWriter writer = new(buffer);
         bool canWrite = buffer.Length > expected.Length;
         int position = expected.Length;
 
         // Act
         foreach (var coordinate in coordinates) {
-            writer.Write(in coordinate);
+            writer.Write(coordinate);
         }
 
         // Assert
@@ -111,8 +111,8 @@ public void Write_Invalid_Coordinate_Parameter_Ok((double Latitude, double Longi
         // Act
         static void Write(Coordinate coordinate, int bufferSize) {
             Memory<char> buffer = new char[bufferSize];
-            PolylineWriter writer = new(in buffer);
-            writer.Write(in coordinate);
+            PolylineWriter writer = new(buffer);
+            writer.Write(coordinate);
         }
 
         // Assert
@@ -132,10 +132,10 @@ public void Write_Buffer_Overflow_InvalidWriterStateException_Thrown(int bufferS
         // Act
         static void Write(Coordinate coordinate, int bufferSize) {
             Memory<char> buffer = new char[bufferSize];
-            PolylineWriter writer = new(in buffer);
+            PolylineWriter writer = new(buffer);
 
-            writer.Write(in coordinate);
-            writer.Write(in coordinate);
+            writer.Write(coordinate);
+            writer.Write(coordinate);
         }
 
         // Assert