moved exception initialization and throw to factory method

Author: Petr Sramek

src/PolylineAlgorithm/InvalidCoordinateException.cs

@@ -13,13 +13,17 @@ namespace PolylineAlgorithm;
 /// </summary>
 [SuppressMessage("Design", "CA1032:Implement standard exception constructors", Justification = "Main purpose is to report coordinate that is invalid, thus we have to have only one construtor.")]
 public sealed class InvalidCoordinateException : Exception {
-    public InvalidCoordinateException(Coordinate coordinate, Exception? innerException = null)
-        : base(string.Format(ExceptionMessageResource.CoordinateIsOutOfRangeMessageFormat, coordinate.Latitude, coordinate.Longitude), innerException) {
+    private InvalidCoordinateException(Coordinate coordinate, string message, Exception? innerException = null)
+        : base(message, innerException) {
         Coordinate = coordinate;
     }
 
     /// <summary>
     /// Coordinate that caused the exception.
     /// </summary>
     public Coordinate Coordinate { get; }
-}
+
+    public static void Throw(Coordinate coordinate, Exception? innerException = null) {
+        throw new InvalidCoordinateException(coordinate, string.Format(ExceptionMessageResource.CoordinateIsOutOfRangeMessageFormat, coordinate.Latitude, coordinate.Longitude), innerException);
+    }
+}

src/PolylineAlgorithm/InvalidReaderStateException.cs

@@ -13,16 +13,14 @@ namespace PolylineAlgorithm;
 /// Represents error that is caused by invalid reader state.
 /// </summary>
 [SuppressMessage("Design", "CA1032:Implement standard exception constructors", Justification = "Main purpose is to report position in which failure occurs, thus we have to have only one constructor.")]
-public class InvalidReaderStateException : Exception {
-    public InvalidReaderStateException(int position, int length)
-        : base(GetErrorMessage(position, length)) {
-    }
+public sealed class InvalidReaderStateException(string message)
+    : Exception(message) {
 
-    private static string GetErrorMessage(int readerPosition, int polylineLength) {
+    public static void Throw(int readerPosition, int polylineLength) {
         if (polylineLength == 0) {
-            return ExceptionMessageResource.PolylineStringIsEmptyMessage;
+            throw new InvalidReaderStateException(ExceptionMessageResource.PolylineStringIsEmptyMessage);
         } else {
-            return string.Format(ExceptionMessageResource.UnableToReadPolylineAtPositionMessageFormat, readerPosition, polylineLength);
+            throw new InvalidReaderStateException(string.Format(ExceptionMessageResource.UnableToReadPolylineAtPositionMessageFormat, readerPosition, polylineLength));
         }
     }
 }

src/PolylineAlgorithm/InvalidWriterStateException.cs

@@ -13,16 +13,14 @@ namespace PolylineAlgorithm;
 /// Represents error that is caused by invalid reader state.
 /// </summary>
 [SuppressMessage("Design", "CA1032:Implement standard exception constructors", Justification = "Main purpose is to report position in which failure occurs, thus we have to have only one constructor.")]
-public class InvalidWriterStateException : Exception {
-    public InvalidWriterStateException(int position, int bufferSize)
-        : base(GetErrorMessage(position, bufferSize)) {
-    }
+public sealed class InvalidWriterStateException(string message)
+    : Exception(message) {
 
-    private static string GetErrorMessage(int readerPosition, int bufferSize) {
-        if (bufferSize == 0) {
-            return ExceptionMessageResource.PolylineBufferIsEmptyMessage;
+    public static void Throw(int readerPosition, int polylineLength) {
+        if (polylineLength == 0) {
+            throw new InvalidWriterStateException(ExceptionMessageResource.PolylineBufferIsEmptyMessage);
         } else {
-            return string.Format(ExceptionMessageResource.UnableToWritePolylineBufferAtPositionMessageFormat, readerPosition, bufferSize);
+            throw new InvalidWriterStateException(string.Format(ExceptionMessageResource.UnableToWritePolylineBufferAtPositionMessageFormat, readerPosition, bufferSize));
         }
     }
 }

src/PolylineAlgorithm/PolylineMalformedException.cs

@@ -19,14 +19,17 @@ public sealed class PolylineMalformedException : Exception {
     /// </summary>
     /// <param name="position"></param>
     /// <param name="innerException"></param>
-    public PolylineMalformedException(int position, Exception? innerException = null)
-        : base(string.Format(ExceptionMessageResource.PolylineStringIsMalformedMessage, position),
-               innerException) {
+    private PolylineMalformedException(int position, string message, Exception? innerException = null)
+        : base(message, innerException) {
         Position = position;
     }
 
     /// <summary>
     /// Position in polyline string at which error occurs.
     /// </summary>
     public int Position { get; }
+
+    public static void Throw(int position, Exception? innerException = null) {
+        throw new PolylineMalformedException(position, string.Format(ExceptionMessageResource.PolylineStringIsMalformedMessage, position), innerException);
+    }
 }