interim commit

Author: petesramek

src/PolylineAlgorithm/PolylineEncoder.cs

@@ -42,7 +42,7 @@ public Polyline Encode(IEnumerable<Coordinate> coordinates) {
         int count = GetCount(coordinates);
 
         if (count == 0) {
-            return default;
+            throw new ArgumentException(nameof(coordinates));
         }
 
         CoordinateVariance variance = new();

src/PolylineAlgorithm/PolylineEncoding.cs

@@ -54,7 +54,7 @@ public bool TryReadValue(ref int variance, ref ReadOnlyMemory<char> buffer, ref
     /// <param name="value">The normalized integer value.</param>
     /// <returns>The denormalized double value.</returns>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public double Denormalize(int value) => (double)value / Defaults.Algorithm.Precision;
+    public double Denormalize(int value) => Math.Round((double)value / Defaults.Algorithm.Precision, 5);
 
     /// <summary>
     /// Attempts to write an encoded value to the buffer.

tests/PolylineAlgorithm.Tests/AsyncPolylineDecoderTest.cs

@@ -15,22 +15,22 @@ public class CoordinateTest {
     /// <summary>
     /// Provides test data for the <see cref="Constructor_Valid_Parameters_Ok"/> method.
     /// </summary>
-    public static IEnumerable<object[]> Constructor_Valid_Parameters => new List<object[]> {
-        new object[] { 90, 180 },
-        new object[] { -90, -180 },
-        new object[] { 90, -180 },
-        new object[] { -90, 180 },
-    };
+    public static IEnumerable<object[]> Constructor_Valid_Parameters => [
+        [90, 180],
+        [-90, -180],
+        [90, -180],
+        [-90, 180],
+    ];
 
     /// <summary>
     /// Provides test data for the <see cref="Constructor_Invalid_Parameters_Ok"/> method.
     /// </summary>
-    public static IEnumerable<object[]> Constructor_Invalid_Parameters => new List<object[]> {
-        new object[] { double.MaxValue, double.MaxValue },
-        new object[] { double.MinValue, double.MinValue },
-        new object[] { double.MaxValue, double.MinValue },
-        new object[] { double.MinValue, double.MaxValue },
-    };
+    public static IEnumerable<object[]> Constructor_Invalid_Parameters => [
+        [double.MaxValue, double.MaxValue],
+        [double.MinValue, double.MinValue],
+        [double.MaxValue, double.MinValue],
+        [double.MinValue, double.MaxValue],
+    ];
 
     /// <summary>
     /// Tests the parameterless constructor of the <see cref="Coordinate"/> class.

tests/PolylineAlgorithm.Tests/AsyncPolylineEncoderTest.cs

@@ -173,49 +173,4 @@ public static class MalformedPolylineException {
         /// </summary>
         public static readonly int Position = _random.Next();
     }
-
-    /// <summary>
-    /// Defines default values and objects used for testing invalid coordinate exceptions.
-    /// </summary>
-    public static class InvalidCoordinateException {
-        /// <summary>
-        /// Gets a valid coordinate for testing invalid coordinate exceptions.
-        /// </summary>
-        public static readonly Coordinate Valid = new(_random.NextDouble(), _random.NextDouble());
-
-        /// <summary>
-        /// Gets an invalid coordinate for testing invalid coordinate exceptions.
-        /// </summary>
-        public static readonly Coordinate Invalid = new(double.MinValue, double.MaxValue);
-    }
-
-    /// <summary>
-    /// Defines default values and objects used for testing invalid reader state exceptions.
-    /// </summary>
-    public static class InvalidReaderStateException {
-        /// <summary>
-        /// Gets a random position value for testing invalid reader state exceptions.
-        /// </summary>
-        public static readonly int Position = _random.Next();
-
-        /// <summary>
-        /// Gets a random length value for testing invalid reader state exceptions.
-        /// </summary>
-        public static readonly int Length = Position;
-    }
-
-    /// <summary>
-    /// Defines default values and objects used for testing invalid writer state exceptions.
-    /// </summary>
-    public static class InvalidWriterStateException {
-        /// <summary>
-        /// Gets a random position value for testing invalid writer state exceptions.
-        /// </summary>
-        public static readonly int Position = _random.Next();
-
-        /// <summary>
-        /// Gets a random length value for testing invalid writer state exceptions.
-        /// </summary>
-        public static readonly int Length = Position;
-    }
 }

tests/PolylineAlgorithm.Tests/CoordinateTest.cs

@@ -21,10 +21,11 @@ public void Throw_Method_Invalid_Coordinate_Parameter_PolylineMalformedException
         var position = Values.MalformedPolylineException.Position;
 
         // Act
-        static void Throw(int position) => InvalidPolylineException.Throw(position);
+        static void ThrowAt(int position) => InvalidPolylineException.Throw(position);
 
         // Assert
-        var exception = Assert.ThrowsExactly<InvalidPolylineException>(() => Throw(position));
+        var exception = Assert.ThrowsExactly<InvalidPolylineException>(() => ThrowAt(position));
+
         Assert.IsFalse(string.IsNullOrWhiteSpace(exception.Message));
     }
 }

tests/PolylineAlgorithm.Tests/Data/Values.cs

@@ -15,6 +15,8 @@ namespace PolylineAlgorithm.Tests;
 /// </summary>
 [TestClass]
 public class PolylineDecoderTest {
+    public static IEnumerable<object[]> CoordinateCount => [[1], [10], [100], [1_000], [10_000], [100_000], [1_000_000]];
+    
     /// <summary>
     /// The instance of the <see cref="PolylineDecoder"/> used for testing.
     /// </summary>
@@ -55,7 +57,8 @@ public void Decode_Empty_Input_ThrowsException() {
     /// </summary>
     /// <remarks>Expected result to equal <see cref="Values.Coordinates.Valid"/>.</remarks>
     [TestMethod]
-    public void Decode_Valid_Input_Ok() {
+    [DynamicData(nameof(CoordinateCount))]
+    public void Decode_Valid_Input_Ok(int count) {
         // Arrange
         IEnumerable<Coordinate> expected = RandomValueProvider.GetCoordinates(1);
         string value = RandomValueProvider.GetPolyline(1).ToString();

tests/PolylineAlgorithm.Tests/InvalidPolylineExceptionTest.cs

@@ -40,19 +40,19 @@ void EncodeNullCoordinates() {
     /// <summary>
     /// Tests the <see cref="PolylineEncoder.Encode(IEnumerable{Coordinate})"/> method with an empty input, expecting an <see cref="ArgumentException"/>.
     /// </summary>
-    //[TestMethod]
-    //public void Encode_EmptyInput_ThrowsException() {
-    //    // Arrange
-    //    IEnumerable<Coordinate> empty = Values.Coordinates.Empty;
+    [TestMethod]
+    public void Encode_EmptyInput_ThrowsException() {
+        // Arrange
+        IEnumerable<Coordinate> empty = Values.Coordinates.Empty;
 
-    //    // Act
-    //    void EncodeEmptyCoordinates() {
-    //        Encoder.Encode(empty);
-    //    }
+        // Act
+        void EncodeEmptyCoordinates() {
+            Encoder.Encode(empty);
+        }
 
-    //    // Assert
-    //    Assert.ThrowsExactly<ArgumentException>(() => EncodeEmptyCoordinates());
-    //}
+        // Assert
+        Assert.ThrowsExactly<ArgumentException>(() => EncodeEmptyCoordinates());
+    }
 
     /// <summary>
     /// Tests the <see cref="PolylineEncoder.Encode(IEnumerable{Coordinate})"/> method with a valid input.

tests/PolylineAlgorithm.Tests/PolylineDecoderTest.cs

@@ -15,10 +15,10 @@ public class CoordinateRangeTest {
     /// <summary>
     /// Provides test data for the <see cref="Constructor_Valid_Parameters_Ok"/> method.
     /// </summary>
-    public static IEnumerable<object[]> Constructor_Valid_Parameters => new List<object[]> {
-        new object[] { -90, 90 },
-        new object[] { -180, 180 },
-    };
+    public static IEnumerable<object[]> Constructor_Valid_Parameters => [
+        [-90, 90],
+        [-180, 180],
+    ];
 
     /// <summary>
     /// Tests the parameterless constructor of the <see cref="CoordinateRange"/> class.