From 684ea993dda9ee0ad5aaca9e19a325594c0a1423 Mon Sep 17 00:00:00 2001 From: Jan Brasna <1784648+janbrasna@users.noreply.github.com> Date: Sun, 27 Apr 2025 00:43:14 +0200 Subject: [PATCH 1/3] Format deployment error output --- app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app.py b/app.py index 19a3098..1d9311a 100755 --- a/app.py +++ b/app.py @@ -151,7 +151,7 @@ def post(self): sha = extract_sha(content) if not sha: # doesn't appear to be a git sha - error = "Doesn't look like a sha\n (%s) on %s" % (content, each["url"]) + error = "Doesn't look like a sha:\n (ā€œ%sā€)\n — on: %s" % (content, each["url"]) return make_response(jsonify({"error": error})) deployments.append({"name": name, "sha": sha, "bugs": [], "url": url}) From 25a1515f1e2c39a100e478726245dbebefb92921 Mon Sep 17 00:00:00 2001 From: Jan Brasna <1784648+janbrasna@users.noreply.github.com> Date: Sun, 27 Apr 2025 01:19:52 +0200 Subject: [PATCH 2/3] =?UTF-8?q?Add=2030s=20timeout=20for=20deployment=20sh?= =?UTF-8?q?as=20&=C2=A0tags?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/DeployPage.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/DeployPage.js b/src/DeployPage.js index 7061dfe..1d29d48 100644 --- a/src/DeployPage.js +++ b/src/DeployPage.js @@ -82,7 +82,11 @@ class DeployPage extends React.Component { this.startLoad('shas'); try { const res = await ky - .post('/shas', { json: { owner, repo, deployments } }) + .post('/shas', { + json: { owner, repo, deployments }, + retries: 3, + timeout: 30000, + }) .json(); if (res.error) { @@ -94,7 +98,7 @@ class DeployPage extends React.Component { }); } } catch (error) { - console.warn('Error fetching shas!'); + console.warn('Error fetching deployment /shas or tags!'); console.error(error); this.setState({ error }); } finally { @@ -175,7 +179,7 @@ class DeployPage extends React.Component { ) : !deployInfo ? (
- No Deployment info could be found + Deployment info could not be retrieved
) : ( <> From 8d603d21d76eb8b6b9bc9df776dabb189e569238 Mon Sep 17 00:00:00 2001 From: Jan Brasna <1784648+janbrasna@users.noreply.github.com> Date: Sun, 27 Apr 2025 23:51:14 +0200 Subject: [PATCH 3/3] Add disjunct SHA info to error message --- src/DeployPage.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/DeployPage.js b/src/DeployPage.js index 1d29d48..82ce0e9 100644 --- a/src/DeployPage.js +++ b/src/DeployPage.js @@ -355,7 +355,8 @@ class DeployTable extends React.Component { ) : (
Even after comparing the last {commits.length} commits, a common - denominator could not be found! The difference is just too big. + denominator could not be found! The difference is just too big, + or the deployment SHA does not come from the default branch.
Use the links below to compare directly on GitHub.