Fixed issue Blizzard#306.

Cloak now works properly

Author: peter-cudmore

include/sc2api/sc2_unit.h

@@ -101,8 +101,8 @@ class Unit {
         CloakedDetected = 2,
         //! No cloaking.
         NotCloaked = 3,
-        //! Could not determine cloaking state.
-        Unknown = 4
+        //! Cloaked ally, though not sure why this is necessary.
+        CloakedAllied = 4
     };
 
     //! If the unit is shown on screen or not.

src/sc2api/sc2_proto_to_pods.cc

@@ -153,6 +153,7 @@ bool Convert(const SC2APIProtocol::CloakState& cloak_proto, Unit::CloakState& cl
         case SC2APIProtocol::CloakState::Cloaked:         cloak = Unit::Cloaked; return true;
         case SC2APIProtocol::CloakState::CloakedDetected: cloak = Unit::CloakedDetected; return true;
         case SC2APIProtocol::CloakState::NotCloaked:      cloak = Unit::NotCloaked; return true;
+        case SC2APIProtocol::CloakState::CloakedAllied:    cloak = Unit::CloakedAllied; return true;
     }
     return false;
 }
@@ -190,7 +191,7 @@ bool Convert(const ObservationRawPtr& observation_raw, UnitPool& unit_pool, uint
             }
         }
         else {
-            unit->cloak = Unit::Unknown;
+            unit->cloak = Unit::CloakedUnknown;
         }
 
         unit->detect_range = observation_unit.detect_range();

tests/test_unit_command.cc

@@ -39,7 +39,7 @@ namespace sc2 {
                 ReportError("Could not find the test unit.");
             }
 
-            if (test_unit_ && test_unit_->cloak != Unit::CloakState::Cloaked) {
+            if (test_unit_ && test_unit_->cloak != Unit::CloakState::CloakedAllied) {
                 ReportError("Unit is not cloaked as expected.");
             }
 
@@ -1255,9 +1255,6 @@ namespace sc2 {
             if (target_units.front()->is_blip != true) {
                 ReportError("Target unit is not a blip.");
             }
-            if (target_units.front()->cloak != Unit::CloakState::Unknown) {
-                ReportError("Target unit cloak state is incorrect.");
-            }
             if (target_units.front()->display_type != Unit::DisplayType::Hidden) {
                 ReportError("Target unit is not hidden.");
             }