Remove the force_element_to_content its unneeded

The force_element_to_content was added due to the way that xmlsec1
was believed to behave.  An example at
https://users.dcc.uchile.cl/~pcamacho/tutorial/web/xmlsec/xmlsec.html
set the --node-xpath /PayInfo/CreditCard/Number/text() and used
http://www.w3.org/2001/04/xmlenc#Element for the template.

Instead it should have been --node-xpath /PayInfo/CreditCard/Number/text()
withe the http://www.w3.org/2001/04/xmlenc#Content in the template.  That
works fine.

Author: timlegge

lib/XML/Enc.pm

@@ -28,7 +28,6 @@ XML::Enc - XML Encryption
                                 {
                                     key                         => 't/sign-private.pem',
                                     no_xml_declaration          => 1,
-                                    force_element_to_content    => 0,
                                 },
                             );
     $decrypted = $enc->decrypt($xml);
@@ -113,14 +112,6 @@ Used in encryption.  Optional.  Default method: rsa-1_5
 
 =back
 
-=item B<force_element_to_content>
-
-Used for decryption to treat an Element EncryptedData type as Content
-if the decrypted data is not XML.  xmlsec appears to have a bug where it
-uses the Element EncryptedData type in order to encrypt what is actually Content.
-Strangely it appears to have no issue decrypting the data if the Type is changed
-to Content
-
 =back
 
 =cut
@@ -150,10 +141,6 @@ sub new {
     my $key_method = exists($params->{'key_transport'}) ? $params->{'key_transport'} : 'rsa-1_5';
     $self->{'key_transport'} = $self->_setKeyEncryptionMethod($key_method);
 
-    my $force_element_to_content = exists($params->{'force_element_to_content'}) ?
-                $params->{'force_element_to_content'} : 0;
-    $self->{'force_element_to_content'} = $force_element_to_content;
-
     return $self;
 }
 
@@ -215,15 +202,6 @@ sub decrypt {
             if (defined $newnode) {
                 $encryptednode->addSibling($newnode);
                 $encryptednode->unbindNode();
-                #print $newnode->serialize();
-            } else {
-                if ($self->{force_element_to_content}) {
-                    # Invalid XML simply add it to the node
-                    $data =~ s/[\/<>]//mg; # Remove any stray XML characters
-                    my $parent = $encryptednode->parentNode;
-                    $parent->removeChildNodes;
-                    $parent->appendText($data);
-                }
             }
         } else {
             # http://www.w3.org/2001/04/xmlenc#Content

t/07-decrypt-xmlsec.t

@@ -68,7 +68,7 @@ XML Security Library example: Original XML
 -->
 <EncryptedData
   xmlns="http://www.w3.org/2001/04/xmlenc#"
-  Type="http://www.w3.org/2001/04/xmlenc#Element">
+  Type="http://www.w3.org/2001/04/xmlenc#Content">
  <EncryptionMethod Algorithm=
    "http://www.w3.org/2001/04/xmlenc#$dm"/>
  <KeyInfo xmlns="http://www.w3.org/2000/09/xmldsig#">
@@ -124,15 +124,14 @@ SKIP: {
             print CONTENT $content_tmpl;
             close CONTENT;
 
-            $encrypt_response = `xmlsec1 encrypt --pubkey-cert-pem t/sign-certonly.pem   --session-key $sesskey{$dm} --xml-data plaintext.xml --output encrypted-content.xml --node-xpath '/PayInfo/CreditCard/Number/text()' content-template.xml 2>&1`;
+            $encrypt_response = `xmlsec1 encrypt --pubkey-cert-pem t/sign-certonly.pem   --session-key $sesskey{$dm} --xml-data plaintext.xml --output encrypted-content.xml --node-xpath '/PayInfo/CreditCard/Number' content-template.xml 2>&1`;
 
             $encrypted = read_text('encrypted-content.xml');
 
             unlink 'plaintext.xml';
             unlink 'content-template.xml';
             unlink 'encrypted-content.xml';
 
-            $decrypter->{force_element_to_content} = 1;
             # Decrypt using XML::Enc
             ok($decrypter->decrypt($encrypted) =~ /1076 2478 0678 5589/,
                     "Decrypted $dm $km xmlsec1 Content");