Merge pull request #5 from perl-net-saml2/misc-updates

Misc updates

Author: timlegge

Makefile.PL

@@ -70,8 +70,8 @@ test_requires 'Test::Exception';
 
 resources
      license     => "http://dev.perl.org/licenses",
-     bugtracker  => "http://rt.cpan.org/NoAuth/Bugs.html?Dist=Crypt-OpenSSL-Verify",
-     repository  => "http://github.com/timlegge/perl-Crypt-OpenSSL-Verify";
+     bugtracker  => "https://github.com/perl-Net-SAML2/perl-Crypt-OpenSSL-Verify/issues",
+     repository  => "https://github.com/perl-Net-SAML2/perl-Crypt-OpenSSL-Verify";
 
 author_tests 't/author';
 

t/02-verify-good-cert.t

@@ -22,9 +22,9 @@ $v = Crypt::OpenSSL::Verify->new(
         noCAfile => 0,
     }
 );
-ok($v);
+isa_ok($v, 'Crypt::OpenSSL::Verify');
 
 $ret = $v->verify($cert);
-ok($ret);
+ok($ret, "t/cert.pem verified");
 
 done_testing;

t/03-verify-bad-cert.t

@@ -3,7 +3,7 @@ use Crypt::OpenSSL::Verify;
 use Crypt::OpenSSL::X509;
 
 my $v = Crypt::OpenSSL::Verify->new('t/cacert.pem');
-ok($v);
+isa_ok($v, 'Crypt::OpenSSL::Verify');
 
 my $text =<<CERT;
 -----BEGIN CERTIFICATE-----
@@ -33,7 +33,7 @@ hvcNAQEFBQADgYEACgl1sxEPVgsK8sTYCF+OhTIrZ5fhhmCf5kunCWvLeMcTJtNP
 CERT
 
 my $cert = Crypt::OpenSSL::X509->new_from_string($text);
-ok($cert);
+isa_ok($cert, 'Crypt::OpenSSL::X509');
 
 my $ret;
 eval {
@@ -49,7 +49,7 @@ $v = Crypt::OpenSSL::Verify->new(
     noCAfile => 0,
 }
     );
-ok($v);
+isa_ok($v, 'Crypt::OpenSSL::Verify');
 
 $ret = undef;
 eval {

t/05-verify-not-a-cert.t

@@ -3,7 +3,7 @@ use Crypt::OpenSSL::Verify;
 use Crypt::OpenSSL::X509;
 
 my $v = Crypt::OpenSSL::Verify->new('t/cacert.pem');
-ok($v);
+isa_ok($v, 'Crypt::OpenSSL::Verify');
 
 my $ret;
 eval {
@@ -20,7 +20,7 @@ $v = Crypt::OpenSSL::Verify->new(
         noCAfile => 0,
     }
 );
-ok($v);
+isa_ok($v, 'Crypt::OpenSSL::Verify');
 
 $ret = undef;
 

t/06-verify-expired-cert.t

@@ -5,7 +5,7 @@ use File::Slurp qw(read_file);
 use Test::Exception;
 
 my $v = Crypt::OpenSSL::Verify->new('t/cacert.pem', { strict_certs => 0 });
-ok($v);
+isa_ok($v, 'Crypt::OpenSSL::Verify');
 
 my $text = read_file('t/cert-expired.pem');
 like($text, qr/BhMCQ0ExFjAUBgNVBAgMDU5ldyBC/);
@@ -27,7 +27,7 @@ $v = Crypt::OpenSSL::Verify->new(
         strict_certs => 0,
     }
 );
-ok($v);
+isa_ok($v, 'Crypt::OpenSSL::Verify');
 
 lives_ok(
     sub {
@@ -43,6 +43,7 @@ $v = Crypt::OpenSSL::Verify->new(
         strict_certs => 1
     }
 );
+isa_ok($v, 'Crypt::OpenSSL::Verify');
 
 throws_ok(
     sub {