Skip to content

Commit 583af44

Browse files
committed
More test standardization
1 parent 0a1f804 commit 583af44

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

t/02-verify-good-cert.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ $v = Crypt::OpenSSL::Verify->new(
2222
noCAfile => 0,
2323
}
2424
);
25-
ok($v);
25+
isa_ok($v, 'Crypt::OpenSSL::Verify');
2626

2727
$ret = $v->verify($cert);
28-
ok($ret);
28+
ok($ret, "t/cert.pem verified");
2929

3030
done_testing;

t/03-verify-bad-cert.t

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use Crypt::OpenSSL::Verify;
33
use Crypt::OpenSSL::X509;
44

55
my $v = Crypt::OpenSSL::Verify->new('t/cacert.pem');
6-
ok($v);
6+
isa_ok($v, 'Crypt::OpenSSL::Verify');
77

88
my $text =<<CERT;
99
-----BEGIN CERTIFICATE-----
@@ -33,7 +33,7 @@ hvcNAQEFBQADgYEACgl1sxEPVgsK8sTYCF+OhTIrZ5fhhmCf5kunCWvLeMcTJtNP
3333
CERT
3434

3535
my $cert = Crypt::OpenSSL::X509->new_from_string($text);
36-
ok($cert);
36+
isa_ok($cert, 'Crypt::OpenSSL::X509');
3737

3838
my $ret;
3939
eval {
@@ -49,7 +49,7 @@ $v = Crypt::OpenSSL::Verify->new(
4949
noCAfile => 0,
5050
}
5151
);
52-
ok($v);
52+
isa_ok($v, 'Crypt::OpenSSL::Verify');
5353

5454
$ret = undef;
5555
eval {

t/05-verify-not-a-cert.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use Crypt::OpenSSL::Verify;
33
use Crypt::OpenSSL::X509;
44

55
my $v = Crypt::OpenSSL::Verify->new('t/cacert.pem');
6-
ok($v);
6+
isa_ok($v, 'Crypt::OpenSSL::Verify');
77

88
my $ret;
99
eval {
@@ -20,7 +20,7 @@ $v = Crypt::OpenSSL::Verify->new(
2020
noCAfile => 0,
2121
}
2222
);
23-
ok($v);
23+
isa_ok($v, 'Crypt::OpenSSL::Verify');
2424

2525
$ret = undef;
2626

t/06-verify-expired-cert.t

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use File::Slurp qw(read_file);
55
use Test::Exception;
66

77
my $v = Crypt::OpenSSL::Verify->new('t/cacert.pem', { strict_certs => 0 });
8-
ok($v);
8+
isa_ok($v, 'Crypt::OpenSSL::Verify');
99

1010
my $text = read_file('t/cert-expired.pem');
1111
like($text, qr/BhMCQ0ExFjAUBgNVBAgMDU5ldyBC/);
@@ -27,7 +27,7 @@ $v = Crypt::OpenSSL::Verify->new(
2727
strict_certs => 0,
2828
}
2929
);
30-
ok($v);
30+
isa_ok($v, 'Crypt::OpenSSL::Verify');
3131

3232
lives_ok(
3333
sub {
@@ -43,6 +43,7 @@ $v = Crypt::OpenSSL::Verify->new(
4343
strict_certs => 1
4444
}
4545
);
46+
isa_ok($v, 'Crypt::OpenSSL::Verify');
4647

4748
throws_ok(
4849
sub {

0 commit comments

Comments
 (0)