Skip to content

Commit 3a09798

Browse files
committed
Remove undocumented sigopts from sign()
Fix typo in pod
1 parent 4295e6b commit 3a09798

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

SignCSR.xs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -552,13 +552,12 @@ IV set_days(self, IV days)
552552

553553
RETVAL
554554

555-
SV * sign(self, request_SV, sigopts)
555+
SV * sign(self, request_SV)
556556
HV * self;
557557
SV * request_SV;
558558

559559
PREINIT:
560560
EVP_MD_CTX *mctx;
561-
STACK_OF(OPENSSL_STRING) *sigopts = NULL;
562561

563562
CODE:
564563

@@ -752,9 +751,9 @@ SV * sign(self, request_SV, sigopts)
752751

753752
// Sign the new certificate
754753
#if OPENSSL_API_COMPAT >= 30101
755-
if (mctx != NULL && do_sign_init(mctx, private_key, digestname, sigopts) > 0)
754+
if (mctx != NULL && do_sign_init(mctx, private_key, digestname, NULL) > 0)
756755
#else
757-
if (mctx != NULL && do_sign_init(mctx, private_key, md, sigopts) > 0)
756+
if (mctx != NULL && do_sign_init(mctx, private_key, md, NULL) > 0)
758757
#endif
759758
rv = (X509_sign_ctx(x, mctx) > 0);
760759

lib/Crypt/OpenSSL/SignCSR.pm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,14 @@ Crypt::OpenSSL::SignCSR - Sign a Certificate Signing Request in XS.
4343
format => $format, # Output format "text" or "pem" (default)
4444
});
4545
my $cert = $signer->sign(
46-
$request, # CRS in PEM format
46+
$request, # CSR in PEM format
4747
);
4848
4949
my $ret = $signer->set_days(3650);
5050
my $ret = $signer->set_format("text");
5151
my $ret = $signer->set_days("SHA512");
5252
53-
$cert = $signer->sign( $request ); # CRS in PEM format
53+
$cert = $signer->sign( $request ); # CSR in PEM format
5454
5555
=head1 DESCRIPTION
5656

t/002-create-cert-from-csr.t

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ bczN2A==
7272
-----END CERTIFICATE REQUEST-----
7373
CERTREQUEST
7474

75-
my $cert = $signer->sign($request, '');
75+
my $cert = $signer->sign($request);
7676

7777
my $certfile = tempfile();
7878
my ($certfh, $certfilename) = tempfile();

t/003-openssl-crypt-pkcs10.t

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ my $signer = Crypt::OpenSSL::SignCSR->new(
7272

7373
isa_ok($signer, "Crypt::OpenSSL::SignCSR");
7474

75-
my $cert = $signer->sign($request, '');
75+
my $cert = $signer->sign($request);
7676

7777
my $certfile = tempfile();
7878
my ($certfh, $certfilename) = tempfile();

0 commit comments

Comments
 (0)