Fixes #111030 - Memory leak in parse_name

timlegge · timlegge · commit bc9707b11ca8 · 2023-08-05T14:06:51.000-03:00
diff --git a/PKCS10.xs b/PKCS10.xs
@@ -64,7 +64,7 @@ X509_NAME *parse_name(char *subject, long chtype, int multirdn)
 
 	X509_NAME *n = NULL;
 
-	if (!buf || !ne_types || !ne_values)
+	if (!buf || !ne_types || !ne_values || !mval)
 		{
 		croak("malloc error\n");
 		goto error;
@@ -173,6 +173,8 @@ X509_NAME *parse_name(char *subject, long chtype, int multirdn)
 		OPENSSL_free(ne_types);
 	if (buf)
 		OPENSSL_free(buf);
+    if (mval)
+	    OPENSSL_free(mval);
 	return NULL;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ X509_NAME parse_name(char subject, long chtype, int multirdn)`
`64`	`64`
`65`	`65`	`X509_NAME *n = NULL;`
`66`	`66`
`67`		`- if (!buf \|\| !ne_types \|\| !ne_values)`
	`67`	`+ if (!buf \|\| !ne_types \|\| !ne_values \|\| !mval)`
`68`	`68`	`{`
`69`	`69`	`croak("malloc error\n");`
`70`	`70`	`goto error;`
`@@ -173,6 +173,8 @@ X509_NAME parse_name(char subject, long chtype, int multirdn)`
`173`	`173`	`OPENSSL_free(ne_types);`
`174`	`174`	`if (buf)`
`175`	`175`	`OPENSSL_free(buf);`
	`176`	`+ if (mval)`
	`177`	`+ OPENSSL_free(mval);`
`176`	`178`	`return NULL;`
`177`	`179`	`}`
`178`	`180`