Fix linting issues

Author: ileitch

Sources/BUILD.bazel

@@ -104,6 +104,7 @@ swift_library(
     srcs = [
         "Shared/Benchmark.swift",
         "Shared/Constants.swift",
+        "Shared/JobPool.swift",
         "Shared/PeripheryError.swift",
         "Shared/ProjectKind.swift",
         "Shared/PropertyTypeSanitizer.swift",
@@ -194,7 +195,6 @@ swift_library(
         "Indexer/Indexer.swift",
         "Indexer/InfoPlistIndexer.swift",
         "Indexer/InfoPlistParser.swift",
-        "Indexer/JobPool.swift",
         "Indexer/SourceFileCollector.swift",
         "Indexer/SwiftIndexer.swift",
         "Indexer/XCDataModelIndexer.swift",

Sources/Configuration/Configuration.swift

@@ -140,7 +140,6 @@ public final class Configuration {
     @Setting(key: "bazel_index_store", defaultValue: nil)
     public var bazelIndexStore: FilePath?
 
-
     // Non user facing.
     public var guidedSetup: Bool = false
     public var projectRoot: FilePath = .init()
@@ -212,7 +211,7 @@ public final class Configuration {
         $externalTestCaseClasses, $verbose, $quiet, $disableUpdateCheck, $strict, $indexStorePath, $skipBuild,
         $skipSchemesValidation, $cleanBuild, $buildArguments, $xcodeListArguments, $relativeResults, $jsonPackageManifestPath,
         $retainCodableProperties, $retainEncodableProperties, $baseline, $writeBaseline, $writeResults, $genericProjectConfig,
-        $bazel, $bazelFilter, $bazelIndexStore
+        $bazel, $bazelFilter, $bazelIndexStore,
     ]
 
     private func buildFilenameMatchers(with patterns: [String]) -> [FilenameMatcher] {

Sources/Indexer/InfoPlistIndexer.swift

@@ -8,6 +8,7 @@ final class InfoPlistIndexer: Indexer {
     enum PlistError: Error {
         case failedToParse(path: FilePath, underlyingError: Error)
     }
+
     private let infoPlistFiles: Set<FilePath>
     private let graph: SynchronizedSourceGraph
     private let logger: ContextualLogger

Sources/Indexer/SourceFileCollector.swift

@@ -1,10 +1,10 @@
 import Configuration
 import Foundation
 import Logger
+import Shared
 import SourceGraph
 import SwiftIndexStore
 import SystemPackage
-import Shared
 
 public struct SourceFileCollector {
     private let indexStorePaths: Set<FilePath>

Sources/Indexer/XCDataModelIndexer.swift

@@ -8,6 +8,7 @@ final class XCDataModelIndexer: Indexer {
     enum XCDataModelError: Error {
         case failedToParse(path: FilePath, underlyingError: Error)
     }
+
     private let files: Set<FilePath>
     private let graph: SynchronizedSourceGraph
     private let logger: ContextualLogger

Sources/Indexer/XibIndexer.swift

@@ -8,6 +8,7 @@ final class XibIndexer: Indexer {
     enum XibError: Error {
         case failedToParse(path: FilePath, underlyingError: Error)
     }
+
     private let xibFiles: Set<FilePath>
     private let graph: SynchronizedSourceGraph
     private let logger: ContextualLogger

Sources/SourceGraph/Mutators/ProtocolConformanceReferenceBuilder.swift

@@ -75,9 +75,9 @@ final class ProtocolConformanceReferenceBuilder: SourceGraphMutator {
             return result
         })
         // Perform mutations on the graph based on the calculated references
-        newReferences.forEach {
-            if let parent = $0.parent {
-                graph.add($0, from: parent)
+        for newReference in newReferences {
+            if let parent = newReference.parent {
+                graph.add(newReference, from: parent)
             }
         }