Provide more verbose error information when failing to index plists, xcdatamodels, and xibs (#981)

Author: amorde

Sources/Indexer/InfoPlistIndexer.swift

@@ -5,6 +5,9 @@ import SourceGraph
 import SystemPackage
 
 final class InfoPlistIndexer: Indexer {
+    enum PlistError: Error {
+        case failedToParse(path: FilePath, underlyingError: Error)
+    }
     private let infoPlistFiles: Set<FilePath>
     private let graph: SynchronizedSourceGraph
     private let logger: ContextualLogger
@@ -24,9 +27,13 @@ final class InfoPlistIndexer: Indexer {
             guard let self else { return }
 
             let elapsed = try Benchmark.measure {
-                try InfoPlistParser(path: path)
-                    .parse()
-                    .forEach { self.graph.add($0) }
+                do {
+                    try InfoPlistParser(path: path)
+                        .parse()
+                        .forEach { self.graph.add($0) }
+                } catch {
+                    throw PlistError.failedToParse(path: path, underlyingError: error)
+                }
             }
 
             logger.debug("\(path.string) (\(elapsed)s)")

Sources/Indexer/XCDataModelIndexer.swift

@@ -5,6 +5,9 @@ import SourceGraph
 import SystemPackage
 
 final class XCDataModelIndexer: Indexer {
+    enum XCDataModelError: Error {
+        case failedToParse(path: FilePath, underlyingError: Error)
+    }
     private let files: Set<FilePath>
     private let graph: SynchronizedSourceGraph
     private let logger: ContextualLogger
@@ -24,9 +27,13 @@ final class XCDataModelIndexer: Indexer {
             guard let self else { return }
 
             let elapsed = try Benchmark.measure {
-                try XCDataModelParser(path: path)
-                    .parse()
-                    .forEach { self.graph.add($0) }
+                do {
+                    try XCDataModelParser(path: path)
+                        .parse()
+                        .forEach { self.graph.add($0) }
+                } catch {
+                    throw XCDataModelError.failedToParse(path: path, underlyingError: error)
+                }
             }
 
             logger.debug("\(path.string) (\(elapsed)s)")

Sources/Indexer/XibIndexer.swift

@@ -5,6 +5,9 @@ import SourceGraph
 import SystemPackage
 
 final class XibIndexer: Indexer {
+    enum XibError: Error {
+        case failedToParse(path: FilePath, underlyingError: Error)
+    }
     private let xibFiles: Set<FilePath>
     private let graph: SynchronizedSourceGraph
     private let logger: ContextualLogger
@@ -24,9 +27,13 @@ final class XibIndexer: Indexer {
             guard let self else { return }
 
             let elapsed = try Benchmark.measure {
-                try XibParser(path: xibPath)
-                    .parse()
-                    .forEach { self.graph.add($0) }
+                do {
+                    try XibParser(path: xibPath)
+                        .parse()
+                        .forEach { self.graph.add($0) }
+                } catch {
+                    throw XibError.failedToParse(path: xibPath, underlyingError: error)
+                }
             }
 
             logger.debug("\(xibPath.string) (\(elapsed)s)")