PMM-14431 Remove defer from cursor.

JiriCtvrtka · JiriCtvrtka · commit 6f6c101e9716 · 2025-11-25T10:22:03.000+01:00
diff --git a/exporter/metrics.go b/exporter/metrics.go
@@ -322,7 +322,6 @@ func GetAllIndexesForCollections(ctx context.Context, client *mongo.Client, coll
 		if err != nil {
 			continue // skip collections where indexes cannot be listed (e.g., views, system collections)
 		}
-		defer cursor.Close(ctx) //nolint:errcheck
 
 		for cursor.Next(ctx) {
 			var indexDoc struct {
@@ -333,6 +332,7 @@ func GetAllIndexesForCollections(ctx context.Context, client *mongo.Client, coll
 			}
 			indexNames = append(indexNames, indexDoc.Name)
 		}
+		cursor.Close(ctx) //nolint:errcheck
 	}
 
 	return indexNames, nil

Original file line number	Diff line number	Diff line change
`@@ -322,7 +322,6 @@ func GetAllIndexesForCollections(ctx context.Context, client *mongo.Client, coll`
`322`	`322`	`if err != nil {`
`323`	`323`	`continue // skip collections where indexes cannot be listed (e.g., views, system collections)`
`324`	`324`	`}`
`325`		`- defer cursor.Close(ctx) //nolint:errcheck`
`326`	`325`
`327`	`326`	`for cursor.Next(ctx) {`
`328`	`327`	`var indexDoc struct {`
`@@ -333,6 +332,7 @@ func GetAllIndexesForCollections(ctx context.Context, client *mongo.Client, coll`
`333`	`332`	`}`
`334`	`333`	`indexNames = append(indexNames, indexDoc.Name)`
`335`	`334`	`}`
	`335`	`+ cursor.Close(ctx) //nolint:errcheck`
`336`	`336`	`}`
`337`	`337`
`338`	`338`	`return indexNames, nil`