PMM-14431 Lint (unused error).

Author: JiriCtvrtka

exporter/collstats_collector.go

@@ -85,12 +85,7 @@ func (d *collstatsCollector) collect(ch chan<- prometheus.Metric) {
 		}
 	}
 
-	reservedNames, err := GetAllIndexesForCollections(d.ctx, client, collections)
-	if err != nil {
-		logger.Error("cannot get all indexes for collections", "error", err.Error())
-		return
-	}
-
+	reservedNames := GetAllIndexesForCollections(d.ctx, client, collections)
 	for _, dbCollection := range collections {
 		parts := strings.Split(dbCollection, ".")
 		if len(parts) < 2 { //nolint:gomnd

exporter/indexstats_collector.go

@@ -85,12 +85,7 @@ func (d *indexstatsCollector) collect(ch chan<- prometheus.Metric) {
 		}
 	}
 
-	reservedNames, err := GetAllIndexesForCollections(d.ctx, client, collections)
-	if err != nil {
-		logger.Error("cannot get all indexes for collections", "error", err.Error())
-		return
-	}
-
+	reservedNames := GetAllIndexesForCollections(d.ctx, client, collections)
 	for _, dbCollection := range collections {
 		parts := strings.Split(dbCollection, ".")
 		if len(parts) < 2 { //nolint:gomnd

exporter/metrics.go

@@ -307,7 +307,7 @@ func metricHelp(prefix, name string) string {
 }
 
 // GetAllIndexesForCollections returns all index names for the given list of "db.collection" strings.
-func GetAllIndexesForCollections(ctx context.Context, client *mongo.Client, collections []string) ([]string, error) {
+func GetAllIndexesForCollections(ctx context.Context, client *mongo.Client, collections []string) []string {
 	var indexNames []string
 	for _, dbCollection := range collections {
 		parts := strings.SplitN(dbCollection, ".", 2) //nolint:mnd
@@ -335,7 +335,7 @@ func GetAllIndexesForCollections(ctx context.Context, client *mongo.Client, coll
 		cursor.Close(ctx) //nolint:errcheck
 	}
 
-	return indexNames, nil
+	return indexNames
 }
 
 func makeMetrics(reservedNames []string, prefix string, m bson.M, labels map[string]string, compatibleMode bool) []prometheus.Metric {

exporter/shards_collector.go

@@ -93,12 +93,7 @@ func (d *shardsCollector) collect(ch chan<- prometheus.Metric) {
 			}
 		}
 	}
-	reservedNames, err := GetAllIndexesForCollections(d.ctx, client, collections)
-	if err != nil {
-		logger.Error("cannot get all indexes for collections", "error", err.Error())
-		return
-	}
-
+	reservedNames := GetAllIndexesForCollections(d.ctx, client, collections)
 	for _, database := range databaseNames {
 		collections := d.getCollectionsForDBName(database)
 		for _, row := range collections {

exporter/top_collector.go

@@ -144,12 +144,7 @@ func (d *topCollector) collect(ch chan<- prometheus.Metric) {
 		_, coll := splitNamespace(namespace)
 		collections = append(collections, coll)
 	}
-	reservedNames, err := GetAllIndexesForCollections(d.ctx, client, collections)
-	if err != nil {
-		logger.Error("cannot get all indexes for collections", "error", err.Error())
-		return
-	}
-
+	reservedNames := GetAllIndexesForCollections(d.ctx, client, collections)
 	for namespace, metrics := range totals {
 		labels := d.topologyInfo.baseLabels()
 		db, coll := splitNamespace(namespace)