Skip to content

Conversation

@Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Feb 1, 2022

pass appID to node notifier in release mode (assuming release has updated binaries from #600)

Fix #479 (see my comment there for more info about upstream pr's that are almost one year old)

old behavior:
old behavior

new behavior:
new behavior

The problem was that setting an appID (which makes the icon and appName show up) would make the buttons not work (returning undefined instead of index of clicked button)
This was caused because of a problem in a dependency of a dependency (node-notifier->snoretoast)
and the pr with the fix has still yet to be merged many months later, so we now use a custom compiled snoretoast that include said fix

package.json changes

  • taskbar-mediacontrol plugin added only to windows distributions
  • touchbar plugin added only to macOS distributions

Copy link
Collaborator

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely looks good, just a comment about the binary file - a possible workaround is proposed in #600 :)

Copy link
Collaborator

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Merging both this one and #600

@th-ch th-ch merged commit 7192b25 into pear-devs:master Feb 13, 2022
@Araxeus
Copy link
Collaborator Author

Araxeus commented Feb 13, 2022

@th-ch
Sorry I made a mistake when I moved interactive.js after testing

the commit below is the fix, could you apply it to the main branch? 😟

bd374d1

@th-ch
Copy link
Collaborator

th-ch commented Feb 13, 2022

Done! 6cad687 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interactive Notifications not registering as Youtube Music

2 participants