Change ServerController to be cleaner.

Author: Potherca

src/Controller/ServerController.php

@@ -2,6 +2,10 @@
 
 namespace Pdsinterop\Solid\Controller;
 
+use Pdsinterop\Solid\Auth\Config\Client;
+use Pdsinterop\Solid\Auth\Enum\Authorization;
+use Pdsinterop\Solid\Auth\Factory\ConfigFactory;
+
 abstract class ServerController extends AbstractController
 {
     protected $authServerConfig;
@@ -58,20 +62,15 @@ public function createAuthServerConfig()
         $clientId = $_GET['client_id']; // FIXME: No request object here to get the client Id from.
         $client = $this->getClient($clientId);
         $keys = $this->getKeys();
-        try {
-            $config = (new ConfigFactory(
-                $client,
-                $keys['encryptionKey'],
-                $keys['privateKey'],
-                $keys['publicKey'],
-                $this->getOpenIdEndpoints()
-            ))->create();
-        } catch (Throwable $e) {
-            // var_dump($e);
-        }
 
-        return $config;
-    }
+        return (new ConfigFactory(
+				$client,
+				$keys['encryptionKey'],
+				$keys['privateKey'],
+				$keys['publicKey'],
+				$this->getOpenIdEndpoints()
+			))->create();
+	}
 
     public function getClient($clientId)
     {
@@ -93,11 +92,9 @@ public function getClient($clientId)
 
     public function createConfig()
     {
-        // if (isset($_GET['client_id'])) {
         $clientId = $_GET['client_id'];
         $client = $this->getClient($clientId);
 
-        // }
         return (new ConfigFactory(
             $client,
             $this->keys['encryptionKey'],
@@ -106,6 +103,7 @@ public function createConfig()
             $this->openIdConfiguration
         ))->create();
     }
+
     public function checkApproval($clientId)
     {
         $approval = Authorization::DENIED;
@@ -121,6 +119,7 @@ public function checkApproval($clientId)
 
         return $approval;
     }
+
     public function getProfilePage() : string
     {
         return $this->baseUrl . "/profile/card#me"; // FIXME: would be better to base this on the available routes if possible.