fix: get expense by id (#65)

Author: paul-nguyen-goldenowl

GoMoney/Service/DataService.swift

@@ -160,10 +160,14 @@ class DataService {
     }
 
     /// get Transaction by id.
-    func getTransaction(by id: String, completion: ((Expense?) -> Void)? = nil) {
-        let transaction = realm.objects(Expense.self)
-            .first(where: { $0._id.stringValue == id })
-        completion?(transaction)
+    func getTransaction(by id: String) -> Expense? {
+        guard let objectId = try? ObjectId(string: id) else {
+            return nil
+        }
+        return realm.object(
+            ofType: Expense.self,
+            forPrimaryKey: objectId
+        )
     }
 
     func dropAllTable() {

GoMoney/Service/RemoteService.swift

@@ -54,22 +54,23 @@ class RemoteService {
             return
         }
 
-        local.getTransaction(by: id) { transaction in
-            guard let transaction = transaction else {
-                print("Transaction \(id) not found at local.")
-                return
-            }
-            do {
-                try self.db.collection("transactions")
-                    .document(userId)
-                    .collection("transactions")
-                    .document(id)
-                    .setData(from: transaction)
-
-                completion(nil)
-            } catch {
-                completion(error)
-            }
+        let transaction = local.getTransaction(by: id)
+
+        guard let transaction = transaction else {
+            print("Transaction \(id) not found at local.")
+            return
+        }
+
+        do {
+            try db.collection("transactions")
+                .document(userId)
+                .collection("transactions")
+                .document(id)
+                .setData(from: transaction)
+
+            completion(nil)
+        } catch {
+            completion(error)
         }
     }