Commit d113c39
authored
Refine warning behavior for unsupported options (#983)
## Summary
Currently, the warning for unsupported options is shown regardless of whether an explicit value is provided.
This PR updates the behavior so that the warning is shown only when the unsupported options is explicitly set by the user.
Tests have been updated to reflect usage without warnings, which is what users would expect.
## Additional Information
Note that `parallel_tool_calls` option in `Langchain::Assistant#initialize` defaults to `true`:
https://github.com/patterns-ai-core/langchainrb/blob/0.19.5/lib/langchain/assistant.rb#L45
However, whether this option is supported depends on the underlying LLM.
Therefore, for LLMs that do not support `parallel_tool_calls`, the option should effectively not be `true`.
Since this would involve changing the default behavior of `parallel_tool_calls`,
it is considered out of scope for this PR and should be addressed separately.1 parent a374c49 commit d113c39
File tree
6 files changed
+8
-8
lines changed- lib/langchain/assistant/llm/adapters
- spec/langchain/assistant/llm/adapters
6 files changed
+8
-8
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
| 23 | + | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
0 commit comments