refactor: enabled fileendings separated with more than one dot

Author: mfranzke

packages/core/src/lib/object_factory.js

@@ -41,19 +41,31 @@ const Pattern = function (
    */
   const pathObj = path.parse(this.relPath);
 
+  // We need to check for templates with a fileextension that contains multiple dots like e.g. .html.twig
+  if (
+    patternlab?.config?.patternExtension?.includes('.') &&
+    this.relPath.endsWith('.' + patternlab.config.patternExtension)
+  ) {
+    this.fileName = path.basename(
+      this.relPath,
+      '.' + patternlab.config.patternExtension
+    ); // e.g. 'colors'
+  } else {
+    this.fileName = pathObj.name; // e.g. 'colors'
+  }
+  this.subdir = pathObj.dir; // 'atoms/global'
+  this.fileExtension = pathObj.ext; // '.hbs'
+
   const info = this.getPatternInfo(
     pathObj,
     patternlab,
     isPromoteToFlatPatternRun ||
       (patternlab &&
         patternlab.config &&
-        patternlab.config.allPatternsAreDeeplyNested)
+        patternlab.config.allPatternsAreDeeplyNested),
+    this.fileName
   );
 
-  this.fileName = pathObj.name; // 'colors'
-  this.subdir = pathObj.dir; // 'atoms/global'
-  this.fileExtension = pathObj.ext; // '.mustache'
-
   // TODO: Remove if block when dropping ordering by prefix and keep else code
   // (When we drop the info about the old ordering is deprecated)
   if (
@@ -345,15 +357,20 @@ Pattern.prototype = {
    *
    * @param pathObj path.parse() object containing useful path information
    */
-  getPatternInfo: (pathObj, patternlab, isPromoteToFlatPatternRun) => {
+  getPatternInfo: (
+    pathObj,
+    patternlab,
+    isPromoteToFlatPatternRun,
+    filename
+  ) => {
     const info = {
       // colors(.mustache) is deeply nested in atoms-/global/colors
       patternlab: patternlab,
       patternHasOwnDir: isPromoteToFlatPatternRun
         ? path.basename(pathObj.dir).replace(prefixMatcher, '') ===
-            pathObj.name.replace(prefixMatcher, '') ||
+            filename.replace(prefixMatcher, '') ||
           path.basename(pathObj.dir).replace(prefixMatcher, '') ===
-            pathObj.name.split('~')[0].replace(prefixMatcher, '')
+            filename.split('~')[0].replace(prefixMatcher, '')
         : false,
     };
 

packages/engine-handlebars/lib/engine_handlebars.js

@@ -129,8 +129,8 @@ const engine_handlebars = {
    * assume it's already present
    */
   spawnMeta: function (config) {
-    this.spawnFile(config, '_head.hbs');
-    this.spawnFile(config, '_foot.hbs');
+    this.spawnFile(config, '_head.' + config.patternExtension);
+    this.spawnFile(config, '_foot.' + config.patternExtension);
   },
 
   /**

packages/engine-mustache/lib/engine_mustache.js

@@ -104,8 +104,8 @@ const engine_mustache = {
    * assume it's already present
    */
   spawnMeta: function (config) {
-    this.spawnFile(config, '_head.mustache');
-    this.spawnFile(config, '_foot.mustache');
+    this.spawnFile(config, '_head.' + config.patternExtension);
+    this.spawnFile(config, '_foot.' + config.patternExtension);
   },
 
   // find and return any {{> template-name }} within pattern

packages/engine-twig-php/lib/engine_twig_php.js

@@ -25,7 +25,7 @@ let patternLabConfig = {};
 const engine_twig_php = {
   engine: TwigRenderer,
   engineName: 'twig-php',
-  engineFileExtension: '.twig',
+  engineFileExtension: ['.twig', '.html.twig'],
   expandPartials: false,
   findPartialsRE:
     /{%\s*(?:extends|include|embed)\s+('[^']+'|"[^"]+").*?(with|%}|\s*%})/g,
@@ -120,7 +120,10 @@ const engine_twig_php = {
    */
   spawnMeta(config) {
     const { paths } = config;
-    ['_head.twig', '_foot.twig'].forEach((fileName) => {
+    [
+      '_head.' + config.patternExtension,
+      '_foot.' + config.patternExtension,
+    ].forEach((fileName) => {
       const metaFilePath = path.resolve(paths.source.meta, fileName);
       try {
         fs.statSync(metaFilePath);

packages/engine-twig/lib/engine_twig.js

@@ -121,7 +121,7 @@ var metaPath;
 var engine_twig = {
   engine: twing,
   engineName: 'twig',
-  engineFileExtension: '.twig',
+  engineFileExtension: ['.twig', '.html.twig'],
 
   // regexes, stored here so they're only compiled once
   findPartialsRE:
@@ -203,8 +203,8 @@ var engine_twig = {
    * assume it's already present
    */
   spawnMeta: function (config) {
-    this.spawnFile(config, '_head.twig');
-    this.spawnFile(config, '_foot.twig');
+    this.spawnFile(config, '_head.' + config.patternExtension);
+    this.spawnFile(config, '_foot.' + config.patternExtension);
   },
 
   /**