Merge pull request fastapi#29 from fastapilabs/09-12-_load_configuration_from_json_file_if_any

✨ Load configuration from json file if any

Author: patrick91

src/fastapi_cli/config.py

@@ -1,9 +1,26 @@
+import json
+from pathlib import Path
+
 from pydantic import BaseModel
 
+from .utils.config import get_cli_config_path
+
 
 class Settings(BaseModel):
-    base_api_url: str = "http://localhost:8000/api/v1"
+    base_api_url: str = "https://api.fastapicloud.club/api/v1"
     client_id: str = "fastapi-cli"
+    base_frontend_url: str = "https://dashboard.fastapicloud.work"
+
+    @classmethod
+    def from_user_settings(cls, config_path: Path) -> "Settings":
+        try:
+            content = config_path.read_bytes() if config_path.exists() else b"{}"
+
+            user_settings = json.loads(content)
+        except json.JSONDecodeError:
+            user_settings = {}
+
+        return cls(**user_settings)
 
 
-settings = Settings()
+settings = Settings.from_user_settings(get_cli_config_path())

src/fastapi_cli/utils/config.py

@@ -12,3 +12,10 @@ def get_auth_path() -> Path:
     auth_path.parent.mkdir(parents=True, exist_ok=True)
 
     return auth_path
+
+
+def get_cli_config_path() -> Path:
+    cli_config_path = get_config_folder() / "cli.json"
+    cli_config_path.parent.mkdir(parents=True, exist_ok=True)
+
+    return cli_config_path

tests/test_config.py

@@ -0,0 +1,39 @@
+from pathlib import Path
+
+from fastapi_cli.config import Settings
+
+
+def test_loads_default_values_when_file_does_not_exist() -> None:
+    default_settings = Settings()
+
+    settings = Settings.from_user_settings(Path("non_existent_file.json"))
+
+    assert settings.base_api_url == default_settings.base_api_url
+    assert settings.client_id == default_settings.client_id
+    assert settings.base_frontend_url == default_settings.base_frontend_url
+
+
+def test_loads_settings_even_when_file_is_broken(tmp_path: Path) -> None:
+    broken_settings_path = tmp_path / "broken_settings.json"
+    broken_settings_path.write_text("this is not json")
+
+    default_settings = Settings()
+
+    settings = Settings.from_user_settings(broken_settings_path)
+
+    assert settings.base_api_url == default_settings.base_api_url
+    assert settings.client_id == default_settings.client_id
+    assert settings.base_frontend_url == default_settings.base_frontend_url
+
+
+def test_loads_partial_settings(tmp_path: Path) -> None:
+    settings_path = tmp_path / "settings.json"
+    settings_path.write_text('{"base_api_url": "https://example.com"}')
+
+    default_settings = Settings()
+
+    settings = Settings.from_user_settings(settings_path)
+
+    assert settings.base_api_url == "https://example.com"
+    assert settings.client_id == default_settings.client_id
+    assert settings.base_frontend_url == default_settings.base_frontend_url