studio: Fixes for exposed MCP server (#853)

- **add, export base logger interface**
- **accept logger w/ ctor, log requests**
- **construct cli's mcp server w/ console logger**
- **add leveldown as direct dep in cli...**
- **fix: rm examples dir from main build entry...**

Author: NiloCK

packages/cli/package.json

@@ -49,6 +49,7 @@
     "commander": "^11.0.0",
     "fs-extra": "^11.2.0",
     "inquirer": "^9.2.0",
+    "leveldown": "^6.1.1",
     "pinia": "^2.3.0",
     "pouchdb": "^9.0.0",
     "serve-static": "^1.15.0",

packages/cli/src/commands/studio.ts

@@ -185,7 +185,6 @@ async function launchStudio(coursePath: string, options: StudioOptions) {
     // Phase 9.5: Launch Express backend
     const expressResult = await startExpressBackend(
       couchDBManager.getConnectionDetails(),
-      resolvedPath,
       unpackResult.databaseName
     );
     expressServer = expressResult.server;
@@ -210,7 +209,7 @@ async function launchStudio(coursePath: string, options: StudioOptions) {
     console.log(chalk.gray(`   Express API: ${expressResult.url}`));
 
     // Display MCP connection information
-    const mcpInfo = getMCPConnectionInfo(unpackResult, couchDBManager, resolvedPath);
+    const mcpInfo = getMCPConnectionInfo(unpackResult, couchDBManager);
     console.log(chalk.blue(`🔗 MCP Server: ${mcpInfo.command}`));
     console.log(chalk.gray(`   Connect MCP clients using the command above`));
     console.log(chalk.gray(`   Environment variables for MCP:`));
@@ -219,7 +218,7 @@ async function launchStudio(coursePath: string, options: StudioOptions) {
     });
 
     // Display .mcp.json content for Claude Code integration
-    const mcpJsonContent = generateMCPJson(unpackResult, couchDBManager, resolvedPath);
+    const mcpJsonContent = generateMCPJson(unpackResult, couchDBManager);
     console.log(chalk.blue(`📋 .mcp.json content:`));
     console.log(chalk.gray(mcpJsonContent));
 
@@ -569,7 +568,6 @@ async function openBrowser(url: string): Promise<void> {
  */
 async function startExpressBackend(
   couchDbConnectionDetails: ConnectionDetails,
-  _projectPath: string,
   databaseName: string
 ): Promise<{ server: http.Server; port: number; url: string }> {
   console.log(chalk.blue('⚡ Starting Express backend server...'));
@@ -603,7 +601,7 @@ async function startExpressBackend(
   try {
     // Set NODE_ENV for studio mode authentication bypass
     process.env.NODE_ENV = 'studio';
-    
+
     // Create Express app using factory
     const app = createExpressApp(config);
 
@@ -1317,7 +1315,7 @@ export default defineConfig({
     },
     dedupe: [
       'vue',
-      'vuetify', 
+      'vuetify',
       'vue-router',
       'pinia',
       '@vue-skuilder/db',
@@ -1334,45 +1332,18 @@ export default defineConfig({
 }
 
 /**
- * Determine the correct MCP server executable path/command based on project context
+ * Determine the correct MCP server executable path.
+ * This is now greatly simplified because the bundled server is always
+ * located relative to this `studio.ts` file.
  */
-function resolveMCPExecutable(projectPath: string): {
-  command: string;
-  args: string[];
-  isNpx: boolean;
-} {
-  // Check if we're in the monorepo (packages/cli exists)
-  const monorepoCliPath = path.join(projectPath, 'packages', 'cli', 'dist', 'mcp-server.js');
-  if (fs.existsSync(monorepoCliPath)) {
-    return {
-      command: './packages/cli/dist/mcp-server.js',
-      args: [],
-      isNpx: false,
-    };
-  }
+function resolveMCPExecutable(): { command: string; args: string[] } {
+  // Resolve the path to the bundled server relative to the current file.
+  // __dirname is the `dist/commands` directory.
+  const serverPath = path.resolve(__dirname, '..', 'mcp-server.js');
 
-  // Check if @vue-skuilder/cli is installed as a dependency
-  const scaffoldedCliPath = path.join(
-    projectPath,
-    'node_modules',
-    '@vue-skuilder',
-    'cli',
-    'dist',
-    'mcp-server.js'
-  );
-  if (fs.existsSync(scaffoldedCliPath)) {
-    return {
-      command: './node_modules/@vue-skuilder/cli/dist/mcp-server.js',
-      args: [],
-      isNpx: false,
-    };
-  }
-
-  // Fallback to npx approach
   return {
-    command: 'npx',
-    args: ['@vue-skuilder/cli', 'mcp-server'],
-    isNpx: true,
+    command: 'node',
+    args: [serverPath],
   };
 }
 
@@ -1381,19 +1352,16 @@ function resolveMCPExecutable(projectPath: string): {
  */
 function getMCPConnectionInfo(
   unpackResult: UnpackResult,
-  couchDBManager: CouchDBManager,
-  projectPath: string
+  couchDBManager: CouchDBManager
 ): { command: string; env: Record<string, string> } {
   const couchDetails = couchDBManager.getConnectionDetails();
-  const executable = resolveMCPExecutable(projectPath);
+  const executable = resolveMCPExecutable();
+  const port = couchDetails.port || 5985;
 
   // Build command string for display
-  let commandStr: string;
-  if (executable.isNpx) {
-    commandStr = `${executable.command} ${executable.args.join(' ')} ${unpackResult.databaseName} ${couchDetails.port}`;
-  } else {
-    commandStr = `node ${executable.command} ${unpackResult.databaseName} ${couchDetails.port}`;
-  }
+  const commandStr = `${executable.command} ${executable.args.join(' ')} ${
+    unpackResult.databaseName
+  } ${port}`;
 
   return {
     command: commandStr,
@@ -1412,12 +1380,11 @@ function getMCPConnectionInfo(
 function generateMCPJson(
   unpackResult: UnpackResult,
   couchDBManager: CouchDBManager,
-  projectPath: string,
   serverName: string = 'vue-skuilder-studio'
 ): string {
   const couchDetails = couchDBManager.getConnectionDetails();
   const port = couchDetails.port || 5985;
-  const executable = resolveMCPExecutable(projectPath);
+  const executable = resolveMCPExecutable();
 
   const mcpConfig = {
     mcpServers: {

packages/cli/src/mcp-server.ts

@@ -1,7 +1,9 @@
-#!/usr/bin/env node
+// MCP Server for Vue-Skuilder courses
+// This file is bundled into a self-contained executable
 
 import { initializeDataLayer, getDataLayer, initializeTuiLogging } from '@vue-skuilder/db';
 import { MCPServer } from '@vue-skuilder/mcp';
+import { consoleLogger } from '@vue-skuilder/common';
 import { StdioServerTransport } from '@modelcontextprotocol/sdk/server/stdio.js';
 
 initializeTuiLogging();
@@ -42,10 +44,11 @@ async function main() {
     await initializeDataLayer(couchdbConfig);
     const courseDB = getDataLayer().getCourseDB(courseId);
 
-    // Create and start MCP server
+    // Create and start MCP server with console logger
     const server = new MCPServer(courseDB, {
       enableSourceLinking: true,
       maxCardsPerQuery: 50,
+      logger: consoleLogger,
     });
 
     const transport = new StdioServerTransport();

packages/common/src/index.ts

@@ -6,6 +6,7 @@ export * from './logshim.js';
 export * from './validators.js';
 export * from './fieldConverters.js';
 export * from './db.js';
+export * from './logger.js';
 
 export * from './bulkImport/cardParser.js';
 export * from './bulkImport/types.js';

packages/common/src/logger.ts

@@ -0,0 +1,36 @@
+/**
+ * Standard logger interface for vue-skuilder packages
+ * 
+ * This interface enables dependency injection of logging functionality,
+ * allowing different runtime contexts to provide appropriate logger implementations:
+ * - Node.js contexts can use Winston
+ * - Browser contexts can use console wrappers
+ * - Test contexts can use mock loggers
+ */
+export interface SkLogger {
+  debug(message: string, ...args: any[]): void;
+  info(message: string, ...args: any[]): void;
+  warn(message: string, ...args: any[]): void;
+  error(message: string, ...args: any[]): void;
+}
+
+/**
+ * No-op logger implementation for contexts where logging is not needed
+ */
+export const noOpLogger: SkLogger = {
+  debug: () => {},
+  info: () => {},
+  warn: () => {},
+  error: () => {},
+};
+
+/**
+ * Console-based logger for browser/development contexts
+ * Uses console methods with appropriate ESLint suppressions
+ */
+export const consoleLogger: SkLogger = {
+  debug: (message: string, ...args: any[]) => console.debug(message, ...args), // eslint-disable-line no-console
+  info: (message: string, ...args: any[]) => console.info(message, ...args),   // eslint-disable-line no-console
+  warn: (message: string, ...args: any[]) => console.warn(message, ...args),   // eslint-disable-line no-console
+  error: (message: string, ...args: any[]) => console.error(message, ...args), // eslint-disable-line no-console
+};

packages/mcp/src/index.ts

@@ -8,7 +8,4 @@ export * from './types/index.js';
 export * from './resources/index.js';
 
 // Tools
-export * from './tools/index.js';
-
-// Examples
-export * from './examples/index.js';
+export * from './tools/index.js';