update express pkg to shared config...

and clean up TS errors

Author: NiloCK

assistant/typescript-standardization-roadmap.md

@@ -244,15 +244,19 @@ yarn workspace @vue-skuilder/db build
 
 **COMMIT POINT**: Dual CommonJS/ESM exports working for shared libraries
 
-### ✅ Day 2: Express Package
-- [ ] Update `express/tsconfig.json` (extends base, NodeNext)
-- [ ] Test: Build express package
-- [ ] Verify: No breaking changes in build outputs
+### ✅ Day 2: Express Package - COMPLETED
+- [x] Update `express/tsconfig.json` (extends base, NodeNext)
+- [x] Test: Build express package
+- [x] Verify: No breaking changes in build outputs
+- [x] Fixed: 20+ TypeScript strict errors (unused parameters, imports)
+- [x] Fixed: Composite flag issue preventing JavaScript output
+- [x] Fixed: ESM import paths in common package (.js → .mjs)
+- [x] Fixed: Runtime import error for EloToNumber function
 
 ### ✅ Integration Testing
-- [ ] Test: `yarn workspace @vue-skuilder/common build`
-- [ ] Test: `yarn workspace @vue-skuilder/db build`
-- [ ] Test: `yarn workspace @vue-skuilder/express build`
+- [x] Test: `yarn workspace @vue-skuilder/common build`
+- [x] Test: `yarn workspace @vue-skuilder/db build`
+- [x] Test: `yarn workspace @vue-skuilder/express build`
 - [ ] Test: `yarn workspace @vue-skuilder/e2e-db test`
 - [ ] Verify: IDE intellisense works across backend packages
 
@@ -402,25 +406,50 @@ export interface Answer { ... }
 - Build system inconsistencies create more complexity than necessary
 - Package boundaries need clearer definition between domain and persistence concerns
 
+### ESM Import Path Resolution Issues
+
+#### Problem Discovered:
+When building dual CommonJS/ESM packages, simply renaming `.js` files to `.mjs` isn't sufficient - the import statements inside the files must also be updated to reference `.mjs` extensions.
+
+#### Specific Issue:
+- Common package generated both `elo.js` (CJS) and `elo.mjs` (ESM)
+- ESM `index.mjs` still contained `export * from './elo.js'`
+- Express app (running in ESM mode) tried to import ESM version but got wrong file references
+- Runtime error: `The requested module '@vue-skuilder/common' does not provide an export named 'EloToNumber'`
+
+#### Root Cause:
+ESM requires explicit file extensions and the build process wasn't updating import paths within files when creating the `.mjs` versions.
+
+#### Solution Implemented:
+Updated build script to use `sed` to replace `.js` with `.mjs` in import statements:
+```bash
+find dist-esm -name '*.js' -exec sed -i "s/\.js'/\.mjs'/g; s/\.js\"/\.mjs\"/g" {} \;
+```
+
+#### Impact:
+This type of import path issue would affect any ESM consumer of workspace packages and demonstrates the complexity of maintaining dual module formats manually.
+
 ## Current Status (Session 1 Complete)
 
 ### ✅ Completed Today
 - Created shared `tsconfig.base.json` with ES2022 target and strict settings
-- Migrated `common` and `db` packages to extend base configuration
-- Fixed unused parameter strictness issue in common package
+- Migrated `common`, `db`, and `express` packages to extend base configuration
+- Fixed unused parameter strictness issues across packages
 - Added dual CommonJS/ESM exports to shared libraries
 - Resolved database type export issues and naming conflicts
-- Verified all builds and dev environment still work
+- Fixed ESM import path issues (.js → .mjs) in build process
+- Verified all builds, dev environment, and express runtime working
 
 ### 🎯 Next Session Goals
-- Update express package to use base config
 - Fix e2e-db Jest import issues with new CommonJS exports
 - Complete backend TypeScript standardization
 - Test full integration with Jest consuming CommonJS exports
+- Verify IDE intellisense works across all backend packages
 
 ### 📊 Progress Metrics
-- **Packages Standardized**: 2/4 backend packages (common, db)
+- **Packages Standardized**: 3/4 backend packages (common, db, express)
 - **Build Status**: ✅ All packages building successfully with dual outputs
 - **Dev Environment**: ✅ yarn dev working
+- **Runtime Status**: ✅ Express app running with ESM imports
 - **Type Consistency**: ✅ ES2022 target across standardized packages
 - **Module Exports**: ✅ CommonJS/ESM dual exports ready for Jest

packages/common/package.json

@@ -14,7 +14,7 @@
         }
     },
     "scripts": {
-        "build": "rm -rf dist dist-esm && tsc -p tsconfig.cjs.json && tsc -p tsconfig.esm.json && find dist-esm -name '*.js' -exec sh -c 'mv \"$1\" \"${1%.js}.mjs\"' _ {} \\; && cp -r dist-esm/* dist/ && rm -rf dist-esm",
+        "build": "rm -rf dist dist-esm && tsc -p tsconfig.cjs.json && tsc -p tsconfig.esm.json && find dist-esm -name '*.js' -exec sed -i \"s/\\.js'/\\.mjs'/g; s/\\.js\\\"/\\.mjs\\\"/g\" {} \\; && find dist-esm -name '*.js' -exec sh -c 'mv \"$1\" \"${1%.js}.mjs\"' _ {} \\; && cp -r dist-esm/* dist/ && rm -rf dist-esm",
         "dev": "tsc --watch"
     },
     "packageManager": "yarn@4.6.0",

packages/express/src/app.ts

@@ -58,7 +58,7 @@ export interface VueClientRequest extends express.Request {
   body: ServerRequest;
 }
 
-app.get('/courses', async (req: Request, res: Response) => {
+app.get('/courses', async (_req: Request, res: Response) => {
   try {
     const courses = await CourseLookup.allCourses();
     res.send(courses.map((c) => `${c._id} - ${c.name}`));
@@ -164,11 +164,11 @@ app.post('/', (req: Request, res: Response) => {
   postHandler(req, res);
 });
 
-app.get('/version', (req: Request, res: Response) => {
+app.get('/version', (_req: Request, res: Response) => {
   res.send(ENV.VERSION);
 });
 
-app.get('/', (req: Request, res: Response) => {
+app.get('/', (_req: Request, res: Response) => {
   let status = `Express service is running.\nVersion: ${ENV.VERSION}\n`;
 
   CouchDB.session()

packages/express/src/attachment-preprocessing/index.ts

@@ -1,4 +1,4 @@
-import CouchDB, { useOrCreateDB } from '../couchdb/index.js';
+import CouchDB from '../couchdb/index.js';
 import nano from 'nano';
 import { normalize } from './normalize.js';
 import AsyncProcessQueue, { Result } from '../utils/processQueue.js';
@@ -186,11 +186,11 @@ async function processDocAttachments(
   return resp;
 }
 
-interface DatabaseChangesResultItemWithDoc
-  extends nano.DatabaseChangesResultItem {
-  doc: nano.DocumentGetResponse;
-  courseID: string;
-}
+// interface _DatabaseChangesResultItemWithDoc
+//   extends nano.DatabaseChangesResultItem {
+//   doc: nano.DocumentGetResponse;
+//   courseID: string;
+// }
 
 interface AttachmentProcessingRequest {
   courseID: string;

packages/express/src/client-requests/classroom-requests.ts

@@ -23,7 +23,7 @@ interface lookupData {
   uuid: string;
 }
 
-async function deleteClassroom(classroom_id: string) {}
+// async function deleteClassroom(_classroom_id: string) {}
 
 async function getClassID(joinCode: string) {
   try {
@@ -55,7 +55,7 @@ async function writeClassroomConfig(config: ClassroomConfig, classID: string) {
           ...config,
         });
       })
-      .catch((err) => {
+      .catch((_err) => {
         studentDB.insert({
           _id: CLASSROOM_CONFIG,
           ...config,
@@ -70,7 +70,7 @@ async function writeClassroomConfig(config: ClassroomConfig, classID: string) {
           ...config,
         });
       })
-      .catch((err) => {
+      .catch((_err) => {
         teacherDB.insert({
           _id: CLASSROOM_CONFIG,
           ...config,

packages/express/src/client-requests/course-requests.ts

@@ -1,11 +1,10 @@
-import hashids from 'hashids';
 import { log } from 'util';
 import { CreateCourse } from '@vue-skuilder/common';
-import CouchDB, { SecurityObject, useOrCreateDB } from '../couchdb/index.js';
+import CouchDB, { SecurityObject } from '../couchdb/index.js';
 import { postProcessCourse } from '../attachment-preprocessing/index.js';
 import AsyncProcessQueue from '../utils/processQueue.js';
 import nano from 'nano';
-import { Status } from '@vue-skuilder/common';
+
 import logger from '@/logger.js';
 import { CourseLookup } from '@vue-skuilder/db';
 import { courseDBDesignDocs } from '../design-docs.js';

packages/express/src/couchdb/authentication.ts

@@ -36,7 +36,7 @@ export async function requestIsAdminAuthenticated(req: VueClientRequest) {
         const isLoggedInUser = s.userCtx.name === username;
         return isAdmin && isLoggedInUser;
       })
-      .catch((err) => {
+      .catch((_err) => {
         return false;
       });
   }
@@ -78,7 +78,7 @@ export async function requestIsAuthenticated(req: VueClientRequest) {
         logger.info(`AuthUser: ${JSON.stringify(s)}`);
         return s.userCtx.name === username;
       })
-      .catch((err) => {
+      .catch((_err) => {
         return false;
       });
   }

packages/express/src/routes/logs.ts

@@ -1,14 +1,14 @@
 import express, { Request, Response } from 'express';
 import { promises as fs } from 'fs';
 import path from 'path';
-import { requestIsAdminAuthenticated } from '../couchdb/authentication.js';
+
 import logger from '../logger.js';
 import process from 'process';
 
 const router = express.Router();
 
 // Get list of available log files
-router.get('/', async (req: Request, res: Response) => {
+router.get('/', async (_req: Request, res: Response) => {
   // [ ] add an auth mechanism. Below fcn is based on
   //     the CouchDB auth mechanism, forwarded from the web-app (not direct-access of server).
   //

packages/express/src/utils/env.ts

@@ -1,6 +1,6 @@
 import dotenv from 'dotenv';
 import process from 'process';
-import fs from 'fs';
+
 import { initializeDataLayer } from '@vue-skuilder/db';
 
 dotenv.config({

packages/express/src/utils/processQueue.ts

@@ -1,6 +1,6 @@
 import { IServerRequest } from '@vue-skuilder/common';
 
-interface Request {}
+
 export interface Result {
   status: 'ok' | 'awaiting' | 'warning' | 'error';
   ok: boolean;
@@ -88,8 +88,7 @@ export default class AsyncProcessQueue<
             reject();
           }
         },
-        intervals[depth],
-        jobID
+        intervals[depth]
       );
     });
 
@@ -102,7 +101,7 @@ export default class AsyncProcessQueue<
       });
   }
 
-  public async getResult(jobID: number, depth = 0): Promise<R> {
+  public async getResult(jobID: number, _depth = 0): Promise<R> {
     const status = this.jobStatus(jobID);
 
     if (status === 'complete') {