Skip to content

Commit 43f1922

Browse files
committed
separate startup of studio from wait for studio...
the startup cmd launches a sequence of procesess - the wait was inserting itself in-between, and delaying the start of later processes (the thing it was waitign on!)
1 parent 7c0b99b commit 43f1922

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

.github/workflows/ci-pkg-cli.yml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -94,15 +94,14 @@ jobs:
9494
working-directory: packages/cli/testproject-empty
9595
run: |
9696
npx skuilder studio --no-browser > studio.log 2>&1 &
97-
STUDIO_PID=$!
98-
echo "Studio process started with PID: $STUDIO_PID"
99-
sleep 5
100-
echo "Checking if studio process is still running..."
101-
ps -p $STUDIO_PID || echo "WARNING: Studio process already exited"
102-
echo "First 50 lines of studio log:"
103-
head -50 studio.log || echo "No log file yet"
104-
echo "Waiting for studio server to be ready..."
105-
node_modules/.bin/wait-on http://localhost:7174 --timeout 60000 || (echo "wait-on failed, showing full log:" && cat studio.log && exit 1)
97+
echo "Studio process started with PID: $!"
98+
sleep 2
99+
100+
- name: Wait for studio server to be ready
101+
working-directory: packages/cli/testproject-empty
102+
run: |
103+
echo "Waiting for studio server on http://localhost:7174..."
104+
npx wait-on http://localhost:7174 --timeout 180000 || (echo "wait-on failed, showing studio log:" && cat studio.log && exit 1)
106105
107106
- name: Run custom questions studio mode tests
108107
working-directory: packages/cli

0 commit comments

Comments
 (0)