Skip to content

Commit 3c87517

Browse files
committed
linter fixes
1 parent 0bb32de commit 3c87517

File tree

2 files changed

+30
-22
lines changed

2 files changed

+30
-22
lines changed

packages/platform-ui/src/components/Edit/BulkImport/CardPreviewList.vue

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@
8080
color="error"
8181
prepend-icon="mdi-delete"
8282
class="mx-2"
83-
@click="promptDelete"
8483
:disabled="!currentCard || loading"
84+
@click="promptDelete"
8585
>
8686
Remove
8787
</v-btn>
@@ -91,8 +91,8 @@
9191
color="primary"
9292
prepend-icon="mdi-pencil"
9393
class="mx-2"
94-
@click="editCurrentCard"
9594
:disabled="!currentCard || loading"
95+
@click="editCurrentCard"
9696
>
9797
Edit
9898
</v-btn>
@@ -108,7 +108,9 @@
108108
</template>
109109

110110
<script lang="ts">
111-
import { ViewComponent, SkldrMouseTrap, HotKey, SkMouseTrap } from '@vue-skuilder/common-ui';
111+
import { SkldrMouseTrap, HotKey } from '@vue-skuilder/common-ui/src/utils/SkldrMouseTrap';
112+
import type { ViewComponent } from '@vue-skuilder/common-ui/src/composables';
113+
import SkMouseTrap from '@vue-skuilder/common-ui/src/components/SkMouseTrap.vue';
112114
import { DataShape, ParsedCard, ViewData } from '@vue-skuilder/common';
113115
import { defineComponent, PropType } from 'vue';
114116
import CardBrowser from '../CardBrowser.vue';
@@ -173,6 +175,15 @@ export default defineComponent({
173175
},
174176
},
175177
178+
mounted() {
179+
this.setupKeyBindings();
180+
},
181+
182+
beforeUnmount() {
183+
// Clean up key bindings when component is unmounted
184+
SkldrMouseTrap.reset();
185+
},
186+
176187
methods: {
177188
nextCard() {
178189
if (this.currentIndex < this.parsedCards.length - 1) {
@@ -191,7 +202,7 @@ export default defineComponent({
191202
this.currentIndex = index;
192203
}
193204
},
194-
205+
195206
setupKeyBindings() {
196207
// Define key bindings for navigation
197208
this.keyBindings = [
@@ -308,14 +319,7 @@ export default defineComponent({
308319
this.$emit('edit-card', this.currentCard, this.currentIndex);
309320
},
310321
},
311-
mounted() {
312-
this.setupKeyBindings();
313-
},
314-
315-
beforeUnmount() {
316-
// Clean up key bindings when component is unmounted
317-
SkldrMouseTrap.reset();
318-
},
322+
319323
});
320324
</script>
321325

packages/platform-ui/src/components/Edit/BulkImportView.vue

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ tags: tagC"
5151
<v-col cols="12" md="8">
5252
<card-preview-list
5353
v-if="parsedCards.length > 0"
54+
ref="cardPreviewList"
5455
v-model:parsed-cards="parsedCards"
5556
:data-shape="dataShape"
5657
:view-components="cardViewComponents"
57-
ref="cardPreviewList"
5858
@edit-card="handleEditCard"
5959
@delete-card="handleDeleteCard"
6060
/>
@@ -68,12 +68,12 @@ tags: tagC"
6868
<v-card-text>
6969
<v-form @submit.prevent="saveEditedCard" @keydown.esc="closeEditDialog">
7070
<v-textarea
71+
ref="markdownTextarea"
7172
v-model="editedMarkdown"
7273
label="Card Content"
7374
rows="6"
7475
auto-grow
7576
variant="outlined"
76-
ref="markdownTextarea"
7777
@keydown.ctrl.enter="saveEditedCard"
7878
></v-textarea>
7979

@@ -219,7 +219,7 @@ tags: tagC"
219219
</template>
220220

221221
<script lang="ts">
222-
import { defineComponent, PropType, ref } from 'vue';
222+
import { defineComponent, PropType } from 'vue';
223223
import {
224224
CourseConfig,
225225
DataShape,
@@ -230,7 +230,8 @@ import {
230230
isValidBulkFormat,
231231
} from '@vue-skuilder/common';
232232
import { BlanksCardDataShapes, allCourses } from '@vue-skuilder/courses';
233-
import { getCurrentUser, alertUser, ViewComponent } from '@vue-skuilder/common-ui';
233+
import { ViewComponent } from '@vue-skuilder/common-ui/src/composables';
234+
import { getCurrentUser, alertUser } from '@vue-skuilder/common-ui/src/index';
234235
import {
235236
getDataLayer,
236237
CourseDBInterface,
@@ -317,14 +318,15 @@ export default defineComponent({
317318
// Show alert to confirm deletion
318319
alertUser({
319320
text: 'Card removed from import list',
320-
status: Status.info,
321+
status: Status.warning, // Use warning instead of info
321322
});
322323
},
323324
324325
handleEditCard(card: ParsedCard, index: number) {
325326
// Disable keyboard shortcuts while editing
326327
if (this.$refs.cardPreviewList) {
327-
(this.$refs.cardPreviewList as any).toggleShortcuts(false);
328+
const previewComp = this.$refs.cardPreviewList as { toggleShortcuts: (enable: boolean) => void };
329+
previewComp.toggleShortcuts(false);
328330
}
329331
330332
this.editingCard = { ...card }; // Create a copy
@@ -337,7 +339,8 @@ export default defineComponent({
337339
// Focus the text area after dialog opens
338340
this.$nextTick(() => {
339341
if (this.$refs.markdownTextarea) {
340-
(this.$refs.markdownTextarea as any).$el.querySelector('textarea').focus();
342+
const textareaComp = this.$refs.markdownTextarea as { $el: HTMLElement; focus?: () => void };
343+
textareaComp.$el.querySelector('textarea')?.focus();
341344
}
342345
});
343346
},
@@ -363,7 +366,7 @@ export default defineComponent({
363366
// Show alert to confirm edit
364367
alertUser({
365368
text: 'Card updated successfully',
366-
status: Status.success,
369+
status: Status.ok,
367370
});
368371
},
369372
@@ -378,7 +381,8 @@ export default defineComponent({
378381
// Re-enable keyboard shortcuts after editing
379382
setTimeout(() => {
380383
if (this.$refs.cardPreviewList) {
381-
(this.$refs.cardPreviewList as any).toggleShortcuts(true);
384+
const previewComp = this.$refs.cardPreviewList as { toggleShortcuts: (enable: boolean) => void };
385+
previewComp.toggleShortcuts(true);
382386
}
383387
}, 100);
384388
},
@@ -588,7 +592,7 @@ export default defineComponent({
588592
// this.bulkText = ''; // Clear input text
589593
// this.parsingComplete = false; // Go back to input stage
590594
// this.parsedCards = [];
591-
alertUser({ text: `${this.results.length} card(s) imported successfully!`, status: Status.success });
595+
alertUser({ text: `${this.results.length} card(s) imported successfully!`, status: Status.ok });
592596
} else if (this.results.some((r) => r.status === 'error')) {
593597
alertUser({ text: 'Some cards failed to import. Please review the results below.', status: Status.warning });
594598
}

0 commit comments

Comments
 (0)