Skip to content

Commit 3a079d3

Browse files
committed
tmp: rm ViewComponent dep of common-ui...
prevents circular dependency between db and common-ui packages
1 parent 5ddd370 commit 3a079d3

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

packages/db/src/study/SessionController.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import {
1010
import { CardRecord } from '@db/core';
1111
import { Loggable } from '@db/util';
1212
import { ScheduledCard } from '@db/core/types/user';
13-
import { ViewComponent } from '@vue-skuilder/common-ui';
1413
import { ViewData } from '@vue-skuilder/common';
1514

1615
function randomInt(min: number, max: number): number {
@@ -29,7 +28,7 @@ export interface StudySessionRecord {
2928

3029
export interface HydratedCard {
3130
item: StudySessionItem;
32-
view: ViewComponent;
31+
view: any; // Vue component - avoid circular dependency with common-ui
3332
data: ViewData[];
3433
}
3534

@@ -92,7 +91,7 @@ export class SessionController extends Loggable {
9291
_className = 'SessionController';
9392
private sources: StudyContentSource[];
9493
private dataLayer: DataLayerProvider;
95-
private getViewComponent: (viewId: string) => ViewComponent;
94+
private getViewComponent: (viewId: string) => any;
9695
private _sessionRecord: StudySessionRecord[] = [];
9796
public set sessionRecord(r: StudySessionRecord[]) {
9897
this._sessionRecord = r;
@@ -127,7 +126,7 @@ export class SessionController extends Loggable {
127126
sources: StudyContentSource[],
128127
time: number,
129128
dataLayer: DataLayerProvider,
130-
getViewComponent: (viewId: string) => ViewComponent
129+
getViewComponent: (viewId: string) => any // Vue component
131130
) {
132131
super();
133132

0 commit comments

Comments
 (0)