tweak eslint config setups

Author: NiloCK

assistant/eslint-standardization-roadmap.md

@@ -572,16 +572,18 @@ export default [
 - [ ] Create package-specific templates (skipped - going directly to implementation)
 - [ ] Test base configuration with simple TypeScript file (skipped - applying to full codebase)
 
-### ✅ Week 2: Backend Migration
-- [ ] Create ESLint config for `common` package
-- [ ] Create ESLint config for `db` package  
-- [ ] Update ESLint config for `express` package
-- [ ] Create ESLint config for `e2e-db` package
-- [ ] Add lint scripts to all backend package.json files
-- [ ] Test: `yarn workspace @vue-skuilder/common lint`
-- [ ] Test: `yarn workspace @vue-skuilder/db lint`
-- [ ] Test: `yarn workspace @vue-skuilder/express lint`
-- [ ] Test: `yarn workspace @vue-skuilder/e2e-db lint`
+### ✅ Week 2: Backend Migration - COMPLETED
+- [x] Create ESLint config for `common` package
+- [x] Create ESLint config for `db` package  
+- [x] Update ESLint config for `express` package
+- [x] Create ESLint config for `e2e-db` package
+- [x] Add lint scripts to all backend package.json files
+- [x] Test: `yarn workspace @vue-skuilder/common lint:check` (11 warnings found)
+- [x] Test: `yarn workspace @vue-skuilder/db lint:check` (extensive issues found)
+- [x] Test: `yarn workspace @vue-skuilder/express lint:check` (53 problems found)
+- [x] Test: `yarn workspace @vue-skuilder/e2e-db lint:check` (28 problems found)
+- [x] Fix ESLint config file extensions (.js → .mjs for non-module packages)
+- [x] Add appropriate ignore patterns for each package
 
 ### ✅ Week 3: Frontend Migration
 - [ ] Update `platform-ui` ESLint config to use shared base

eslint.config.backend.js renamed to eslint.config.backend.mjs

@@ -1,5 +1,5 @@
 import tseslint from 'typescript-eslint';
-import baseConfig from './eslint.config.base.js';
+import baseConfig from './eslint.config.base.mjs';
 
 export default tseslint.config(
   ...baseConfig,

eslint.config.base.js renamed to eslint.config.base.mjs

@@ -20,7 +20,7 @@ export default tseslint.config(
         },
       ],
       '@typescript-eslint/no-explicit-any': 'warn',
-      '@typescript-eslint/prefer-const': 'error',
+
       '@typescript-eslint/no-var-requires': 'error',
       'prefer-const': 'error',
       'no-var': 'error',

eslint.config.frontend.js renamed to eslint.config.frontend.mjs

@@ -1,5 +1,5 @@
 import tseslint from 'typescript-eslint';
-import baseConfig from './eslint.config.base.js';
+import baseConfig from './eslint.config.base.mjs';
 
 export default tseslint.config(
   ...baseConfig,

packages/common/eslint.config.js

@@ -0,0 +1,16 @@
+import backendConfig from '../../eslint.config.backend.mjs';
+
+export default [
+  ...backendConfig,
+  {
+    ignores: ['node_modules/**', 'dist/**', 'dist-esm/**', 'eslint.config.js'],
+  },
+  {
+    languageOptions: {
+      parserOptions: {
+        project: './tsconfig.json',
+        tsconfigRootDir: import.meta.dirname,
+      },
+    },
+  },
+];

packages/common/package.json

@@ -15,7 +15,10 @@
     },
     "scripts": {
         "build": "rm -rf dist dist-esm && tsc -p tsconfig.cjs.json && tsc -p tsconfig.esm.json && find dist-esm -name '*.js' -exec sed -i \"s/\\.js'/\\.mjs'/g; s/\\.js\\\"/\\.mjs\\\"/g\" {} \\; && find dist-esm -name '*.js' -exec sh -c 'mv \"$1\" \"${1%.js}.mjs\"' _ {} \\; && cp -r dist-esm/* dist/ && rm -rf dist-esm",
-        "dev": "tsc --watch"
+        "dev": "tsc --watch",
+        "lint": "npx eslint .",
+        "lint:fix": "npx eslint . --fix",
+        "lint:check": "npx eslint . --max-warnings 0"
     },
     "packageManager": "yarn@4.6.0",
     "devDependencies": {

packages/db/eslint.config.mjs

@@ -0,0 +1,20 @@
+import backendConfig from '../../eslint.config.backend.mjs';
+
+export default [
+  ...backendConfig,
+  {
+    ignores: ['node_modules/**', 'dist/**', 'eslint.config.mjs'],
+  },
+  {
+    languageOptions: {
+      parserOptions: {
+        project: './tsconfig.json',
+        tsconfigRootDir: import.meta.dirname,
+      },
+    },
+    rules: {
+      // Database-specific rules
+      '@typescript-eslint/no-explicit-any': 'off', // PouchDB types often use any
+    },
+  },
+];

packages/db/package.json

@@ -25,7 +25,10 @@
     "scripts": {
         "build": "tsup",
         "build:debug": "tsup --sourcemap inline",
-        "dev": "tsup --watch"
+        "dev": "tsup --watch",
+        "lint": "npx eslint .",
+        "lint:fix": "npx eslint . --fix",
+        "lint:check": "npx eslint . --max-warnings 0"
     },
     "dependencies": {
         "@nilock2/pouchdb-authentication": "^1.0.2",

packages/e2e-db/eslint.config.mjs

@@ -0,0 +1,32 @@
+import backendConfig from '../../eslint.config.backend.mjs';
+
+export default [
+  ...backendConfig,
+  {
+    ignores: ['node_modules/**', 'userdb-*/**', 'eslint.config.mjs', 'jest.config.js'],
+  },
+  {
+    languageOptions: {
+      parserOptions: {
+        project: './tsconfig.json',
+        tsconfigRootDir: import.meta.dirname,
+      },
+      globals: {
+        // Jest globals
+        describe: 'readonly',
+        it: 'readonly',
+        expect: 'readonly',
+        beforeEach: 'readonly',
+        afterEach: 'readonly',
+        beforeAll: 'readonly',
+        afterAll: 'readonly',
+        jest: 'readonly',
+      },
+    },
+    rules: {
+      // Testing-specific rules
+      '@typescript-eslint/no-explicit-any': 'off', // Tests often need any for mocking
+      '@typescript-eslint/explicit-function-return-type': 'off', // Test functions don't need return types
+    },
+  },
+];

packages/e2e-db/package.json

@@ -10,7 +10,10 @@
         "db:start": "cd ../../ && yarn couchdb:start",
         "db:stop": "cd ../../ && yarn couchdb:stop",
         "test:e2e": "yarn db:start && yarn test && yarn db:stop",
-        "type-check": "tsc --noEmit"
+        "type-check": "tsc --noEmit",
+        "lint": "npx eslint .",
+        "lint:fix": "npx eslint . --fix",
+        "lint:check": "npx eslint . --max-warnings 0"
     },
     "dependencies": {
         "@vue-skuilder/common": "workspace:*",