Skip to content

Commit d35d467

Browse files
authored
Merge pull request reidmorrison#202 from dalibor/rails_7.1.2
Fix compatibility for Rails 7.1.2
2 parents 6f32736 + fa03020 commit d35d467

File tree

7 files changed

+43
-16
lines changed

7 files changed

+43
-16
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,24 +13,28 @@ jobs:
1313
matrix:
1414
include:
1515
- rails: "6.0"
16-
ruby: 2.7
16+
ruby: "2.7"
1717

1818
- rails: "6.1"
1919
ruby: "2.7"
2020
- rails: "6.1"
2121
ruby: "3.0"
2222
- rails: "6.1"
2323
ruby: "3.1"
24+
- rails: "6.1"
25+
ruby: "3.2"
2426

2527
- rails: "7.0"
26-
ruby: 3.1
28+
ruby: "3.1"
2729
- rails: "7.0"
28-
ruby: 3.2
30+
ruby: "3.2"
2931

3032
- rails: "7.1"
31-
ruby: 3.1
33+
ruby: "3.1"
34+
- rails: "7.1.1"
35+
ruby: "3.2"
3236
- rails: "7.1"
33-
ruby: 3.2
37+
ruby: "3.2"
3438

3539
env:
3640
BUNDLE_GEMFILE: gemfiles/rails_${{ matrix.rails }}.gemfile

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
*.log
33
pkg/
44
test/dummy/tmp/
5+
test/dummy/db/test.sqlite3-*
56
test/dummy/.sass-cache
67
*.gem
78
/.idea
@@ -12,6 +13,5 @@ Gemfile.lock
1213

1314
*.sqlite3
1415
.rakeTasks
15-
*.sqlite3
1616
TODO.md
1717

Appraisals

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ appraise "rails_7.0" do
1313
gem "sqlite3", "~> 1.4.0", platform: :ruby
1414
end
1515

16+
appraise "rails_7.1.1" do
17+
gem "rails", "7.1.1"
18+
gem "sqlite3", "~> 1.4.0", platform: :ruby
19+
end
20+
1621
appraise "rails_7.1" do
1722
gem "rails", "~> 7.1.0"
1823
gem "sqlite3", "~> 1.4.0", platform: :ruby

gemfiles/rails_7.1.1.gemfile

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# This file was generated by Appraisal
2+
3+
source "https://rubygems.org"
4+
5+
gem "appraisal"
6+
gem "puma"
7+
gem "active_model_serializers"
8+
gem "amazing_print"
9+
gem "minitest"
10+
gem "minitest-rails"
11+
gem "rake"
12+
gem "sprockets", "< 4.0"
13+
gem "rails", "7.1.1"
14+
gem "sqlite3", "~> 1.4.0", platform: :ruby
15+
gem "rubocop"
16+
17+
gemspec path: "../"
Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
1-
require "active_support/log_subscriber"
1+
if ActiveSupport::VERSION::STRING == '7.1.1'
2+
require "active_support/log_subscriber"
23

3-
module ActiveSupport
4-
class LogSubscriber
5-
# @override Rails 7.1
6-
def silenced?(event)
7-
native_log_level = @event_levels.fetch(event, ::Logger::Severity::FATAL)
8-
logger.nil? || SemanticLogger::Levels.index(logger.level) > SemanticLogger::Levels.index(native_log_level)
4+
module ActiveSupport
5+
class LogSubscriber
6+
# @override Rails 7.1
7+
def silenced?(event)
8+
native_log_level = @event_levels.fetch(event, ::Logger::Severity::FATAL)
9+
logger.nil? || SemanticLogger::Levels.index(logger.level) > SemanticLogger::Levels.index(native_log_level)
10+
end
911
end
1012
end
1113
end

test/action_mailer_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
class ActionMailerTest < Minitest::Test
44
class MyMailer < ActionMailer::Base
5-
def some_email(to:, from:, subject:)
6-
mail(to: to, from: from, subject: subject, body: "Hello")
5+
def some_email(opts)
6+
mail(to: opts[:to], from: opts[:from], subject: opts[:subject], body: "Hello")
77
end
88
end
99

test/active_record_test.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ class ActiveRecordTest < Minitest::Test
9696
Sample.where(age: 2..21).first
9797
end
9898
assert_equal 1, messages.count, messages
99-
ap messages
10099

101100
assert_semantic_logger_event(
102101
messages[0],

0 commit comments

Comments
 (0)