Remove s3_response & specifically check config for needed vars

Author: AdrianCurtin

index.js

@@ -180,19 +180,18 @@ class S3Adapter {
     }
     await this.createBucket();
     const command = new PutObjectCommand(params);
-    const response = await this._s3Client.send(command);
+    await this._s3Client.send(command);
     const endpoint = this._endpoint || `https://${this._bucket}.s3.${this._region}.amazonaws.com`;
     const location = `${endpoint}/${params.Key}`;
 
     let url;
-    if (config && typeof config === 'object' && Object.keys(config).length > 0) { // if config is passed, we can generate a presigned url here
+    if (config?.mount && config?.applicationId) { // if config has required properties for getFileLocation
       url = await this.getFileLocation(config, key_without_prefix);
     }
 
     return {
       location: location, // actual upload location, used for tests
       name: key_without_prefix, // filename in storage, consistent with other adapters
-      s3_response: response, // raw s3 response
       ...url ? { url: url } : {} // url (optionally presigned) or non-direct access url
     };
   }

spec/test.spec.js

@@ -897,7 +897,6 @@ describe('S3Adapter tests', () => {
       expect(result).toEqual({
         location: jasmine.any(String),
         name: 'file.txt',
-        s3_response: jasmine.any(Object),
         url: 'https://presigned-url.com/file.txt'
       });
     });
@@ -914,7 +913,7 @@ describe('S3Adapter tests', () => {
 
       await expectAsync(
         s3.createFile('file.txt', 'hello world', 'text/utf8', {})
-      ).toBeRejectedWithError('Generate key failed');
+      ).toBeRejectedWith('Generate key failed');
     });
   });