Adds specific error codes to certain ParseExceptions (#334)

Benjamin Wilson Friedman · web-flow · commit 82907cb718a3 · 2017-07-12T12:12:14.000-07:00
* Adds specific error codes to certain ParseExceptions

* lint!

* Added additional error codes, reviewed and corrected/removed others
diff --git a/src/Parse/Internal/ParseRelationOperation.php b/src/Parse/Internal/ParseRelationOperation.php
@@ -83,7 +83,7 @@ private function checkAndAssignClassName($objects)
                 $this->targetClassName = $object->getClassName();
             }
             if ($this->targetClassName != $object->getClassName()) {
-                throw new Exception('All objects in a relation must be of the same class.');
+                throw new Exception('All objects in a relation must be of the same class.', 103);
             }
         }
     }
@@ -155,7 +155,8 @@ public function _apply($oldValue, $object, $key)
                 throw new Exception(
                     'Related object object must be of class '
                     .$this->targetClassName.', but '.$oldValue->getTargetClass()
-                    .' was passed in.'
+                    .' was passed in.',
+                    103
                 );
             }
 
@@ -187,7 +188,8 @@ public function _mergeWithPrevious($previous)
                 throw new Exception(
                     'Related object object must be of class '
                     .$this->targetClassName.', but '.$previous->targetClassName
-                    .' was passed in.'
+                    .' was passed in.',
+                    103
                 );
             }
             $newRelationToAdd = self::convertToOneDimensionalArray(
diff --git a/src/Parse/ParseACL.php b/src/Parse/ParseACL.php
@@ -95,7 +95,7 @@ public static function _createACLFromJSON($data)
         $acl = new self();
         foreach ($data as $id => $permissions) {
             if (!is_string($id)) {
-                throw new Exception('Tried to create an ACL with an invalid userId.');
+                throw new Exception('Tried to create an ACL with an invalid userId.', 104);
             }
             foreach ($permissions as $accessType => $value) {
                 if ($accessType !== 'read' && $accessType !== 'write') {
@@ -169,7 +169,8 @@ private function setAccess($accessType, $userId, $allowed)
         }
         if (!is_string($userId)) {
             throw new ParseException(
-                'Invalid target for access control.'
+                'Invalid target for access control.',
+                104
             );
         }
         if (!isset($this->permissionsById[$userId])) {
@@ -219,7 +220,7 @@ private function getAccess($accessType, $userId)
     public function setReadAccess($userId, $allowed)
     {
         if (!$userId) {
-            throw new Exception('cannot setReadAccess for null userId');
+            throw new Exception('cannot setReadAccess for null userId', 104);
         }
         $this->setAccess('read', $userId, $allowed);
     }
@@ -239,7 +240,7 @@ public function setReadAccess($userId, $allowed)
     public function getReadAccess($userId)
     {
         if (!$userId) {
-            throw new Exception('cannot getReadAccess for null userId');
+            throw new Exception('cannot getReadAccess for null userId', 104);
         }
 
         return $this->getAccess('read', $userId);
@@ -256,7 +257,7 @@ public function getReadAccess($userId)
     public function setWriteAccess($userId, $allowed)
     {
         if (!$userId) {
-            throw new Exception('cannot setWriteAccess for null userId');
+            throw new Exception('cannot setWriteAccess for null userId', 104);
         }
         $this->setAccess('write', $userId, $allowed);
     }
@@ -276,7 +277,7 @@ public function setWriteAccess($userId, $allowed)
     public function getWriteAccess($userId)
     {
         if (!$userId) {
-            throw new Exception('cannot getWriteAccess for null userId');
+            throw new Exception('cannot getWriteAccess for null userId', 104);
         }
 
         return $this->getAccess('write', $userId);
@@ -333,7 +334,7 @@ public function getPublicWriteAccess()
     public function setUserReadAccess($user, $allowed)
     {
         if (!$user->getObjectId()) {
-            throw new Exception('cannot setReadAccess for a user with null id');
+            throw new Exception('cannot setReadAccess for a user with null id', 104);
         }
         $this->setReadAccess($user->getObjectId(), $allowed);
     }
@@ -353,7 +354,7 @@ public function setUserReadAccess($user, $allowed)
     public function getUserReadAccess($user)
     {
         if (!$user->getObjectId()) {
-            throw new Exception('cannot getReadAccess for a user with null id');
+            throw new Exception('cannot getReadAccess for a user with null id', 104);
         }
 
         return $this->getReadAccess($user->getObjectId());
@@ -370,7 +371,7 @@ public function getUserReadAccess($user)
     public function setUserWriteAccess($user, $allowed)
     {
         if (!$user->getObjectId()) {
-            throw new Exception('cannot setWriteAccess for a user with null id');
+            throw new Exception('cannot setWriteAccess for a user with null id', 104);
         }
         $this->setWriteAccess($user->getObjectId(), $allowed);
     }
@@ -390,7 +391,7 @@ public function setUserWriteAccess($user, $allowed)
     public function getUserWriteAccess($user)
     {
         if (!$user->getObjectId()) {
-            throw new Exception('cannot getWriteAccess for a user with null id');
+            throw new Exception('cannot getWriteAccess for a user with null id', 104);
         }
 
         return $this->getWriteAccess($user->getObjectId());
@@ -459,7 +460,8 @@ private static function validateRoleState($role)
     {
         if (!$role->getObjectId()) {
             throw new Exception(
-                'Roles must be saved to the server before they can be used in an ACL.'
+                'Roles must be saved to the server before they can be used in an ACL.',
+                104
             );
         }
     }
diff --git a/src/Parse/ParseClient.php b/src/Parse/ParseClient.php
@@ -628,7 +628,8 @@ private static function assertParseInitialized()
     {
         if (self::$applicationId === null) {
             throw new Exception(
-                'You must call ParseClient::initialize() before making any requests.'
+                'You must call ParseClient::initialize() before making any requests.',
+                109
             );
         }
     }
@@ -643,7 +644,8 @@ private static function assertAppInitialized()
         if (self::$accountKey === null || empty(self::$accountKey)) {
             throw new Exception(
                 'You must call ParseClient::initialize(..., $accountKey) before making any app requests. '.
-                'Your account key must not be null or empty.'
+                'Your account key must not be null or empty.',
+                109
             );
         }
     }
diff --git a/src/Parse/ParseFile.php b/src/Parse/ParseFile.php
@@ -56,7 +56,7 @@ public function getData()
             return $this->data;
         }
         if (!$this->url) {
-            throw new ParseException('Cannot retrieve data for unsaved ParseFile.');
+            throw new ParseException('Cannot retrieve data for unsaved ParseFile.', 151);
         }
         $this->data = $this->download();
 
@@ -93,7 +93,7 @@ public function getName()
     public function delete($useMasterKey = true)
     {
         if (!$this->url) {
-            throw new ParseException('Cannot delete file that has not been saved.');
+            throw new ParseException('Cannot delete file that has not been saved.', 151);
         }
 
         ParseClient::_request(
diff --git a/src/Parse/ParseObject.php b/src/Parse/ParseObject.php
@@ -110,7 +110,8 @@ public function __construct($className = null, $objectId = null, $isPointer = fa
         if (empty(self::$registeredSubclasses)) {
             throw new Exception(
                 'You must initialize the ParseClient using ParseClient::initialize '.
-                'and your Parse API keys before you can begin working with Objects.'
+                'and your Parse API keys before you can begin working with Objects.',
+                109
             );
         }
         $subclass = static::getSubclass();
@@ -163,7 +164,7 @@ public function __set($key, $value)
         ) {
             $this->set($key, $value);
         } else {
-            throw new Exception('Protected field could not be set.');
+            throw new Exception('Protected field could not be set.', 139);
         }
     }
 
@@ -576,9 +577,9 @@ private static function toObjectIdArray(array $objects)
         for ($i = 0; $i < $count; ++$i) {
             $obj = $objects[$i];
             if ($obj->getClassName() !== $className) {
-                throw new ParseException('All objects should be of the same class.');
+                throw new ParseException('All objects should be of the same class.', 103);
             } elseif (!$obj->getObjectId()) {
-                throw new ParseException('All objects must have an ID.');
+                throw new ParseException('All objects must have an ID.', 104);
             }
             array_push($objectIds, $obj->getObjectId());
         }
@@ -604,7 +605,7 @@ private static function updateWithFetchedResults(array $objects, array $fetched)
         for ($i = 0; $i < $count; ++$i) {
             $obj = $objects[$i];
             if (!isset($fetchedObjectsById[$obj->getObjectId()])) {
-                throw new ParseException('All objects must exist on the server.');
+                throw new ParseException('All objects must exist on the server.', 101);
             }
             $obj->mergeFromObject($fetchedObjectsById[$obj->getObjectId()]);
         }
@@ -1279,7 +1280,7 @@ public function getRelation($key, $className = null)
     public function _toPointer()
     {
         if (!$this->objectId) {
-            throw new Exception("Can't serialize an unsaved Parse.Object");
+            throw new Exception("Can't serialize an unsaved ParseObject", 104);
         }
 
         return [
diff --git a/src/Parse/ParsePush.php b/src/Parse/ParsePush.php
@@ -40,7 +40,8 @@ public static function send($data, $useMasterKey = false)
             && isset($data['expiration_interval'])
         ) {
             throw new Exception(
-                'Both expiration_time and expiration_interval can\'t be set.'
+                'Both expiration_time and expiration_interval can\'t be set.',
+                138
             );
         }
         if (isset($data['where'])) {
@@ -54,7 +55,8 @@ public static function send($data, $useMasterKey = false)
                 }
             } else {
                 throw new Exception(
-                    'Where parameter for Parse Push must be of type ParseQuery'
+                    'Where parameter for Parse Push must be of type ParseQuery',
+                    111
                 );
             }
         }
diff --git a/src/Parse/ParseQuery.php b/src/Parse/ParseQuery.php
@@ -865,7 +865,7 @@ public static function orQueries($queryObjects)
                 $className = $queryObjects[$i]->className;
             }
             if ($className != $queryObjects[$i]->className) {
-                throw new Exception('All queries must be for the same class');
+                throw new Exception('All queries must be for the same class', 103);
             }
         }
         $query = new self($className);
diff --git a/src/Parse/ParseRole.php b/src/Parse/ParseRole.php
@@ -57,14 +57,10 @@ public function getName()
     public function setName($name)
     {
         if ($this->getObjectId()) {
-            throw new ParseException(
-                "A role's name can only be set before it has been saved."
-            );
+            throw new ParseException("A role's name can only be set before it has been saved.");
         }
         if (!is_string($name)) {
-            throw new ParseException(
-                "A role's name must be a string."
-            );
+            throw new ParseException("A role's name must be a string.", 139);
         }
 
         return $this->set('name', $name);
@@ -104,22 +100,18 @@ public function getRoles()
     public function save($useMasterKey = false)
     {
         if (!$this->getACL()) {
-            throw new ParseException(
-                'Roles must have an ACL.'
-            );
+            throw new ParseException('Roles must have an ACL.', 123);
         }
         if (!$this->getName() || !is_string($this->getName())) {
-            throw new ParseException(
-                'Roles must have a name.'
-            );
+            throw new ParseException('Roles must have a name.', 139);
         }
         if ($this->getObjectId() === null) {
             // Not yet saved, verify this name is not taken
             // ParseServer does not validate duplicate role names as of parse-server v2.3.2
             $query = new ParseQuery('_Role');
             $query->equalTo('name', $this->getName());
             if ($query->count(true) > 0) {
-                throw new ParseException("Cannot add duplicate role name of '{$this->getName()}'");
+                throw new ParseException("Cannot add duplicate role name of '{$this->getName()}'", 137);
             }
         }
 
diff --git a/src/Parse/ParseSchema.php b/src/Parse/ParseSchema.php
diff --git a/src/Parse/ParseUser.php b/src/Parse/ParseUser.php
diff --git a/tests/Parse/ParseObjectTest.php b/tests/Parse/ParseObjectTest.php
diff --git a/tests/Parse/ParseSchemaTest.php b/tests/Parse/ParseSchemaTest.php

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ private function checkAndAssignClassName($objects)`
`83`	`83`	`$this->targetClassName = $object->getClassName();`
`84`	`84`	`}`
`85`	`85`	`if ($this->targetClassName != $object->getClassName()) {`
`86`		`- throw new Exception('All objects in a relation must be of the same class.');`
	`86`	`+ throw new Exception('All objects in a relation must be of the same class.', 103);`
`87`	`87`	`}`
`88`	`88`	`}`
`89`	`89`	`}`
`@@ -155,7 +155,8 @@ public function _apply($oldValue, $object, $key)`
`155`	`155`	`throw new Exception(`
`156`	`156`	`'Related object object must be of class '`
`157`	`157`	`.$this->targetClassName.', but '.$oldValue->getTargetClass()`
`158`		`- .' was passed in.'`
	`158`	`+ .' was passed in.',`
	`159`	`+ 103`
`159`	`160`	`);`
`160`	`161`	`}`
`161`	`162`
`@@ -187,7 +188,8 @@ public function _mergeWithPrevious($previous)`
`187`	`188`	`throw new Exception(`
`188`	`189`	`'Related object object must be of class '`
`189`	`190`	`.$this->targetClassName.', but '.$previous->targetClassName`
`190`		`- .' was passed in.'`
	`191`	`+ .' was passed in.',`
	`192`	`+ 103`
`191`	`193`	`);`
`192`	`194`	`}`
`193`	`195`	`$newRelationToAdd = self::convertToOneDimensionalArray(`
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ public static function _createACLFromJSON($data)`
`95`	`95`	`$acl = new self();`
`96`	`96`	`foreach ($data as $id => $permissions) {`
`97`	`97`	`if (!is_string($id)) {`
`98`		`- throw new Exception('Tried to create an ACL with an invalid userId.');`
	`98`	`+ throw new Exception('Tried to create an ACL with an invalid userId.', 104);`
`99`	`99`	`}`
`100`	`100`	`foreach ($permissions as $accessType => $value) {`
`101`	`101`	`if ($accessType !== 'read' && $accessType !== 'write') {`
`@@ -169,7 +169,8 @@ private function setAccess($accessType, $userId, $allowed)`
`169`	`169`	`}`
`170`	`170`	`if (!is_string($userId)) {`
`171`	`171`	`throw new ParseException(`
`172`		`- 'Invalid target for access control.'`
	`172`	`+ 'Invalid target for access control.',`
	`173`	`+ 104`
`173`	`174`	`);`
`174`	`175`	`}`
`175`	`176`	`if (!isset($this->permissionsById[$userId])) {`
`@@ -219,7 +220,7 @@ private function getAccess($accessType, $userId)`
`219`	`220`	`public function setReadAccess($userId, $allowed)`
`220`	`221`	`{`
`221`	`222`	`if (!$userId) {`
`222`		`- throw new Exception('cannot setReadAccess for null userId');`
	`223`	`+ throw new Exception('cannot setReadAccess for null userId', 104);`
`223`	`224`	`}`
`224`	`225`	`$this->setAccess('read', $userId, $allowed);`
`225`	`226`	`}`
`@@ -239,7 +240,7 @@ public function setReadAccess($userId, $allowed)`
`239`	`240`	`public function getReadAccess($userId)`
`240`	`241`	`{`
`241`	`242`	`if (!$userId) {`
`242`		`- throw new Exception('cannot getReadAccess for null userId');`
	`243`	`+ throw new Exception('cannot getReadAccess for null userId', 104);`
`243`	`244`	`}`
`244`	`245`
`245`	`246`	`return $this->getAccess('read', $userId);`
`@@ -256,7 +257,7 @@ public function getReadAccess($userId)`
`256`	`257`	`public function setWriteAccess($userId, $allowed)`
`257`	`258`	`{`
`258`	`259`	`if (!$userId) {`
`259`		`- throw new Exception('cannot setWriteAccess for null userId');`
	`260`	`+ throw new Exception('cannot setWriteAccess for null userId', 104);`
`260`	`261`	`}`
`261`	`262`	`$this->setAccess('write', $userId, $allowed);`
`262`	`263`	`}`
`@@ -276,7 +277,7 @@ public function setWriteAccess($userId, $allowed)`
`276`	`277`	`public function getWriteAccess($userId)`
`277`	`278`	`{`
`278`	`279`	`if (!$userId) {`
`279`		`- throw new Exception('cannot getWriteAccess for null userId');`
	`280`	`+ throw new Exception('cannot getWriteAccess for null userId', 104);`
`280`	`281`	`}`
`281`	`282`
`282`	`283`	`return $this->getAccess('write', $userId);`
`@@ -333,7 +334,7 @@ public function getPublicWriteAccess()`
`333`	`334`	`public function setUserReadAccess($user, $allowed)`
`334`	`335`	`{`
`335`	`336`	`if (!$user->getObjectId()) {`
`336`		`- throw new Exception('cannot setReadAccess for a user with null id');`
	`337`	`+ throw new Exception('cannot setReadAccess for a user with null id', 104);`
`337`	`338`	`}`
`338`	`339`	`$this->setReadAccess($user->getObjectId(), $allowed);`
`339`	`340`	`}`
`@@ -353,7 +354,7 @@ public function setUserReadAccess($user, $allowed)`
`353`	`354`	`public function getUserReadAccess($user)`
`354`	`355`	`{`
`355`	`356`	`if (!$user->getObjectId()) {`
`356`		`- throw new Exception('cannot getReadAccess for a user with null id');`
	`357`	`+ throw new Exception('cannot getReadAccess for a user with null id', 104);`
`357`	`358`	`}`
`358`	`359`
`359`	`360`	`return $this->getReadAccess($user->getObjectId());`
`@@ -370,7 +371,7 @@ public function getUserReadAccess($user)`
`370`	`371`	`public function setUserWriteAccess($user, $allowed)`
`371`	`372`	`{`
`372`	`373`	`if (!$user->getObjectId()) {`
`373`		`- throw new Exception('cannot setWriteAccess for a user with null id');`
	`374`	`+ throw new Exception('cannot setWriteAccess for a user with null id', 104);`
`374`	`375`	`}`
`375`	`376`	`$this->setWriteAccess($user->getObjectId(), $allowed);`
`376`	`377`	`}`
`@@ -390,7 +391,7 @@ public function setUserWriteAccess($user, $allowed)`
`390`	`391`	`public function getUserWriteAccess($user)`
`391`	`392`	`{`
`392`	`393`	`if (!$user->getObjectId()) {`
`393`		`- throw new Exception('cannot getWriteAccess for a user with null id');`
	`394`	`+ throw new Exception('cannot getWriteAccess for a user with null id', 104);`
`394`	`395`	`}`
`395`	`396`
`396`	`397`	`return $this->getWriteAccess($user->getObjectId());`
`@@ -459,7 +460,8 @@ private static function validateRoleState($role)`
`459`	`460`	`{`
`460`	`461`	`if (!$role->getObjectId()) {`
`461`	`462`	`throw new Exception(`
`462`		`- 'Roles must be saved to the server before they can be used in an ACL.'`
	`463`	`+ 'Roles must be saved to the server before they can be used in an ACL.',`
	`464`	`+ 104`
`463`	`465`	`);`
`464`	`466`	`}`
`465`	`467`	`}`
Original file line number	Diff line number	Diff line change
`@@ -628,7 +628,8 @@ private static function assertParseInitialized()`
`628`	`628`	`{`
`629`	`629`	`if (self::$applicationId === null) {`
`630`	`630`	`throw new Exception(`
`631`		`- 'You must call ParseClient::initialize() before making any requests.'`
	`631`	`+ 'You must call ParseClient::initialize() before making any requests.',`
	`632`	`+ 109`
`632`	`633`	`);`
`633`	`634`	`}`
`634`	`635`	`}`
`@@ -643,7 +644,8 @@ private static function assertAppInitialized()`
`643`	`644`	`if (self::$accountKey === null \|\| empty(self::$accountKey)) {`
`644`	`645`	`throw new Exception(`
`645`	`646`	`'You must call ParseClient::initialize(..., $accountKey) before making any app requests. '.`
`646`		`- 'Your account key must not be null or empty.'`
	`647`	`+ 'Your account key must not be null or empty.',`
	`648`	`+ 109`
`647`	`649`	`);`
`648`	`650`	`}`
`649`	`651`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public function getData()`
`56`	`56`	`return $this->data;`
`57`	`57`	`}`
`58`	`58`	`if (!$this->url) {`
`59`		`- throw new ParseException('Cannot retrieve data for unsaved ParseFile.');`
	`59`	`+ throw new ParseException('Cannot retrieve data for unsaved ParseFile.', 151);`
`60`	`60`	`}`
`61`	`61`	`$this->data = $this->download();`
`62`	`62`
`@@ -93,7 +93,7 @@ public function getName()`
`93`	`93`	`public function delete($useMasterKey = true)`
`94`	`94`	`{`
`95`	`95`	`if (!$this->url) {`
`96`		`- throw new ParseException('Cannot delete file that has not been saved.');`
	`96`	`+ throw new ParseException('Cannot delete file that has not been saved.', 151);`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`ParseClient::_request(`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,8 @@ public function __construct($className = null, $objectId = null, $isPointer = fa`
`110`	`110`	`if (empty(self::$registeredSubclasses)) {`
`111`	`111`	`throw new Exception(`
`112`	`112`	`'You must initialize the ParseClient using ParseClient::initialize '.`
`113`		`- 'and your Parse API keys before you can begin working with Objects.'`
	`113`	`+ 'and your Parse API keys before you can begin working with Objects.',`
	`114`	`+ 109`
`114`	`115`	`);`
`115`	`116`	`}`
`116`	`117`	`$subclass = static::getSubclass();`
`@@ -163,7 +164,7 @@ public function __set($key, $value)`
`163`	`164`	`) {`
`164`	`165`	`$this->set($key, $value);`
`165`	`166`	`} else {`
`166`		`- throw new Exception('Protected field could not be set.');`
	`167`	`+ throw new Exception('Protected field could not be set.', 139);`
`167`	`168`	`}`
`168`	`169`	`}`
`169`	`170`
`@@ -576,9 +577,9 @@ private static function toObjectIdArray(array $objects)`
`576`	`577`	`for ($i = 0; $i < $count; ++$i) {`
`577`	`578`	`$obj = $objects[$i];`
`578`	`579`	`if ($obj->getClassName() !== $className) {`
`579`		`- throw new ParseException('All objects should be of the same class.');`
	`580`	`+ throw new ParseException('All objects should be of the same class.', 103);`
`580`	`581`	`} elseif (!$obj->getObjectId()) {`
`581`		`- throw new ParseException('All objects must have an ID.');`
	`582`	`+ throw new ParseException('All objects must have an ID.', 104);`
`582`	`583`	`}`
`583`	`584`	`array_push($objectIds, $obj->getObjectId());`
`584`	`585`	`}`
`@@ -604,7 +605,7 @@ private static function updateWithFetchedResults(array $objects, array $fetched)`
`604`	`605`	`for ($i = 0; $i < $count; ++$i) {`
`605`	`606`	`$obj = $objects[$i];`
`606`	`607`	`if (!isset($fetchedObjectsById[$obj->getObjectId()])) {`
`607`		`- throw new ParseException('All objects must exist on the server.');`
	`608`	`+ throw new ParseException('All objects must exist on the server.', 101);`
`608`	`609`	`}`
`609`	`610`	`$obj->mergeFromObject($fetchedObjectsById[$obj->getObjectId()]);`
`610`	`611`	`}`
`@@ -1279,7 +1280,7 @@ public function getRelation($key, $className = null)`
`1279`	`1280`	`public function _toPointer()`
`1280`	`1281`	`{`
`1281`	`1282`	`if (!$this->objectId) {`
`1282`		`- throw new Exception("Can't serialize an unsaved Parse.Object");`
	`1283`	`+ throw new Exception("Can't serialize an unsaved ParseObject", 104);`
`1283`	`1284`	`}`
`1284`	`1285`
`1285`	`1286`	`return [`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,8 @@ public static function send($data, $useMasterKey = false)`
`40`	`40`	`&& isset($data['expiration_interval'])`
`41`	`41`	`) {`
`42`	`42`	`throw new Exception(`
`43`		`- 'Both expiration_time and expiration_interval can\'t be set.'`
	`43`	`+ 'Both expiration_time and expiration_interval can\'t be set.',`
	`44`	`+ 138`
`44`	`45`	`);`
`45`	`46`	`}`
`46`	`47`	`if (isset($data['where'])) {`
`@@ -54,7 +55,8 @@ public static function send($data, $useMasterKey = false)`
`54`	`55`	`}`
`55`	`56`	`} else {`
`56`	`57`	`throw new Exception(`
`57`		`- 'Where parameter for Parse Push must be of type ParseQuery'`
	`58`	`+ 'Where parameter for Parse Push must be of type ParseQuery',`
	`59`	`+ 111`
`58`	`60`	`);`
`59`	`61`	`}`
`60`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -865,7 +865,7 @@ public static function orQueries($queryObjects)`
`865`	`865`	`$className = $queryObjects[$i]->className;`
`866`	`866`	`}`
`867`	`867`	`if ($className != $queryObjects[$i]->className) {`
`868`		`- throw new Exception('All queries must be for the same class');`
	`868`	`+ throw new Exception('All queries must be for the same class', 103);`
`869`	`869`	`}`
`870`	`870`	`}`
`871`	`871`	`$query = new self($className);`
Original file line number	Diff line number	Diff line change
`@@ -57,14 +57,10 @@ public function getName()`
`57`	`57`	`public function setName($name)`
`58`	`58`	`{`
`59`	`59`	`if ($this->getObjectId()) {`
`60`		`- throw new ParseException(`
`61`		`- "A role's name can only be set before it has been saved."`
`62`		`- );`
	`60`	`+ throw new ParseException("A role's name can only be set before it has been saved.");`
`63`	`61`	`}`
`64`	`62`	`if (!is_string($name)) {`
`65`		`- throw new ParseException(`
`66`		`- "A role's name must be a string."`
`67`		`- );`
	`63`	`+ throw new ParseException("A role's name must be a string.", 139);`
`68`	`64`	`}`
`69`	`65`
`70`	`66`	`return $this->set('name', $name);`
`@@ -104,22 +100,18 @@ public function getRoles()`
`104`	`100`	`public function save($useMasterKey = false)`
`105`	`101`	`{`
`106`	`102`	`if (!$this->getACL()) {`
`107`		`- throw new ParseException(`
`108`		`- 'Roles must have an ACL.'`
`109`		`- );`
	`103`	`+ throw new ParseException('Roles must have an ACL.', 123);`
`110`	`104`	`}`
`111`	`105`	`if (!$this->getName() \|\| !is_string($this->getName())) {`
`112`		`- throw new ParseException(`
`113`		`- 'Roles must have a name.'`
`114`		`- );`
	`106`	`+ throw new ParseException('Roles must have a name.', 139);`
`115`	`107`	`}`
`116`	`108`	`if ($this->getObjectId() === null) {`
`117`	`109`	`// Not yet saved, verify this name is not taken`
`118`	`110`	`// ParseServer does not validate duplicate role names as of parse-server v2.3.2`
`119`	`111`	`$query = new ParseQuery('_Role');`
`120`	`112`	`$query->equalTo('name', $this->getName());`
`121`	`113`	`if ($query->count(true) > 0) {`
`122`		`- throw new ParseException("Cannot add duplicate role name of '{$this->getName()}'");`
	`114`	`+ throw new ParseException("Cannot add duplicate role name of '{$this->getName()}'", 137);`
`123`	`115`	`}`
`124`	`116`	`}`
`125`	`117`