ci: Optimize CI workflow performance (#1724)

dplewis · web-flow · commit af750cf03b94 · 2023-03-10T15:31:46.000+01:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,213 +1,114 @@
+---
 name: ci
 on:
   push:
-    branches: [ master ]
+    branches:
+      - master
   pull_request:
-    branches: [ '**' ]
+    branches:
+      - "**"
 env:
-  CI_XCODE_11: '/Applications/Xcode_11.7.app/Contents/Developer'
-  CI_XCODE_13: '/Applications/Xcode_13.4.1.app/Contents/Developer'
-
+  CI_XCODE_11: /Applications/Xcode_11.7.app/Contents/Developer
+  CI_XCODE_14: /Applications/Xcode_14.2.app/Contents/Developer
 jobs:
-  ios:
-    runs-on: macos-12
-    steps:
-    - uses: actions/checkout@v2
-    - name: Setup Ruby
-      uses: ruby/setup-ruby@359bebbc29cbe6c87da6bc9ea3bc930432750108
-    - name: Cache Gems
-      id: cache-gems
-      uses: actions/cache@v2
-      with:
-        path: vendor/bundle
-        key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
-        restore-keys: |
-          ${{ runner.os }}-gem-
-    - name: Submodules and Bundle Install
-      run: |
-        git submodule update --init --recursive
-        sudo gem install bundler
-        bundle config set path 'vendor/bundle'
-        bundle install
-    - name: Build-Test
-      run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake test:ios
-      env:
-        DEVELOPER_DIR: ${{ env.CI_XCODE_13 }}
-    - name: Send codecov
-      run: bash <(curl https://codecov.io/bash)
-
-  macos:
-    runs-on: macos-latest
-    steps:
-    - uses: actions/checkout@v2
-    - name: Setup Ruby
-      uses: ruby/setup-ruby@359bebbc29cbe6c87da6bc9ea3bc930432750108
-    - name: Cache Gems
-      id: cache-gems
-      uses: actions/cache@v2
-      with:
-        path: vendor/bundle
-        key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
-        restore-keys: |
-          ${{ runner.os }}-gem-
-    - name: Submodules and Bundle Install
-      run: |
-        git submodule update --init --recursive
-        sudo gem install bundler
-        bundle config set path 'vendor/bundle'
-        bundle install
-    - name: Create and set the default keychain
-      run: |
-        security create-keychain -p "" temporary
-        security default-keychain -s temporary
-        security unlock-keychain -p "" temporary
-        security set-keychain-settings -lut 7200 temporary
-    - name: Build-Test
-      run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake test:macos
-      env:
-        DEVELOPER_DIR: ${{ env.CI_XCODE_13 }}
-    - name: Send codecov
-      run: bash <(curl https://codecov.io/bash)
-
-  facebook_utils:
-    needs: parseui
-    runs-on: macos-latest
-    env:
-      GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-    steps:
-    - uses: actions/checkout@v2
-    - name: Setup Ruby
-      uses: ruby/setup-ruby@359bebbc29cbe6c87da6bc9ea3bc930432750108
-    - name: Cache Gems
-      id: cache-gems
-      uses: actions/cache@v2
-      with:
-        path: vendor/bundle
-        key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
-        restore-keys: |
-          ${{ runner.os }}-gem-
-    - name: Submodules and Bundle Install          
-      run: |
-        git submodule update --init --recursive
-        sudo gem install bundler
-        bundle config set path 'vendor/bundle'
-        bundle install
-        carthage bootstrap --use-xcframeworks
-    - name: Build-Test
-      run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake test:facebook_utils:ios
-      env:
-        DEVELOPER_DIR: ${{ env.CI_XCODE_13 }}
-    - name: Send codecov
-      run: bash <(curl https://codecov.io/bash)
-
-  twitter_utils:
-    needs: parseui
-    runs-on: macos-latest
-    steps:
-    - uses: actions/checkout@v2
-    - name: Setup Ruby
-      uses: ruby/setup-ruby@359bebbc29cbe6c87da6bc9ea3bc930432750108
-    - name: Cache Gems
-      id: cache-gems
-      uses: actions/cache@v2
-      with:
-        path: vendor/bundle
-        key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
-        restore-keys: |
-          ${{ runner.os }}-gem-
-    - name: Submodules and Bundle Install
-      run: |
-        git submodule update --init --recursive
-        sudo gem install bundler
-        bundle config set path 'vendor/bundle'
-        bundle install
-    - name: Build-Test
-      run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake test:twitter_utils:ios
-      env:
-        DEVELOPER_DIR: ${{ env.CI_XCODE_13 }}
-    - name: Send codecov
-      run: bash <(curl https://codecov.io/bash)
-
-  parseui:
-    runs-on: macos-latest
-    env:
-      GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-    steps:
-    - uses: actions/checkout@v2
-    - name: Setup Ruby
-      uses: ruby/setup-ruby@359bebbc29cbe6c87da6bc9ea3bc930432750108
-    - name: Cache Gems
-      id: cache-gems
-      uses: actions/cache@v2
-      with:
-        path: vendor/bundle
-        key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
-        restore-keys: |
-          ${{ runner.os }}-gem-
-    - name: Submodules and Bundle Install
-      run: |
-        git submodule update --init --recursive
-        sudo gem install bundler
-        bundle config set path 'vendor/bundle'
-        bundle install
-        carthage bootstrap --use-xcframeworks
-    - name: Build-Test
-      env:
-        DEVELOPER_DIR: ${{ env.CI_XCODE_13 }}
-      run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake test:parseui:all
-    - name: Send codecov
-      run: bash <(curl https://codecov.io/bash)
-
-  assets:
-    runs-on: macos-11
+  tests:
     env:
       GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+    timeout-minutes: 60
+    strategy:
+      matrix:
+        script:
+          - test:ios
+          - test:macos
+          - test:facebook_utils:ios
+          - test:twitter_utils:ios
+          - test:parseui:all
+          - package:release
+      fail-fast: false
+    runs-on: ${{ (matrix.script == 'package:release' && 'macos-11') || 'macos-12' }}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Setup Ruby
         uses: ruby/setup-ruby@359bebbc29cbe6c87da6bc9ea3bc930432750108
       - name: Cache Gems
         id: cache-gems
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           path: vendor/bundle
           key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
           restore-keys: |
             ${{ runner.os }}-gem-
-      - name: Submodules and Bundle Install
+      - name: Create and set the default keychain
+        run: |
+          security create-keychain -p "" temporary
+          security default-keychain -s temporary
+          security unlock-keychain -p "" temporary
+          security set-keychain-settings -lut 7200 temporary
+      - name: Submodules
         run: |
           git submodule update --init --recursive
           sudo gem install bundler
           bundle config set path 'vendor/bundle'
-          bundle install
+      - name: Bundle Install
+        if: steps.cache-gems.outputs.cache-hit != 'true'
+        run: bundle install
+      - name: Cache Carthage
+        uses: actions/cache@v3
+        id: carthage-cache
+        with:
+          path: Carthage
+          key: ${{ runner.os }}-carthage-${{ hashFiles('**/Cartfile.resolved') }}
+          restore-keys: |
+            ${{ runner.os }}-carthage-
+      - name: Carthage
+        if: ${{ steps.carthage-cache.outputs.cache-hit != 'true' }}
+        run: |
           carthage bootstrap --use-xcframeworks
-      - name: Build Release
-        run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake package:release
+      - name: Build-Test
+        run: set -o pipefail && env NSUnbufferedIO=YES bundle exec rake ${{ matrix.script }}
         env:
-          DEVELOPER_DIR: ${{ env.CI_XCODE_11 }}
-
+          DEVELOPER_DIR: ${{ (matrix.script == 'package:release' && env.CI_XCODE_11) || env.CI_XCODE_14 }}
+      - name: Get Artifact Name
+        if: ${{ always() }}
+        env:
+          ARTIFACT_NAME: ${{ matrix.script }}-logs
+        run: |
+          ARTIFACT_NAME=${{ env.ARTIFACT_NAME }}
+          echo ARTIFACT_NAME=${ARTIFACT_NAME//:/-} >> $GITHUB_ENV # replace colon with dashes
+      - name: Upload Artifact Logs
+        if: ${{ always() }}
+        uses: actions/upload-artifact@v3
+        with:
+          name: ${{ env.ARTIFACT_NAME }}
+          path: |
+            ~/Library/Logs/DiagnosticReports
+            ~/Library/Developer/Xcode/DerivedData/Parse-*/Logs/Test
+      - name: Send Codecov
+        run: bash <(curl https://codecov.io/bash)
   docs:
-    runs-on: macos-latest
+    runs-on: macos-12
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Setup Ruby
         uses: ruby/setup-ruby@359bebbc29cbe6c87da6bc9ea3bc930432750108
       - name: Cache Gems
         id: cache-gems
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           path: vendor/bundle
           key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
           restore-keys: |
             ${{ runner.os }}-gem-
-      - name: Submodules and Bundle Instal
+      - name: Submodules
         run: |
           git submodule update --init --recursive
           sudo gem install bundler
           bundle config path vendor/bundle
-          bundle install
+      - name: Bundle Install
+        if: steps.cache-gems.outputs.cache-hit != 'true'
+        run: bundle install
       - name: Create Jazzy Docs
         run: |
           ./Scripts/jazzy.sh
         env:
-          DEVELOPER_DIR: ${{ env.CI_XCODE_13 }}
+          DEVELOPER_DIR: ${{ env.CI_XCODE_14 }}
diff --git a/.github/workflows/release-manual-docs.yml b/.github/workflows/release-manual-docs.yml
@@ -6,12 +6,12 @@ on:
         default: ''
         description: 'Version tag:' 
 env:
-  CI_XCODE_13: '/Applications/Xcode_13.4.1.app/Contents/Developer'
+  CI_XCODE_14: '/Applications/Xcode_14.2.app/Contents/Developer'
 
 jobs:
   publish-docs:
     if: github.event.inputs.tag != ''
-    runs-on: macos-11
+    runs-on: macos-12
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3
@@ -21,7 +21,7 @@ jobs:
         uses: ruby/setup-ruby@359bebbc29cbe6c87da6bc9ea3bc930432750108
       - name: Cache Gems
         id: cache-gems
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           path: vendor/bundle
           key: ${{ runner.os }}-gem-${{ hashFiles('**/Gemfile.lock') }}
@@ -37,7 +37,7 @@ jobs:
         run: |
           ./Scripts/jazzy.sh
         env:
-          DEVELOPER_DIR: ${{ env.CI_XCODE_13 }}
+          DEVELOPER_DIR: ${{ env.CI_XCODE_14 }}
       - name: Deploy Jazzy Docs
         uses: peaceiris/actions-gh-pages@v3
         with:
diff --git a/Parse.xcworkspace/xcshareddata/swiftpm/Package.resolved b/Parse.xcworkspace/xcshareddata/swiftpm/Package.resolved
diff --git a/Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-iOS.xcscheme b/Parse/Parse.xcodeproj/xcshareddata/xcschemes/Parse-iOS.xcscheme
@@ -75,6 +75,12 @@
                ReferencedContainer = "container:Parse.xcodeproj">
             </BuildableReference>
             <SkippedTests>
+               <Test
+                  Identifier = "ExtensionDataSharingMobileTests">
+               </Test>
+               <Test
+                  Identifier = "ExtensionDataSharingTests">
+               </Test>
                <Test
                   Identifier = "PFTestCase">
                </Test>
diff --git a/Rakefile b/Rakefile
@@ -15,7 +15,7 @@ build_folder = File.join(script_folder, 'build')
 release_folder = File.join(build_folder, 'release')
 bolts_build_folder = File.join(script_folder, 'Carthage', 'Build')
 bolts_folder = File.join(script_folder, 'Carthage', 'Checkouts', 'Bolts-ObjC')
-ios_simulator = 'platform="iOS Simulator",name="iPhone 11"'
+ios_simulator = 'platform="iOS Simulator",name="iPhone 14"'
 tvos_simulator = 'platform="tvOS Simulator",name="Apple TV 4K"'
 
 module Constants
@@ -467,7 +467,7 @@ namespace :test do
                                "GCC_GENERATE_TEST_COVERAGE_FILES" => "YES" }
 
       t.actions = [XCTask::BuildAction::TEST]
-      t.formatter = XCTask::BuildFormatter::XCPRETTY
+      t.formatter = XCTask::BuildFormatter::XCODEBUILD
     end
     unless task.execute
       puts 'iOS Tests Failed!'
@@ -488,7 +488,7 @@ namespace :test do
                                "GCC_GENERATE_TEST_COVERAGE_FILES" => "YES" }
 
       t.actions = [XCTask::BuildAction::TEST]
-      t.formatter = XCTask::BuildFormatter::XCPRETTY
+      t.formatter = XCTask::BuildFormatter::XCODEBUILD
     end
     unless task.execute
       puts 'macOS Tests Failed!'
@@ -511,7 +511,7 @@ namespace :test do
                                  "GCC_GENERATE_TEST_COVERAGE_FILES" => "YES" }
 
         t.actions = [XCTask::BuildAction::TEST]
-        t.formatter = XCTask::BuildFormatter::XCPRETTY
+        t.formatter = XCTask::BuildFormatter::XCODEBUILD
       end
 
       result = task.execute
@@ -537,7 +537,7 @@ namespace :test do
                                  "GCC_GENERATE_TEST_COVERAGE_FILES" => "YES" }
 
         t.actions = [XCTask::BuildAction::TEST]
-        t.formatter = XCTask::BuildFormatter::XCPRETTY
+        t.formatter = XCTask::BuildFormatter::XCODEBUILD
       end
 
       result = task.execute
@@ -565,7 +565,7 @@ namespace :test do
         t.configuration = 'Debug'
 
         t.actions = [XCTask::BuildAction::TEST]
-        t.formatter = XCTask::BuildFormatter::XCPRETTY
+        t.formatter = XCTask::BuildFormatter::XCODEBUILD
       end
 
       result = task.execute
