Merge pull request #728 from ParsePlatform/nlutsenko.initializers

Improve designated initializer flow for all classes with custom initializers.

Author: nlutsenko

Parse/Internal/Analytics/Controller/PFAnalyticsController.h

@@ -27,6 +27,8 @@ NS_ASSUME_NONNULL_BEGIN
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFEventuallyQueueProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 
 + (instancetype)controllerWithDataSource:(id<PFEventuallyQueueProvider>)dataSource;

Parse/Internal/Analytics/Controller/PFAnalyticsController.m

@@ -27,10 +27,6 @@ @implementation PFAnalyticsController
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFEventuallyQueueProvider>)dataSource {
     self = [super init];
     if (!self) return nil;

Parse/Internal/CloudCode/PFCloudCodeController.h

@@ -23,6 +23,8 @@
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithDataSource:(id<PFCommandRunnerProvider>)dataSource NS_DESIGNATED_INITIALIZER;
 
 + (instancetype)controllerWithDataSource:(id<PFCommandRunnerProvider>)dataSource;

Parse/Internal/CloudCode/PFCloudCodeController.m

@@ -22,11 +22,7 @@ @implementation PFCloudCodeController
 
 ///--------------------------------------
 #pragma mark - Init
-///--------------------------------------
-
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
+///--------------------------------------s
 
 - (instancetype)initWithDataSource:(id<PFCommandRunnerProvider>)dataSource {
     self = [super init];

Parse/Internal/Commands/CommandRunner/URLRequestConstructor/PFCommandURLRequestConstructor.h

@@ -26,6 +26,8 @@
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 + (instancetype)constructorWithDataSource:(id<PFInstallationIdentifierStoreProvider>)dataSource serverURL:(NSURL *)serverURL;
 
 ///--------------------------------------

Parse/Internal/Commands/CommandRunner/URLRequestConstructor/PFCommandURLRequestConstructor.m

@@ -27,10 +27,6 @@ @implementation PFCommandURLRequestConstructor
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFInstallationIdentifierStoreProvider>)dataSource serverURL:(NSURL *)serverURL {
     self = [super init];
     if (!self) return nil;

Parse/Internal/Commands/CommandRunner/URLSession/PFURLSessionCommandRunner.h

@@ -16,6 +16,7 @@ NS_ASSUME_NONNULL_BEGIN
 @interface PFURLSessionCommandRunner : NSObject <PFCommandRunning>
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
 
 + (instancetype)commandRunnerWithDataSource:(id<PFInstallationIdentifierStoreProvider>)dataSource
                               retryAttempts:(NSUInteger)retryAttempts

Parse/Internal/Commands/CommandRunner/URLSession/PFURLSessionCommandRunner.m

@@ -48,10 +48,6 @@ @implementation PFURLSessionCommandRunner
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithDataSource:(id<PFInstallationIdentifierStoreProvider>)dataSource
                      applicationId:(NSString *)applicationId
                          clientKey:(NSString *)clientKey

Parse/Internal/Commands/CommandRunner/URLSession/Session/PFURLSession.h

@@ -37,6 +37,8 @@ NS_ASSUME_NONNULL_BEGIN
 ///--------------------------------------
 
 - (instancetype)init NS_UNAVAILABLE;
++ (instancetype)new NS_UNAVAILABLE;
+
 - (instancetype)initWithConfiguration:(NSURLSessionConfiguration *)configuration
                              delegate:(id<PFURLSessionDelegate>)delegate NS_DESIGNATED_INITIALIZER;
 

Parse/Internal/Commands/CommandRunner/URLSession/Session/PFURLSession.m

@@ -37,10 +37,6 @@ @implementation PFURLSession
 #pragma mark - Init
 ///--------------------------------------
 
-- (instancetype)init {
-    PFNotDesignatedInitializer();
-}
-
 - (instancetype)initWithConfiguration:(NSURLSessionConfiguration *)configuration
                              delegate:(id<PFURLSessionDelegate>)delegate {
     // NOTE: cast to id suppresses warning about designated initializer.