Skip to content

Commit 6a50ce4

Browse files
theSlyesttheSlyest
committed
Tests code quality
1 parent 70e587a commit 6a50ce4

File tree

2 files changed

+133
-133
lines changed

2 files changed

+133
-133
lines changed

‎Parse.Tests/ObjectCoderTests.cs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
using System.Collections.Generic;
77
using System.Diagnostics;
88

9+
namespace Parse.Tests;
10+
911
[TestClass]
1012
public class ObjectCoderTests
1113
{

‎Parse.Tests/SessionTests.cs‎

Lines changed: 131 additions & 133 deletions
Original file line numberDiff line numberDiff line change
@@ -10,174 +10,172 @@
1010
using Parse.Platform.Objects;
1111
using Parse.Abstractions.Platform.Users;
1212

13-
namespace Parse.Tests
13+
namespace Parse.Tests;
14+
15+
[TestClass]
16+
public class SessionTests
1417
{
18+
private ParseClient Client { get; }
1519

16-
[TestClass]
17-
public class SessionTests
20+
public SessionTests()
1821
{
19-
private ParseClient Client { get; }
22+
// Initialize the client
23+
Client = new ParseClient(new ServerConnectionData { Test = true });
24+
Client.Publicize(); // Ensure the client instance is globally available
2025

21-
public SessionTests()
22-
{
23-
// Initialize the client
24-
Client = new ParseClient(new ServerConnectionData { Test = true });
25-
Client.Publicize(); // Ensure the client instance is globally available
26+
// Register the valid classes
27+
Client.AddValidClass<ParseSession>();
28+
Client.AddValidClass<ParseUser>();
29+
}
2630

27-
// Register the valid classes
28-
Client.AddValidClass<ParseSession>();
29-
Client.AddValidClass<ParseUser>();
30-
}
31+
[TestInitialize]
32+
public void SetUp()
33+
{
34+
// Additional setup can go here
35+
}
3136

32-
[TestInitialize]
33-
public void SetUp()
34-
{
35-
// Additional setup can go here
36-
}
37+
[TestCleanup]
38+
public void TearDown()
39+
{
40+
// Reset any state if necessary
41+
(Client.Services as ServiceHub)?.Reset();
42+
}
3743

38-
[TestCleanup]
39-
public void TearDown()
40-
{
41-
// Reset any state if necessary
42-
(Client.Services as ServiceHub)?.Reset();
43-
}
44+
[TestMethod]
45+
public void TestGetSessionQuery()
46+
{
47+
// Test that GetSessionQuery returns the correct type
48+
Assert.IsInstanceOfType(Client.GetSessionQuery(), typeof(ParseQuery<ParseSession>));
49+
}
4450

45-
[TestMethod]
46-
public void TestGetSessionQuery()
47-
{
48-
// Test that GetSessionQuery returns the correct type
49-
Assert.IsInstanceOfType(Client.GetSessionQuery(), typeof(ParseQuery<ParseSession>));
50-
}
51+
[TestMethod]
52+
public void TestGetSessionToken()
53+
{
54+
var session = Client.GenerateObjectFromState<ParseSession>(
55+
new MutableObjectState
56+
{
57+
ServerData = new Dictionary<string, object> { ["sessionToken"] = "llaKcolnu" }
58+
},
59+
"_Session"
60+
);
5161

52-
[TestMethod]
53-
public void TestGetSessionToken()
54-
{
55-
var session = Client.GenerateObjectFromState<ParseSession>(
56-
new MutableObjectState
57-
{
58-
ServerData = new Dictionary<string, object> { ["sessionToken"] = "llaKcolnu" }
59-
},
60-
"_Session"
61-
);
62-
63-
Assert.IsNotNull(session);
64-
Assert.AreEqual("llaKcolnu", session.SessionToken);
65-
}
66-
67-
[TestMethod]
68-
public async Task TestGetCurrentSessionAsync()
62+
Assert.IsNotNull(session);
63+
Assert.AreEqual("llaKcolnu", session.SessionToken);
64+
}
65+
66+
[TestMethod]
67+
public async Task TestGetCurrentSessionAsync()
68+
{
69+
// Set up the service hub and mock controllers
70+
var hub = new MutableServiceHub();
71+
var client = new ParseClient(new ServerConnectionData { Test = true }, hub);
72+
73+
var sessionState = new MutableObjectState
6974
{
70-
// Set up the service hub and mock controllers
71-
var hub = new MutableServiceHub();
72-
var client = new ParseClient(new ServerConnectionData { Test = true }, hub);
75+
ServerData = new Dictionary<string, object> { ["sessionToken"] = "newllaKcolnu" }
76+
};
7377

74-
var sessionState = new MutableObjectState
75-
{
76-
ServerData = new Dictionary<string, object> { ["sessionToken"] = "newllaKcolnu" }
77-
};
78+
// Mock session controller
79+
var mockController = new Mock<IParseSessionController>();
80+
mockController
81+
.Setup(obj => obj.GetSessionAsync(It.IsAny<string>(), It.IsAny<IServiceHub>(), It.IsAny<CancellationToken>()))
82+
.ReturnsAsync(sessionState);
7883

79-
// Mock session controller
80-
var mockController = new Mock<IParseSessionController>();
81-
mockController
82-
.Setup(obj => obj.GetSessionAsync(It.IsAny<string>(), It.IsAny<IServiceHub>(), It.IsAny<CancellationToken>()))
83-
.ReturnsAsync(sessionState);
84+
// Mock user controller
85+
var userState = new MutableObjectState
86+
{
87+
ServerData = new Dictionary<string, object> { ["sessionToken"] = "llaKcolnu" }
88+
};
8489

85-
// Mock user controller
86-
var userState = new MutableObjectState
87-
{
88-
ServerData = new Dictionary<string, object> { ["sessionToken"] = "llaKcolnu" }
89-
};
90+
var user = client.GenerateObjectFromState<ParseUser>(userState, "_User");
9091

91-
var user = client.GenerateObjectFromState<ParseUser>(userState, "_User");
92+
var mockCurrentUserController = new Mock<IParseCurrentUserController>();
93+
mockCurrentUserController
94+
.Setup(obj => obj.GetAsync(It.IsAny<IServiceHub>(), It.IsAny<CancellationToken>()))
95+
.ReturnsAsync(user);
9296

93-
var mockCurrentUserController = new Mock<IParseCurrentUserController>();
94-
mockCurrentUserController
95-
.Setup(obj => obj.GetAsync(It.IsAny<IServiceHub>(), It.IsAny<CancellationToken>()))
96-
.ReturnsAsync(user);
97+
hub.SessionController = mockController.Object;
98+
hub.CurrentUserController = mockCurrentUserController.Object;
9799

98-
hub.SessionController = mockController.Object;
99-
hub.CurrentUserController = mockCurrentUserController.Object;
100+
var session = await client.GetCurrentSessionAsync();
100101

101-
var session = await client.GetCurrentSessionAsync();
102+
// Assertions
103+
Assert.IsNotNull(session);
104+
Assert.AreEqual("newllaKcolnu", session.SessionToken);
102105

103-
// Assertions
104-
Assert.IsNotNull(session);
105-
Assert.AreEqual("newllaKcolnu", session.SessionToken);
106+
// Verify that the session controller was called with the correct session token
107+
mockController.Verify(
108+
obj => obj.GetSessionAsync("llaKcolnu", It.IsAny<IServiceHub>(), It.IsAny<CancellationToken>()),
109+
Times.Once
110+
);
111+
}
106112

107-
// Verify that the session controller was called with the correct session token
108-
mockController.Verify(
109-
obj => obj.GetSessionAsync("llaKcolnu", It.IsAny<IServiceHub>(), It.IsAny<CancellationToken>()),
110-
Times.Once
111-
);
112-
}
113+
[TestMethod]
114+
public async Task TestGetCurrentSessionWithNoCurrentUserAsync()
115+
{
116+
var hub = new MutableServiceHub();
117+
var client = new ParseClient(new ServerConnectionData { Test = true }, hub);
113118

114-
[TestMethod]
115-
public async Task TestGetCurrentSessionWithNoCurrentUserAsync()
116-
{
117-
var hub = new MutableServiceHub();
118-
var client = new ParseClient(new ServerConnectionData { Test = true }, hub);
119+
var mockController = new Mock<IParseSessionController>();
120+
var mockCurrentUserController = new Mock<IParseCurrentUserController>();
119121

120-
var mockController = new Mock<IParseSessionController>();
121-
var mockCurrentUserController = new Mock<IParseCurrentUserController>();
122+
hub.SessionController = mockController.Object;
123+
hub.CurrentUserController = mockCurrentUserController.Object;
122124

123-
hub.SessionController = mockController.Object;
124-
hub.CurrentUserController = mockCurrentUserController.Object;
125+
var session = await client.GetCurrentSessionAsync();
125126

126-
var session = await client.GetCurrentSessionAsync();
127+
// Assertions
128+
Assert.IsNull(session);
129+
}
127130

128-
// Assertions
129-
Assert.IsNull(session);
130-
}
131+
[TestMethod]
132+
public async Task TestRevokeAsync()
133+
{
134+
var hub = new MutableServiceHub();
135+
var client = new ParseClient(new ServerConnectionData { Test = true }, hub);
131136

132-
[TestMethod]
133-
public async Task TestRevokeAsync()
134-
{
135-
var hub = new MutableServiceHub();
136-
var client = new ParseClient(new ServerConnectionData { Test = true }, hub);
137+
var mockController = new Mock<IParseSessionController>();
138+
mockController.Setup(sessionController => sessionController.IsRevocableSessionToken(It.IsAny<string>())).Returns(true);
137139

138-
var mockController = new Mock<IParseSessionController>();
139-
mockController.Setup(sessionController => sessionController.IsRevocableSessionToken(It.IsAny<string>())).Returns(true);
140+
hub.SessionController = mockController.Object;
140141

141-
hub.SessionController = mockController.Object;
142+
using var cancellationTokenSource = new CancellationTokenSource();
143+
await client.RevokeSessionAsync("r:someSession", cancellationTokenSource.Token);
142144

143-
using var cancellationTokenSource = new CancellationTokenSource();
144-
await client.RevokeSessionAsync("r:someSession", cancellationTokenSource.Token);
145+
// Assertions
146+
mockController.Verify(
147+
obj => obj.RevokeAsync("r:someSession", cancellationTokenSource.Token),
148+
Times.Once
149+
);
150+
}
145151

146-
// Assertions
147-
mockController.Verify(
148-
obj => obj.RevokeAsync("r:someSession", cancellationTokenSource.Token),
149-
Times.Once
150-
);
151-
}
152+
[TestMethod]
153+
public async Task TestUpgradeToRevocableSessionAsync()
154+
{
155+
var hub = new MutableServiceHub();
156+
var client = new ParseClient(new ServerConnectionData { Test = true }, hub);
152157

153-
[TestMethod]
154-
public async Task TestUpgradeToRevocableSessionAsync()
158+
var state = new MutableObjectState
155159
{
156-
var hub = new MutableServiceHub();
157-
var client = new ParseClient(new ServerConnectionData { Test = true }, hub);
158-
159-
var state = new MutableObjectState
160-
{
161-
ServerData = new Dictionary<string, object> { ["sessionToken"] = "llaKcolnu" }
162-
};
160+
ServerData = new Dictionary<string, object> { ["sessionToken"] = "llaKcolnu" }
161+
};
163162

164-
var mockController = new Mock<IParseSessionController>();
165-
mockController
166-
.Setup(obj => obj.UpgradeToRevocableSessionAsync(It.IsAny<string>(), It.IsAny<IServiceHub>(), It.IsAny<CancellationToken>()))
167-
.ReturnsAsync(state);
163+
var mockController = new Mock<IParseSessionController>();
164+
mockController
165+
.Setup(obj => obj.UpgradeToRevocableSessionAsync(It.IsAny<string>(), It.IsAny<IServiceHub>(), It.IsAny<CancellationToken>()))
166+
.ReturnsAsync(state);
168167

169-
hub.SessionController = mockController.Object;
168+
hub.SessionController = mockController.Object;
170169

171-
using var cancellationTokenSource = new CancellationTokenSource();
172-
var sessionToken = await client.UpgradeToRevocableSessionAsync("someSession", cancellationTokenSource.Token);
170+
using var cancellationTokenSource = new CancellationTokenSource();
171+
var sessionToken = await client.UpgradeToRevocableSessionAsync("someSession", cancellationTokenSource.Token);
173172

174-
// Assertions
175-
Assert.AreEqual("llaKcolnu", sessionToken);
173+
// Assertions
174+
Assert.AreEqual("llaKcolnu", sessionToken);
176175

177-
mockController.Verify(
178-
obj => obj.UpgradeToRevocableSessionAsync("someSession", It.IsAny<IServiceHub>(), cancellationTokenSource.Token),
179-
Times.Once
180-
);
181-
}
176+
mockController.Verify(
177+
obj => obj.UpgradeToRevocableSessionAsync("someSession", It.IsAny<IServiceHub>(), cancellationTokenSource.Token),
178+
Times.Once
179+
);
182180
}
183181
}

0 commit comments

Comments
 (0)