feat: Remove Parse.serverAuthType, Parse.serverAuthToken infavor of CoreManager REQUEST_HEADERS config (#2639)

BREAKING CHANGE: The methods `Parse.serverAuthType()` and `Parse.serverAuthToken()` have been removed; use the CoreManager `REQUEST_HEADER` config to set authorization headers instead.

Author: dplewis

src/CoreManager.ts

@@ -339,8 +339,6 @@ const config: Config & Record<string, any> = {
   REQUEST_BATCH_SIZE: 20,
   REQUEST_HEADERS: {},
   SERVER_URL: 'https://api.parse.com/1',
-  SERVER_AUTH_TYPE: null,
-  SERVER_AUTH_TOKEN: null,
   LIVEQUERY_SERVER_URL: null,
   ENCRYPTED_KEY: null,
   VERSION: 'js' + process.env.npm_package_version,

src/Parse.ts

@@ -226,28 +226,6 @@ const Parse = {
     return CoreManager.get('SERVER_URL');
   },
 
-  /**
-   * @property {string} Parse.serverAuthToken
-   * @static
-   */
-  set serverAuthToken(value) {
-    CoreManager.set('SERVER_AUTH_TOKEN', value);
-  },
-  get serverAuthToken() {
-    return CoreManager.get('SERVER_AUTH_TOKEN');
-  },
-
-  /**
-   * @property {string} Parse.serverAuthType
-   * @static
-   */
-  set serverAuthType(value) {
-    CoreManager.set('SERVER_AUTH_TYPE', value);
-  },
-  get serverAuthType() {
-    return CoreManager.get('SERVER_AUTH_TYPE');
-  },
-
   /**
    * @property {ParseLiveQuery} Parse.LiveQuery
    * @static

src/RESTController.ts

@@ -132,10 +132,6 @@ const RESTController = {
       if (isIdempotent) {
         headers['X-Parse-Request-Id'] = requestId;
       }
-      if (CoreManager.get('SERVER_AUTH_TYPE') && CoreManager.get('SERVER_AUTH_TOKEN')) {
-        headers['Authorization'] =
-          CoreManager.get('SERVER_AUTH_TYPE') + ' ' + CoreManager.get('SERVER_AUTH_TOKEN');
-      }
       const customHeaders = CoreManager.get('REQUEST_HEADERS');
       for (const key in customHeaders) {
         headers[key] = customHeaders[key];

src/__tests__/Parse-test.js

@@ -69,16 +69,6 @@ describe('Parse module', () => {
     expect(Parse.liveQueryServerURL).toBe('https://example.com');
   });
 
-  it('can set auth type and token', () => {
-    Parse.serverAuthType = 'bearer';
-    expect(CoreManager.get('SERVER_AUTH_TYPE')).toBe('bearer');
-    expect(Parse.serverAuthType).toBe('bearer');
-
-    Parse.serverAuthToken = 'some_token';
-    expect(CoreManager.get('SERVER_AUTH_TOKEN')).toBe('some_token');
-    expect(Parse.serverAuthToken).toBe('some_token');
-  });
-
   it('can set idempotency', () => {
     expect(Parse.idempotency).toBe(false);
     Parse.idempotency = true;

src/__tests__/RESTController-test.js

@@ -369,16 +369,6 @@ describe('RESTController', () => {
     }).toThrow('Cannot use the Master Key, it has not been provided.');
   });
 
-  it('sends auth header when the auth type and token flags are set', async () => {
-    CoreManager.set('SERVER_AUTH_TYPE', 'Bearer');
-    CoreManager.set('SERVER_AUTH_TOKEN', 'some_random_token');
-    mockFetch([{ status: 200, response: { results: [] } }]);
-    await RESTController.request('GET', 'classes/MyObject', {}, {});
-    expect(fetch.mock.calls[0][1].headers['Authorization']).toEqual('Bearer some_random_token');
-    CoreManager.set('SERVER_AUTH_TYPE', null);
-    CoreManager.set('SERVER_AUTH_TOKEN', null);
-  });
-
   it('reports upload/download progress of the AJAX request when callback is provided', async () => {
     mockFetch([{ status: 200, response: { success: true } }], { 'Content-Length': 10 });
     const options = {

types/Parse.d.ts

@@ -282,16 +282,6 @@ declare const Parse: {
      * @static
      */
     serverURL: any;
-    /**
-     * @property {string} Parse.serverAuthToken
-     * @static
-     */
-    serverAuthToken: any;
-    /**
-     * @property {string} Parse.serverAuthType
-     * @static
-     */
-    serverAuthType: any;
     /**
      * @property {ParseLiveQuery} Parse.LiveQuery
      * @static