LiveQuery subscribe with sessionToken (#791)

* LiveQuery subscribe with sessionToken

* fix tests

* improve test

Author: dplewis

integration/test/ParseLiveQueryTest.js

@@ -12,6 +12,7 @@ describe('Parse LiveQuery', () => {
   beforeEach((done) => {
     Parse.initialize('integration');
     Parse.CoreManager.set('SERVER_URL', 'http://localhost:1337/parse');
+    Parse.User.enableUnsafeCurrentUser();
     Parse.Storage._clear();
     clear().then(done).catch(done.fail);
   });
@@ -135,4 +136,23 @@ describe('Parse LiveQuery', () => {
     await sleep(1000);
     assert.equal(count, 1);
   });
+
+  it('can subscribe to ACL', async (done) => {
+    const user = await Parse.User.signUp('ooo', 'password');
+    const ACL = new Parse.ACL(user);
+
+    const object = new TestObject();
+    object.setACL(ACL);
+    await object.save();
+
+    const query = new Parse.Query(TestObject);
+    query.equalTo('objectId', object.id);
+    const subscription = await query.subscribe(user.getSessionToken());
+    subscription.on('update', async (object) => {
+      assert.equal(object.get('foo'), 'bar');
+      await Parse.User.logOut();
+      done();
+    })
+    await object.save({ foo: 'bar' });
+  });
 });

src/ParseQuery.js

@@ -1483,13 +1483,15 @@ class ParseQuery {
   /**
    * Subscribe this query to get liveQuery updates
    *
+   * @param {String} sessionToken (optional) Defaults to the currentUser
    * @return {Promise<LiveQuerySubscription>} Returns the liveQuerySubscription, it's an event emitter
    * which can be used to get liveQuery updates.
    */
-  async subscribe(): Promise<LiveQuerySubscription> {
+  async subscribe(sessionToken?: string): Promise<LiveQuerySubscription> {
     const currentUser = await CoreManager.getUserController().currentUserAsync();
-    const sessionToken =  currentUser ? currentUser.getSessionToken() : undefined;
-
+    if (!sessionToken) {
+      sessionToken =  currentUser ? currentUser.getSessionToken() : undefined;
+    }
     const liveQueryClient = await CoreManager.getLiveQueryController().getDefaultLiveQueryClient();
     if (liveQueryClient.shouldOpen()) {
       liveQueryClient.open();

src/__tests__/ParseQuery-test.js

@@ -2718,4 +2718,31 @@ describe('ParseQuery LocalDatastore', () => {
     expect(subscription.sessionToken).toBeUndefined();
     expect(subscription.query).toEqual(query);
   });
+
+  it('can subscribe to query with sessionToken parameter', async () => {
+    const mockLiveQueryClient = {
+      shouldOpen: function() {
+        return true;
+      },
+      open: function() {},
+      subscribe: function(query, sessionToken) {
+        return new LiveQuerySubscription('0', query, sessionToken);
+      },
+    };
+    CoreManager.set('UserController', {
+      currentUserAsync() {
+        return Promise.resolve(null);
+      }
+    });
+    CoreManager.set('LiveQueryController', {
+      getDefaultLiveQueryClient() {
+        return Promise.resolve(mockLiveQueryClient);
+      }
+    });
+    const query = new ParseQuery('TestObject');
+    const subscription = await query.subscribe('r:test');
+    expect(subscription.id).toBe('0');
+    expect(subscription.sessionToken).toBe('r:test');
+    expect(subscription.query).toEqual(query);
+  });
 });